Hi Joe,
>
> OK, and how do you set that up so that it has the Cordova APIs?
>
This code is from Crosswalk shell which does nothing with Cordova API.
However, crosswalk downstream fork of cordova-android is using inheritance as:
https://github.com/crosswalk-project/crosswalk-cordova-android/blo
OK, and how do you set that up so that it has the Cordova APIs?
On Mon Feb 02 2015 at 9:51:55 PM Hu, Ningxin wrote:
> Hi Joe,
>
> > That's part of it. What's the setup code for that look like?
>
> https://github.com/crosswalk-project/crosswalk/blob/master/
> runtime/android/core_shell/src/org/x
Hi Joe,
> That's part of it. What's the setup code for that look like?
https://github.com/crosswalk-project/crosswalk/blob/master/runtime/android/core_shell/src/org/xwalk/core/xwview/shell/XWalkViewSectionFragment.java#L40
Thanks,
-ningxin
>
> On Wed Jan 28 2015 at 7:15:10 PM Hu, Ningxin
> w
That's part of it. What's the setup code for that look like?
On Wed Jan 28 2015 at 7:15:10 PM Hu, Ningxin wrote:
> Hi Joe,
> >
> > I have never seen an example of Crosswalk using Android XML layouts, and
> > as far as I'm currently aware, embedding Crosswalk is less
> straightforward
> > than e
Hi Joe,
>
> I have never seen an example of Crosswalk using Android XML layouts, and
> as far as I'm currently aware, embedding Crosswalk is less straightforward
> than embedding AndroidWebView or MozillaWebView.
>
Is this what you are looking for?
https://github.com/crosswalk-project/crosswalk
On Wed Jan 28 2015 at 10:42:46 AM Andrew Grieve
wrote:
> I think we're talking about the same thing.
>
> You can have an XWalkCordovaView within a layout, and then attach
> a XWalkCordovaWebView to it in code afterwards.
>
> What might be even better though, is if we made CordovaWebView extend Vi
I think we're talking about the same thing.
You can have an XWalkCordovaView within a layout, and then attach
a XWalkCordovaWebView to it in code afterwards.
What might be even better though, is if we made CordovaWebView extend View
(probably AbsoluteLayout), and then you wouldn't have to change
What is your definition of embedding a view? I think we're talking about
two different things. What I'm talking about is being able to embed
AndroidWebView as an embedded view without having to change any code other
than the name of the class. This means that you don't have to worry about
the con
You can still embed a view using composition. We are not providing any
backwards compatibility right now, even with inheritance, because
CordovaWebView is no longer a View (it's an interface, which requires an
explicit cast to (View), or a call to .getView() to be considered as a View)
On Wed, Jan
I completely disagree, and think we should go the inheritance pattern. The
reason for that is that we have to provide backwards compatibility for some
views where the implementation is a view, and there's no dual inheritance
in Java, which is the only way that I can see us accommodating both types
I'd prefer to go the other way, and change AndroidWebView to composition.
It's more flexible and does a better job of splitting up groups of APIs.
On Wed, Jan 28, 2015 at 12:49 AM, Hu, Ningxin wrote:
> Hi Joe,
> >
> > The tests don't work with Crosswalk because Crosswalk's main class
> doesn't
>
Hi Joe,
>
> The tests don't work with Crosswalk because Crosswalk's main class doesn't
> inherit from a view. This is why we had to change the CordovaWebView
> from being a class to being an Interface in the first place. I don't think
> there is
> a way for these tests to work with Crosswalk be
Thank you so much for supporting positively Crosswalk into JUnit tests.
-Original Message-
From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve
Sent: Wednesday, January 21, 2015 10:46 PM
To: dev
Subject: Re: cordova-android 4.0 JUnit tests
On Wed, Jan 21, 2015
lf Of Andrew
> Grieve
> Sent: Wednesday, January 21, 2015 4:01 AM
> To: Andrew Grieve
> Cc: dev
> Subject: Re: cordova-android 4.0 JUnit tests
>
> Also - maybe leave the inflate test using AndroidWebView, and make the
> other ones create dynamically?
>
> On Tue, Jan 2
ogle.com] On Behalf Of Andrew Grieve
Sent: Wednesday, January 21, 2015 4:01 AM
To: Andrew Grieve
Cc: dev
Subject: Re: cordova-android 4.0 JUnit tests
Also - maybe leave the inflate test using AndroidWebView, and make the other
ones create dynamically?
On Tue, Jan 20, 2015 at 2:59 PM, Andrew Gr
Also - maybe leave the inflate test using AndroidWebView, and make the
other ones create dynamically?
On Tue, Jan 20, 2015 at 2:59 PM, Andrew Grieve wrote:
> gotcha. I've now got tests building & running with gradle (painful
> learning curve...). I'm going to pull in the changes from this PR tha
gotcha. I've now got tests building & running with gradle (painful learning
curve...). I'm going to pull in the changes from this PR that fix the
compile, but will leave the rest.
Junwei - do the tests pass for you? I certainly can't get most of them to
(running on KitKat) :(
On Tue, Jan 20, 2015
It's an issue because this test was supposed to be testing the embedding of
a WebView via layout. That's why the inflate exists in the code. By
creating the webview directly, it's not actually testing anything of
value. We actually lose test coverage with this change.
On Tue Jan 20 2015 at 9:5
Nice. I've got a gradle file that now at least builds the application, so
not far off of having it run the tests.
Totally on board with re-writing the unit tests (they have an unfortunate
number of Thread.sleep() in them). But this PR at least makes them compile
on 4.0.x. Maybe add some comments t
It was easier to get the tests to run in Android Studio than it was to get
Cordova itself to run. You just import them in as an Eclipse project and it
just works. I was surprised when I did this a few days ago.
I don't like this pull request because it removes all tests of the
AndroidWebView comp
I think Junwei is saying that he has got them to work in his PR.
I looked at this a while ago, but couldn't figure out how to get the tests
to run in the Android Studio / Gradle world. I'll have another crack at it.
On Tue, Jan 20, 2015 at 8:37 AM, Joe Bowser wrote:
> The tests don't work with
The tests don't work with Crosswalk because Crosswalk's main class doesn't
inherit from a view. This is why we had to change the CordovaWebView from
being a class to being an Interface in the first place. I don't think
there is a way for these tests to work with Crosswalk because of this
incompat
22 matches
Mail list logo
