Re: Remove CDVJson.h from Copy Headers?

2015-01-21 Thread Shazron
Sure, let's create the 4.x branch On Wed, Jan 21, 2015 at 8:03 PM, Andrew Grieve wrote: > I've fixed InAppBrowser to call NSJSONSerializer directly, but I'm > certainly leaning towards the change to rename the symbol to be reverted > and re-applied in a 4.0.x branch. Shall I create one? > > On W

Re: Remove CDVJson.h from Copy Headers?

2015-01-21 Thread Andrew Grieve
I've fixed InAppBrowser to call NSJSONSerializer directly, but I'm certainly leaning towards the change to rename the symbol to be reverted and re-applied in a 4.0.x branch. Shall I create one? On Wed, Jan 21, 2015 at 1:40 PM, Shazron wrote: > Sounds good to me to remove it as a public header -

Re: Remove CDVJson.h from Copy Headers?

2015-01-21 Thread Shazron
Sounds good to me to remove it as a public header - we never documented support for it for use. Since it is kinda public already, we should push this for 4.0 because of CDVInAppBrowser (although if we want to do it now, I suppose we could go the icky way and detect the existence of either the pre

Remove CDVJson.h from Copy Headers?

2015-01-21 Thread Andrew Grieve
RE: https://github.com/apache/cordova-ios/commit/a98144b8ad63fe714c9f6d274bc9fd98b62575e7 issue: https://issues.apache.org/jira/browse/CB-8270 We had an unprefixed extension, and prefixing it is a breaking change (e.g. CDVInAppBrowser was using it). It really is the right thing to do though... We