Re: Supporting multiple plugin return values

2013-02-27 Thread Brian LeRoux
ya that looks great thanks mang On Wed, Feb 27, 2013 at 1:12 PM, Filip Maj wrote: > Thanks Michal! > > On 2/27/13 6:59 AM, "Michal Mocny" wrote: > >>All this work has landed and I've just updated the documentation. Since >>there was no documentation at all for plugin return values, I added a >>

Re: Supporting multiple plugin return values

2013-02-27 Thread Filip Maj
Thanks Michal! On 2/27/13 6:59 AM, "Michal Mocny" wrote: >All this work has landed and I've just updated the documentation. Since >there was no documentation at all for plugin return values, I added a >whole >section about it. If anyone wants to proof read, Commit: >http://git-wip-us.apache.or

Re: Supporting multiple plugin return values

2013-02-27 Thread Michal Mocny
All this work has landed and I've just updated the documentation. Since there was no documentation at all for plugin return values, I added a whole section about it. If anyone wants to proof read, Commit: http://git-wip-us.apache.org/repos/asf/cordova-docs/commit/9927fcdf Also, I've replaced the

Re: Supporting multiple plugin return values

2013-02-14 Thread Max Woghiren
I agree with Shaz—in general we should start using this type of syntax for dictionaries: return @{@"CDVType": @"Multipart", @"messages": messages}; I'd say messageAsMultipart: makes sense, in keeping with the pattern set by the other names. On Thu, Feb 14, 2013 at 9:24 AM, Michal Mocny wrote:

Re: Supporting multiple plugin return values

2013-02-14 Thread Michal Mocny
And also: do we like the name "messageAsMultipart:" or should it just be "messageWithArguments:"? On Thu, Feb 14, 2013 at 9:23 AM, Michal Mocny wrote: > Andrew, > > Yes I was definitely thinking the same thing, but wanted to do that later. > I'll make the change before documenting how multipar

Re: Supporting multiple plugin return values

2013-02-14 Thread Michal Mocny
Andrew, Yes I was definitely thinking the same thing, but wanted to do that later. I'll make the change before documenting how multipart messages work, as shaz suggested. Thanks for giving me a heads up about reference to it on android. Also: other platforms dont use it? -Michal On Wed, Feb

Re: Supporting multiple plugin return values

2013-02-13 Thread Andrew Grieve
My only comment is that I think it's worth refactoring cordova.callbackFromNative so that it passes the multiple values to callbacks as separate parameters. All references to it are in cordova-js plus one in Android's NativeToJsMessageQueue.java On Wed, Feb 13, 2013 at 5:42 PM, Shazron wrote: >

Re: Supporting multiple plugin return values

2013-02-13 Thread Shazron
Looks good to me. Although I have a bone to pick with dictionaryWithObjectsAndKeys having objects first but that's not our problem ;) Good thing they support literal notation now... On Wed, Feb 13, 2013 at 12:24 PM, Michal Mocny wrote: > ping. Shaz? > > > On Tue, Feb 12, 2013 at 11:28 AM, Mich

Re: Supporting multiple plugin return values

2013-02-13 Thread Michal Mocny
ping. Shaz? On Tue, Feb 12, 2013 at 11:28 AM, Michal Mocny wrote: > I've pushed this to a remote branch: multipart_plugin_result for both ios > and js repo's: > > ios: > https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;a=shortlog;h=refs/heads/multipart_plugin_result > js: > https://gi

Re: Supporting multiple plugin return values

2013-02-12 Thread Michal Mocny
I've pushed this to a remote branch: multipart_plugin_result for both ios and js repo's: ios: https://git-wip-us.apache.org/repos/asf?p=cordova-ios.git;a=shortlog;h=refs/heads/multipart_plugin_result js: https://git-wip-us.apache.org/repos/asf?p=cordova-js.git;a=shortlog;h=refs/heads/multipart_plu

Re: Supporting multiple plugin return values

2013-01-19 Thread Shazron
I don't see any problem with it as long as existing plugins (core and third-party) don't break (unless we need to deprecate anything of course) On Fri, Jan 18, 2013 at 11:55 AM, Michal Mocny wrote: > I've filed https://issues.apache.org/jira/browse/CB-2239 but wanted to get > feedback here in c

Supporting multiple plugin return values

2013-01-18 Thread Michal Mocny
I've filed https://issues.apache.org/jira/browse/CB-2239 but wanted to get feedback here in case there a simpler solution to this problem. Basically: I've recently added support for ArrayBuffer argument type across iOS exec bridge and Braden added the same to Android. However, while working on a