camera plugin - target bigger than original picture

Hi, I sent a pull request for the cordova camera plugin : https://github.com/apache/cordova-plugin-camera/pull/238 I was asked to send you an email. This pull request prevents the plugin from creating bigger pictures than original ones. Thanks Fares Hantous Marki http://markiapp.com/

Re: camera plugin - target bigger than original picture

I was the one who asked for the email as I think we should discuss it before merging. I agree with Fares idea, if the height or width are greater than the originals then I think we shouldn't upscale the image and return the original image instead. But that should be documented (current PR doesn't

Re: camera plugin - target bigger than original picture

+1 but with caveats as I outlined in the PR. On Mon, Oct 10, 2016 at 10:16 AM, julio cesar sanchez < jcesarmob...@gmail.com> wrote: > I was the one who asked for the email as I think we should discuss it > before merging. > > I agree with Fares idea, if the height or width are greater than the >

Re: camera plugin - target bigger than original picture

+1 to this PR On Mon, Oct 10, 2016 at 10:38 AM, Shazron wrote: > +1 but with caveats as I outlined in the PR. > > On Mon, Oct 10, 2016 at 10:16 AM, julio cesar sanchez < > jcesarmob...@gmail.com> wrote: > > > I was the one who asked for the email as I think we should discuss it > > before mergin