Re: commit messages for newbies

2013-01-15 Thread Simon MacDonald
+1, maybe we should all follow it :) Simon Mac Donald http://hi.im/simonmacdonald On Fri, Jan 11, 2013 at 1:29 PM, Michael Brooks wrote: > Looks really good, nice work! > > On Fri, Jan 11, 2013 at 9:59 AM, Marcel Kinard wrote: > >> Good points, Michael. >> >> Done. Please tweak further where de

Re: commit messages for newbies

2013-01-11 Thread Michael Brooks
Looks really good, nice work! On Fri, Jan 11, 2013 at 9:59 AM, Marcel Kinard wrote: > Good points, Michael. > > Done. Please tweak further where desired. http://wiki.apache.org/** > cordova/ContributorWorkflow > > -- Marcel > > > On 1/10/2013 2

Re: commit messages for newbies

2013-01-11 Thread Marcel Kinard
Good points, Michael. Done. Please tweak further where desired. http://wiki.apache.org/cordova/ContributorWorkflow -- Marcel On 1/10/2013 2:23 PM, Michael Brooks wrote: @Marcel nice work, I agree we should add this to the wiki article. One note is that I believe you should have an empty lin

Re: commit messages for newbies

2013-01-10 Thread Michael Brooks
@Marcel nice work, I agree we should add this to the wiki article. One note is that I believe you should have an empty line between the summary and detailed body. The Pro Git Books [1] summaries the git messages templates as: Short (50 chars or less) summary of changes More detailed explanatory

RE: commit messages for newbies

2013-01-10 Thread Josh Soref
Marcel wrote: > A note about commit messages: you are highly encouraged to describe your > commit with enough detail for someone else to understand it. In doing > so, your commit message can consist of multiple lines. However, it also > is highly encouraged that the first line of your commit messag

Re: commit messages for newbies

2013-01-10 Thread Becky Gibson
+1 On Thu, Jan 10, 2013 at 11:48 AM, Giorgio Natili wrote: > +1 > > On 1/10/13 4:22 PM, "Marcel Kinard" wrote: > > >I was contemplating adding the following verbage to the > >ContributorWorkflow wiki page. Wanted to float it past the group first > >to see if I got it correct. > > > > > > >

Re: commit messages for newbies

2013-01-10 Thread Giorgio Natili
+1 On 1/10/13 4:22 PM, "Marcel Kinard" wrote: >I was contemplating adding the following verbage to the >ContributorWorkflow wiki page. Wanted to float it past the group first >to see if I got it correct. > > > >A note about commit messages: you are highly encouraged to describe your >commit

commit messages for newbies

2013-01-10 Thread Marcel Kinard
I was contemplating adding the following verbage to the ContributorWorkflow wiki page. Wanted to float it past the group first to see if I got it correct. A note about commit messages: you are highly encouraged to describe your commit with enough detail for someone else to understand it.