cordova-js commits on master but not on 3.2.x branch

2013-11-07 Thread Carlos Santana
Should the following commits should be included for 3.2 specially BB10 changes? * d5e4e9e CB-5307 Remove references to Callback and Incubator * 9740276 CB-5253 remove webworksready event * 6568e94 CB-5253 remove webworks.exec * 9bbf2b7 CB-5247 [BlackBerry10] Map blackberry.event to document * 4e2e

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-07 Thread Steven Gill
Blackberry and Android would need to get retagged. I have no issue with retagging the JS in-regards to firefoxos. Other platform maintainers can chime in. On Thu, Nov 7, 2013 at 2:08 PM, Carlos Santana wrote: > Should the following commits should be included for 3.2 specially BB10 > changes? >

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-07 Thread Shazron
+1 On Thu, Nov 7, 2013 at 2:17 PM, Steven Gill wrote: > Blackberry and Android would need to get retagged. I have no issue with > retagging the JS in-regards to firefoxos. Other platform maintainers can > chime in. > > > On Thu, Nov 7, 2013 at 2:08 PM, Carlos Santana > wrote: > > > Should the

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-07 Thread Jesse
I am a plus one, if these items are intended to be in 3.2.0. Technically, all platforms should be updated so they are all built from the same git commit. @purplecabbage risingj.com On Thu, Nov 7, 2013 at 2:41 PM, Shazron wrote: > +1 > > > On Thu, Nov 7, 2013 at 2:17 PM, Steven Gill > wrote:

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-07 Thread Steven Gill
Alright, lets do it. Carlos, you want to retag the JS? On Thu, Nov 7, 2013 at 2:49 PM, Jesse wrote: > I am a plus one, if these items are intended to be in 3.2.0. > > Technically, all platforms should be updated so they are all built from the > same git commit. > > @purplecabbage > risingj.com

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-07 Thread Carlos Santana
Steve can you go ahead merge amd retag I'm out right now on a cfa meeting. --Carlos On Thursday, November 7, 2013, Steven Gill wrote: > Alright, lets do it. Carlos, you want to retag the JS? > > > On Thu, Nov 7, 2013 at 2:49 PM, Jesse > > wrote: > > > I am a plus one, if these items are intended

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-07 Thread Steven Gill
Alright I got this. On Thu, Nov 7, 2013 at 2:58 PM, Carlos Santana wrote: > Steve can you go ahead merge amd retag I'm out right now on a cfa meeting. > > --Carlos > > On Thursday, November 7, 2013, Steven Gill wrote: > > > Alright, lets do it. Carlos, you want to retag the JS? > > > > > > On T

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-07 Thread Steven Gill
cordova-js has been retagged On Thu, Nov 7, 2013 at 3:01 PM, Steven Gill wrote: > Alright I got this. > > > On Thu, Nov 7, 2013 at 2:58 PM, Carlos Santana wrote: > >> Steve can you go ahead merge amd retag I'm out right now on a cfa meeting. >> >> --Carlos >> >> On Thursday, November 7, 2013, S

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-07 Thread Josh Soref
Carlos wrote: > Should the following commits should be included for 3.2 specially BB10  > changes? On the subject of changes designed for 3.2, this set (for CCB-5258) is the only thing I have that I really want to get it in: ‎https://github.com/apache/cordova-cli/pull/70 https://github.com/apache

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-07 Thread Steven Gill
Sweet. None of these require re-tagging cordova-js. On Thu, Nov 7, 2013 at 3:50 PM, Josh Soref wrote: > Carlos wrote: > > Should the following commits should be included for 3.2 specially > BB10 changes? > > On the subject of changes designed for 3.2, this set (for CCB-5258) is the > only thing

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-07 Thread Carlos Santana
Thank you Steve ! On Thu, Nov 7, 2013 at 8:06 PM, Steven Gill wrote: > Sweet. None of these require re-tagging cordova-js. > > > On Thu, Nov 7, 2013 at 3:50 PM, Josh Soref wrote: > > > Carlos wrote: > > > Should the following commits should be included for 3.2 specially > > BB10 changes? > > >

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-07 Thread purplecabbage
And the js commits for blackberry did not change the js for other platforms! Win win. Sent from my iPhone > On Nov 7, 2013, at 6:56 PM, Carlos Santana wrote: > > Thank you Steve ! > > >> On Thu, Nov 7, 2013 at 8:06 PM, Steven Gill wrote: >> >> Sweet. None of these require re-tagging cordo

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-08 Thread Lorin Beer
currently testing BB, should be retagged in about 10 minutes On Thu, Nov 7, 2013 at 8:59 PM, purplecabbage wrote: > And the js commits for blackberry did not change the js for other > platforms! Win win. > > Sent from my iPhone > > > On Nov 7, 2013, at 6:56 PM, Carlos Santana wrote: > > > > Than

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-08 Thread Lorin Beer
BB has been retagged, fixed an issue which blocked plugin installation. Core is ready, but there are major issues with multiple plugins. On Fri, Nov 8, 2013 at 2:10 PM, Lorin Beer wrote: > currently testing BB, should be retagged in about 10 minutes > > > On Thu, Nov 7, 2013 at 8:59 PM, purplec

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-08 Thread Bryan Higgins
Thanks Lorin. I'll take a look this weekend. Plugin installation has been working correctly without the blank permissions element for a while now. I did not experience any issues with plugins when I tagged earlier this week. On Friday, November 8, 2013, Lorin Beer wrote: > BB has been retagged,

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-08 Thread Lorin Beer
well, I had an updated version of plugman and I checked at multiple tags. I'll do some more investigation. On Fri, Nov 8, 2013 at 3:11 PM, Bryan Higgins wrote: > Thanks Lorin. > > I'll take a look this weekend. Plugin installation has been working > correctly without the blank permissions elemen