[ANNOUNCEMENT] Cordova Plugin SplashScreen 6.0.2 Release

2022-07-15 Thread Bryan Ellis
We have just released an update to our plugins! - cordova-plugin-splashscreen@6.0.2 - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

Re: [VOTE] cordova-plugin-splashscreen 6.0.2 Release

2022-07-15 Thread Bryan Ellis
g appears with Cordova-Android 11 > * Apps build > * tag ok > * no audit issues > * changelog looks good > > On July 12, 2022, Erisu wrote: >> Please review and vote on this cordova-plugin-splashscreen Release >> v6.0.2 >> by replying to this email (and keep dis

Re: [VOTE] cordova-plugin-splashscreen 6.0.2 Release

2022-07-15 Thread Ken Naito
+1 I did: * coho verify-archive OK * coho verify-tags OK * The commit d2937ad489f516d226bef3a17ddfa44e2b7919de is still red but this is OK because test runs with Java 8 not Java 11. On 2022/07/12 19:41, Bryan Ellis wrote: Please review and vote on this cordova-plugin-splashscreen Release

Re: [VOTE] cordova-plugin-splashscreen 6.0.2 Release

2022-07-15 Thread Niklas Merz
I vote +1 * signature & hash ok * warning appears with Cordova-Android 11 * Apps build * tag ok * no audit issues * changelog looks good On July 12, 2022, Erisu wrote: > Please review and vote on this cordova-plugin-splashscreen Release > v6.0.2 > by replying to this email (and ke

[VOTE] cordova-plugin-splashscreen 6.0.2 Release

2022-07-12 Thread Bryan Ellis
Please review and vote on this cordova-plugin-splashscreen Release v6.0.2 by replying to this email (and keep discussion on the DISCUSS thread) The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/splashscreen-v6.0.2 <https://dist.apache.org/repos/d

[DISCUSS] cordova-plugin-splashscreen 6.0.2 Release

2022-07-10 Thread Bryan Ellis
Does anyone have any reason to delay a release for the following plugin? * cordova-plugin-splashscreen (6.0.2) * https://github.com/apache/cordova-plugin-splashscreen/compare/rel/6.0.1...master <https://github.com/apache/cordova-plugin-splashscreen/compare/rel/6.0.1...master> Any addi

[ANNOUNCE] cordova-plugin-splashscreen 6.0.1 released!

2022-04-06 Thread Niklas Merz
cordova-plugin-splashscreen@6.0.1 has been released! Blog: https://cordova.apache.org/news/2022/04/06/splashscreen-plugin- release.html

Re: [VOTE] cordova-plugin-splashscreen release 6.0.1 patch release

2022-04-06 Thread Niklas Merz
hrader.com/> | NEXT AGENCY > > From: Norman Breau > Date: Tuesday, 5. April 2022 at 02:14 > To: dev@cordova.apache.org > Subject: [External] Re: [VOTE] cordova-plugin-splashscreen release > 6.0.1 patch release > This message is from an EXTERNAL SENDER - be CAUTIOUS, par

Re: [External] [DISCUSS] cordova-plugin-splashscreen release 6.0.1

2022-04-05 Thread Niklas Merz
<https://www.sinnerschrader.com/> | NEXT AGENCY > > From: Niklas Merz > Date: Saturday, 2. April 2022 at 13:15 > To: dev@cordova.apache.org > Subject: [External] [DISCUSS] cordova-plugin-splashscreen release > 6.0.1 > This message is from an EXTERNAL SENDER - be CAUTIOUS, p

Re: [External] [DISCUSS] cordova-plugin-splashscreen release 6.0.1

2022-04-05 Thread Brust, Tim
<https://www.sinnerschrader.com/> | NEXT AGENCY From: Niklas Merz Date: Saturday, 2. April 2022 at 13:15 To: dev@cordova.apache.org Subject: [External] [DISCUSS] cordova-plugin-splashscreen release 6.0.1 This message is from an EXTERNAL SENDER - be CAUTIOUS, particularly with links and attach

Re: [External] Re: [VOTE] cordova-plugin-splashscreen release 6.0.1 patch release

2022-04-05 Thread Brust, Tim
/> | NEXT AGENCY From: Norman Breau Date: Tuesday, 5. April 2022 at 02:14 To: dev@cordova.apache.org Subject: [External] Re: [VOTE] cordova-plugin-splashscreen release 6.0.1 patch release This message is from an EXTERNAL SENDER - be CAUTIOUS, particularly with links and attachments

Re: [VOTE] cordova-plugin-splashscreen release 6.0.1 patch release

2022-04-04 Thread Norman Breau
: https://dist.apache.org/repos/dist/dev/cordova/splashscreen-6.0.1/ The packages were published from their corresponding git tags: cordova-plugin-splashscreen: 6.0.1 (35c22a8a1a) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post

[VOTE] cordova-plugin-splashscreen release 6.0.1 patch release

2022-04-04 Thread Niklas Merz
their corresponding git tags: cordova-plugin-splashscreen: 6.0.1 (35c22a8a1a) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova- coho/blob/master/docs/release-voting.md How to vote on a plugins

[GitHub] [cordova-plugin-splashscreen] NiklasMerz commented on a diff in pull request #310: applied changes in SplashScreen that allows get ScaleType and backgroundColor from preferences

2022-04-04 Thread GitBox
NiklasMerz commented on code in PR #310: URL: https://github.com/apache/cordova-plugin-splashscreen/pull/310#discussion_r841481621 ## src/android/SplashScreen.java: ## @@ -393,6 +390,7 @@ public void onCancel(DialogInterface dialog

[DISCUSS] cordova-plugin-splashscreen release 6.0.1

2022-04-02 Thread Niklas Merz
Does anyone have any reason to delay a small patch release? Any outstanding patches to land? I created a milestone with patches to review: https://github.com/apache/cordova-plugin- splashscreen/milestone/4 If not, I will start the release in the next days.

Re: [VOTE] Cordova Plugin SplashScreen 6.0.0 Release

2020-07-19 Thread Bryan Ellis
> * checked signature > * checked audit issue (no patch available) > * checked LICENSE and NOTICE > * verified tag > * CI green for tag > * checked license headers > * checked licenses with coho > > > > Am 07.07.20 um 09:10 schrieb Bryan Ellis: >> Please review

Re: [VOTE] Cordova Plugin SplashScreen 6.0.0 Release

2020-07-17 Thread Ken Naito
+1 * coho verify-archive OK * coho verify-tags OK * latest commit (https://github.com/apache/cordova-plugin-splashscreen/commit/a9e73eb64280cab088b504043cf287bce33724fc ) is green. On 2020/07/07 16:10, Bryan Ellis wrote: cordova-plugin-splashscreen: 6.0.0 (a9e73eb642

Re: [VOTE] Cordova Plugin SplashScreen 6.0.0 Release

2020-07-07 Thread Niklas Merz
ote on this Cordova Plugin SplashScreen Release v6.0.0 > by replying to this email (and keep discussion on the DISCUSS thread) > > The archive has been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/splashscreen-20200707 > > The package was published from its

[VOTE] Cordova Plugin SplashScreen 6.0.0 Release

2020-07-07 Thread Bryan Ellis
Please review and vote on this Cordova Plugin SplashScreen Release v6.0.0 by replying to this email (and keep discussion on the DISCUSS thread) The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/splashscreen-20200707 The package was published from its

[DISCUSS] cordova-plugin-splashscreen 6.0.0 Major Release

2020-06-28 Thread Bryan Ellis
Does anyone have any reason to delay a cordova-plugin-splashscreen major release (6.0.0)? Any additional outstanding changes to land? If not, I will start the release process shortly. - To unsubscribe, e-mail: dev-unsubscr

[ANNOUNCEMENT] cordova-plugin-splashscreen 5.0.4 Release

2020-06-06 Thread Niklas Merz
We have just released a patch update to our splashscreen plugin cordova-plugin-splashscreen@5.0.4 A release blog post is following soon with another plugin release - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org

Re: [VOTE] cordova-plugin-splashscreen Release 5.0.3

2019-07-02 Thread Jan Piotrowski
e DISCUSS thread) > > > > The plugins have been published to dist/dev: > > https://dist.apache.org/repos/dist/dev/cordova/splash20190509/ > > > > The packages were published from their corresponding git tags: > > cordova-plugin-splashscreen: 5.0.3 (5339fcf3

Re: [VOTE] cordova-plugin-splashscreen Release 5.0.3

2019-06-27 Thread Tim Brust
ussion on the DISCUSS thread) > > The plugins have been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/splash20190509/ > > The packages were published from their corresponding git tags: > cordova-plugin-splashscreen: 5.0.3 (5339fcf377) > > Upon a

Re: [VOTE] cordova-plugin-splashscreen Release 5.0.3

2019-06-23 Thread Bryan Ellis
(and keep discussion on the DISCUSS thread) > > The plugins have been published to dist/dev: > https://dist.apache.org/repos/dist/dev/cordova/splash20190509/ > > The packages were published from their corresponding git tags: > cordova-plugin-splashscreen: 5.0.3 (5339fcf377)

[VOTE] cordova-plugin-splashscreen Release 5.0.3

2019-05-09 Thread Jan Piotrowski
tags: cordova-plugin-splashscreen: 5.0.3 (5339fcf377) Upon a successful vote I will upload the archives to dist/, upload them to npm, and post the corresponding blog post. Voting guidelines: https://github.com/apache/cordova-coho/blob/master/docs/release-voting.md How to vote on a plugins

[GitHub] cordova-plugin-splashscreen pull request #133: Added LaunchImageFileCustom f...

2017-09-05 Thread adelmojunnior
GitHub user adelmojunnior opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/133 Added LaunchImageFileCustom for hybrid app and multiples Launch Images You can merge this pull request into a Git repository by running: $ git pull https

[GitHub] cordova-plugin-splashscreen issue #132: Auto Hide Splashscreen issue in andr...

2017-09-02 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/132 Hi, You have created a Pull Request by mistake, can you close it? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-splashscreen pull request #132: Auto Hide Splashscreen issue ...

2017-09-02 Thread mobileias
GitHub user mobileias opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/132 Auto Hide Splashscreen issue in android Hello We are creating build using phonegap web site. We use below phonegap cli `` also use latest

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-08-24 Thread uj
Github user uj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @Lazza Ok, i just tried your fix, and it crashes less often, but not 100% crash-free. However, this mostly happens when using the back-button to "exit" t

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-08-24 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @uj does my fix work on that device as well? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-08-24 Thread uj
Github user uj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Will this fix be added to the official apache version? I can confirm that cordova-plugin-splashscreen crashes Morotola X Gen 3, Android 6, not just Samsung devices. --- If your

[GitHub] cordova-plugin-splashscreen pull request #27: Support iPhone 6/6+ by using U...

2017-08-22 Thread noisysocks
Github user noisysocks closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-splashscreen pull request #131: CB-13028 (CI) Browser builds ...

2017-07-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/131 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-splashscreen pull request #131: CB-13028 (CI) Browser builds ...

2017-07-28 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/131 CB-13028 (CI) Browser builds on Travis and AppVeyor ### Platforms affected Browser ### What does this PR do? Enables AppVeyor and Travis to run tests

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-28 Thread SharUpOff
Github user SharUpOff commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 @filmaj, thank you for the prompt response! (: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-26 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 Confirmed that this patch fixes the crash. Merged it in. Thanks for the contribution @SharUpOff! + on your first ever GitHub PR, too --- If your project is set up

[GitHub] cordova-plugin-splashscreen pull request #130: CB-13094: (android) Don't sho...

2017-07-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/130 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-26 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 Going to about:blank is done as a garbage collection technique before closing out the WebView entirely so that the memory is freed. There's a hilarious TODO here saying

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-26 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 And @SharUpOff your intuition is confirmed: the logcat logs show that after pressing the back button in my app after loading it up, Cordova tries to load about:url

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-26 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 OK, I've been able to reproduce the behaviour - sort of. In my case, it wasn't that the my app showed the splashscreen, but that the app crashed while exiting! My test

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-26 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 Ah, great! Thanks for describing that. I will take a look at that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-plugin-splashscreen issue #130: CB-13094: (android) Don't show splas...

2017-07-25 Thread SharUpOff
Github user SharUpOff commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/130 I got it so: ```javascript window.addEventListener('beforeunload', function() { navigator.splashscreen.show(); }); ``` I show splash when reload

[GitHub] cordova-plugin-splashscreen pull request #130: CB-13094: (android) Don't sho...

2017-07-24 Thread SharUpOff
GitHub user SharUpOff opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/130 CB-13094: (android) Don't show splash when activity being finished ### Platforms affected - android ### What does this PR do? - Prevent to show

[GitHub] cordova-plugin-splashscreen issue #109: CB-11602: (android) Fix bug AutoHide...

2017-07-18 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/109 See the relevant [dev mailing list discussion about integrating splashscreen into the platforms](https://lists.apache.org/thread.html

[GitHub] cordova-plugin-splashscreen pull request #109: CB-11602: (android) Fix bug A...

2017-07-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/109 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-splashscreen issue #74: CB-8396 Add AutoHideSplashScreen logi...

2017-07-17 Thread daserge
Github user daserge commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/74 @alanhg can you add the reproduce steps and the details of the issue you are experiencing? How were you adding the plugin? Which cordova versions did you use? --- If your

[GitHub] cordova-plugin-splashscreen issue #74: CB-8396 Add AutoHideSplashScreen logi...

2017-07-16 Thread alanhg
Github user alanhg commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/74 @daserge I copy your commited file into plugin . ``` ``` in index.js ``` inAppBrowserRef

[GitHub] cordova-plugin-splashscreen issue #109: CB-11602: (android) Fix bug AutoHide...

2017-07-14 Thread alanhg
Github user alanhg commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/109 if AutoHideSplashScreen works for android. how to use if i want to hide splashscreen manually --- If your project is set up for it, you can reply to this email and have your

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-07-14 Thread karlachavez
Github user karlachavez commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Your suggest works fine. The splashscreen is not displayed on the device we had the problem, but on the rest of devices. We are going to take this workaround until

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-07-13 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Are there any news on this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-splashscreen issue #107: Browser platform brought closer to i...

2017-07-11 Thread petermetz
Github user petermetz commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/107 My pleasure, great to see it made it in! Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-splashscreen issue #107: Browser platform brought closer to i...

2017-07-11 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/107 Tested and merged, thanks for the contribution! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-splashscreen pull request #107: Browser platform brought clos...

2017-07-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/107 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-splashscreen pull request #129: CB-12935: (ios, android) Enab...

2017-06-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/129 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-splashscreen pull request #129: CB-12935: (ios, android) Enab...

2017-06-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/129 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do? https://issues.apache.org/jira

[GitHub] cordova-plugin-splashscreen issue #128: Fix CB-12947 (incorrect documentatio...

2017-06-23 Thread jab
Github user jab commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/128 Thanks for merging and for Cordova! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-splashscreen issue #128: Fix CB-12947 (incorrect documentatio...

2017-06-23 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/128 Thanks for the PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-splashscreen pull request #128: Fix CB-12947 (incorrect docum...

2017-06-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/128 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-splashscreen pull request #128: Fix CB-12947 (incorrect docum...

2017-06-23 Thread jab
GitHub user jab opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/128 Fix CB-12947 (incorrect documentation of iPhone 5 and 5s resolution) iPhone 5, 5s, and SE have resolution 640x1136, not 640x960 as currently documented. ### Checklist

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-06-07 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @karlachavez > we have to remove the splashscreen of our app In the meantime: cordova plugins remove cordova-plugin-splashscreen cord

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-06-07 Thread karlachavez
Github user karlachavez commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 We can reproduce this issue on a Samsung S6 with the following tech specs: http://www.samsung.com/ca/business/business-products/smartphones/smartphones/SM-G920WZWABMC

[GitHub] cordova-plugin-splashscreen issue #116: CB-12011: (android) added the possib...

2017-06-01 Thread weaponhax
Github user weaponhax commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/116 Hi guys, it apperas as though this has been tested successfully for android. Is it therefore possible to merge this preference feature to the main plugin and have it updated

[GitHub] cordova-plugin-splashscreen pull request #127: CB-12847: added `bugs` entry ...

2017-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/127 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-splashscreen issue #127: CB-12847: added `bugs` entry to pack...

2017-05-25 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/127 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-splashscreen/pull/127/commits

[GitHub] cordova-plugin-splashscreen pull request #127: CB-12847: added `bugs` entry ...

2017-05-25 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/127 CB-12847: added `bugs` entry to package.json. ### What does this PR do? Adds a bugs entry to the package.json. ### What testing has been done on this change

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-05-24 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @vegetablesalad which devices exhibited the behaviour of splash screen not showing up? Brand and model names/numbers, along with Android operating system versions running on them

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-05-24 Thread vegetablesalad
Github user vegetablesalad commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 I can attest to this bug. Splash screen didn't show up on 5 of my test phones. Applying this resolved the issue. --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-splashscreen issue #126: On Android 7 not work

2017-05-23 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/126 @filmaj I know, I've done it a few times, but I like to wait a few days because if the user closes it, we have less empty commits --- If your project is set up

[GitHub] cordova-plugin-splashscreen issue #126: On Android 7 not work

2017-05-23 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/126 FYI @jcesarmobile I usually close these kinds of fake PRs via: ``` git commit --allow-empty -m 'Close #126' ``` .. and pushing back up to master. Only way

[GitHub] cordova-plugin-splashscreen pull request #126: On Android 7 not work

2017-05-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-splashscreen/pull/126 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-splashscreen issue #126: On Android 7 not work

2017-05-22 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/126 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-splashscreen/pull/126/commits

[GitHub] cordova-plugin-splashscreen issue #126: On Android 7 not work

2017-05-22 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/126 Hi. You have created a Pull Request. Can you close it? If you want to report a bug, you can do it on issues.cordova.io --- If your project is set up

[GitHub] cordova-plugin-splashscreen pull request #126: On Android 7 not work

2017-05-22 Thread caereservices
GitHub user caereservices opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/126 On Android 7 not work On Android 7 the plugin seems to ignore tag in config.xml ... on Android <= 6 it works correctly. Cordova 7.0.2 Plugin 4.0.4-

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-05-11 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @filmaj, @infil00p unfortunately I do not have access to many Samsung devices. I was able to test this plug-in only with the models mentioned in the PR. As @SamDelgado

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-05-11 Thread SamDelgado
Github user SamDelgado commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 I have a Samung Galaxy S7 Edge that experienced an immediate crash when my app launched. This pull request fixed it. --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-splashscreen issue #107: Browser platform brought closer to i...

2017-05-06 Thread petermetz
Github user petermetz commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/107 @CelsoSantos Sorry for the late reply. Please feel free to do whatever you need/want to do to improve it and then just resubmit it as your own. I totally don't mind

[GitHub] cordova-plugin-splashscreen issue #107: Browser platform brought closer to i...

2017-05-04 Thread ranma42
Github user ranma42 commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/107 Is this PR ready for merge? Are there still issues that need to be fixed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @Lazza Which Samsung Devices would have this problem? Would a Samsung Galaxy S3 to S8 have this? --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Hmm, I cannot seem to reproduce the error with the latest master of cordova-android + cordova-plugin-splashscreen. I'm using a ~200kb .png file as a splash screen. Here's

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 I think I have a Samsung S5 that I can play with. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Yeah, but unfortunately... I am not even sure how I got that one to crash! 😅 Most of my tests in the emulators where either working or simply not showing the splash

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 O nice, there is an emulator in there. OK, I will try to reproduce. Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @filmaj I see. 😄 Just to be clear, my PR is released under the Apache Version 2.0 license as anything else in this repo (it is also the license mentioned in the project

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 One more question: how would one go about reproducing the crash that this patch fixes? What device did you see the crash on? --- If your project is set up for it, you can reply

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @Lazza nevermind, it is not completely required. Issuing a PR is enough to establish "intent to contribute" which is all Apache legal requires. --- If your project

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-27 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @filmaj I don't think I have. Why? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-24 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Ping @infil00p for a review. @Lazza have you signed an ICLA for Apache? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-04 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Great! Thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-04 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @Lazza I was just restarting the tests :) As you can see, they are green now. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-04 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 @alsorokin, sure, go ahead. :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-04 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-splashscreen/pull/125/commits

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-04 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Let there be tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-03 Thread Lazza
Github user Lazza commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 > Cordova CI Build has one or more failures This doesn't make sense. The build log states that the failure is on the Windows build. This PR **does not make

[GitHub] cordova-plugin-splashscreen issue #125: CB-12626: (android) Fix crash on Sam...

2017-04-02 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/125 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-splashscreen/pull/125/commits

[GitHub] cordova-plugin-splashscreen pull request #125: CB-12626: (android) Fix crash...

2017-04-02 Thread Lazza
GitHub user Lazza opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/125 CB-12626: (android) Fix crash on Samsung devices and splash screen not showing on some other devices ### Platforms affected Android, all versions. ### What does

[GitHub] cordova-plugin-splashscreen issue #124: CB-10893: (android) Allow setting st...

2017-03-28 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/124 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-splashscreen/pull/124/commits

[GitHub] cordova-plugin-splashscreen pull request #124: CB-10893: (android) Allow set...

2017-03-28 Thread psbarrales
Github user psbarrales commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r108424985 --- Diff: src/android/SplashScreen.java --- @@ -313,6 +315,22 @@ public void run

[GitHub] cordova-plugin-splashscreen pull request #124: CB-10893: (android) Allow set...

2017-03-19 Thread duchuyctlk
Github user duchuyctlk commented on a diff in the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/124#discussion_r106814440 --- Diff: src/android/SplashScreen.java --- @@ -313,6 +315,22 @@ public void run

[GitHub] cordova-plugin-splashscreen issue #124: CB-10893: (android) Allow setting st...

2017-03-19 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-splashscreen/pull/124 Cordova CI Build has completed successfully. **Commit** - [Link](https://github.com/apache/cordova-plugin-splashscreen/pull/124/commits

[GitHub] cordova-plugin-splashscreen pull request #124: CB-10893: (android) Allow set...

2017-03-19 Thread psbarrales
GitHub user psbarrales opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/124 CB-10893: (android) Allow setting status bar color on Android splashscreen Just like [cordova-plugin-statusBar](https://github.com/apache/cordova-plugin-statusbar), use

  1   2   3   4   5   6   7   >