Thanks Steve!
On Tue, Aug 12, 2014 at 8:48 PM, Steven Gill wrote:
> I have made changes to cordova-lib/src/plugman/prepare-browserify.js to
> support this work for cordova.js.
>
> It is now:
>
> 1) Computing commit Ids. I had to update my cordova-js branch to set cwd to
> be cordova-js repo roo
I have made changes to cordova-lib/src/plugman/prepare-browserify.js to
support this work for cordova.js.
It is now:
1) Computing commit Ids. I had to update my cordova-js branch to set cwd to
be cordova-js repo root. That way `git rev-list HEAD --max-count=1` is
always run from the right locatio
Thanks for the feedback! I have made the changes on my branch. Here is the
commit with the suggested changes.
https://github.com/stevengill/cordova-js/commit/71113eb61cfba1a354b8bdc61a72b9d73a43c287
On Tue, Aug 12, 2014 at 10:42 AM, Jesse wrote:
> so did I, good otherwise.
>
> @purplecabbage
>
so did I, good otherwise.
@purplecabbage
risingj.com
On Tue, Aug 12, 2014 at 7:58 AM, Andrew Grieve wrote:
> add some nitpick-type comments on your commit, but looks good!
>
>
> On Mon, Aug 11, 2014 at 8:45 PM, Steven Gill
> wrote:
>
> > So I have removed cordova.version and added cordova.pla
add some nitpick-type comments on your commit, but looks good!
On Mon, Aug 11, 2014 at 8:45 PM, Steven Gill wrote:
> So I have removed cordova.version and added cordova.platformVersion on the
> branch cb-7219 on my repo. Check it out at
> https://github.com/stevengill/cordova-js/tree/cb-7219. I
So I have removed cordova.version and added cordova.platformVersion on the
branch cb-7219 on my repo. Check it out at
https://github.com/stevengill/cordova-js/tree/cb-7219. It adds the output
from "git rev-list HEAD --max-count=1" at the top as a comment in
cordova.js and creates a constant named "
Thanks for the comments!
Currently, if you build cordova.js and the version is 3.5.0-dev, it will
make the build label 3.5.0-dev + output from (git rev-list HEAD
--max-count=1 --abbrev-commit).
If the version in 3.5.0(no dev), the build label is just 3.5.0 (no commit
sha hash).
I can make it so
Yes, the output cordova.js file should contain the sha hash and probably
also, the entire command-line args used to create it. So we can track back
issues.
@purplecabbage
risingj.com
On Fri, Aug 8, 2014 at 4:27 PM, Shazron wrote:
> Sounds good for #1. For traceability purposes, will the sha h
Sounds good for #1. For traceability purposes, will the sha hash be in
the .js still as a comment, etc?
```git describe```
On Thu, Aug 7, 2014 at 7:07 AM, Andrew Grieve wrote:
> That all sounds good to me Steve!
>
>
> On Wed, Aug 6, 2014 at 6:48 PM, Steven Gill wrote:
>
>> I have started to look
That all sounds good to me Steve!
On Wed, Aug 6, 2014 at 6:48 PM, Steven Gill wrote:
> I have started to look into adding cordova.platformVersion to cordova.js.
> Issue [1].
>
> Trying to figure out the best way to implement this.
>
> One potential method.
>
> 1) Pass in platformVersion to cord
I have started to look into adding cordova.platformVersion to cordova.js.
Issue [1].
Trying to figure out the best way to implement this.
One potential method.
1) Pass in platformVersion to cordova.js during build step. Make coho
handle it during release process:
First off, cordovajs doesn't get
11 matches
Mail list logo
