Re: mocking in cordova.js

2013-12-10 Thread Brian LeRoux
Cool, if you don't mind reviewing my gruntfile refactor Andrew I'll tackle this next. On Tue, Dec 10, 2013 at 1:54 PM, Andrew Grieve wrote: > I'd be fine with PhantomJS. I had to not add a unit test to urlutil that I > wanted to because jsdom didn't emulate things quite right. > > > On Mon, Dec

Re: mocking in cordova.js

2013-12-09 Thread Andrew Grieve
I'd be fine with PhantomJS. I had to not add a unit test to urlutil that I wanted to because jsdom didn't emulate things quite right. On Mon, Dec 9, 2013 at 9:14 PM, Brian LeRoux wrote: > Where would I add a mock for XMLHttpRequest? > > https://github.com/apache/cordova-js/pull/60/files > > (Al

mocking in cordova.js

2013-12-09 Thread Brian LeRoux
Where would I add a mock for XMLHttpRequest? https://github.com/apache/cordova-js/pull/60/files (Also: would you guys be cool w/ me refactoring cordova.js to use PhantomJS instead of jsdom?)