Re: cordova-lib proposal on test directory reorganization

2017-06-26 Thread Filip Maj
at 5:41 PM, Filip Maj <maj@gmail.com> wrote: > Proposal up in PR form here: https://github.com/apache/cordova-lib/pull/568 > > tl;dr consolidating `spec-cordova/` and `spec-plugman` directories > into one, setting up to for one-unit-test-spec.js per source-module.js > file.

[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...

2017-06-23 Thread imhotep
Github user imhotep commented on the issue: https://github.com/apache/cordova-lib/pull/568 I support this change. I believe it will make writing tests for new features easier if each source file has a matching spec file and all source/spec folders are mirrored. --- If your project

cordova-lib proposal on test directory reorganization

2017-06-22 Thread Filip Maj
Proposal up in PR form here: https://github.com/apache/cordova-lib/pull/568 tl;dr consolidating `spec-cordova/` and `spec-plugman` directories into one, setting up to for one-unit-test-spec.js per source-module.js file. Looking for eyes and feedback! If you have any, please drop comments

[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...

2017-06-22 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/568 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/568?src=pr=h1) Report > Merging [#568](https://codecov.io/gh/apache/cordova-lib/pull/568?src=pr=desc) into

[GitHub] cordova-lib pull request #568: Reorganized unit test directory structure + u...

2017-06-22 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-lib/pull/568 Reorganized unit test directory structure + updated npm task names ### What does this PR do? This is a proof-of-concept pull request mainly introduction file organizational changes

[GitHub] cordova-lib pull request #566: Refactor Plugin Command, test improvements, p...

2017-06-22 Thread filmaj
Github user filmaj closed the pull request at: https://github.com/apache/cordova-lib/pull/566 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-lib pull request #566: Refactor Plugin Command, test improvements, p...

2017-06-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/566#discussion_r123366796 --- Diff: src/cordova/plugin/util.js --- @@ -0,0 +1,37 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-lib pull request #566: Refactor Plugin Command, test improvements, p...

2017-06-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/566#discussion_r123359407 --- Diff: src/cordova/plugin_parser.js --- @@ -18,12 +18,14 @@ */ var xml = require('cordova-common').xmlHelpers; +var events =

[GitHub] cordova-lib pull request #566: Refactor Plugin Command, test improvements, p...

2017-06-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/566#discussion_r123357002 --- Diff: src/cordova/plugin/util.js --- @@ -0,0 +1,37 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or

[GitHub] cordova-lib issue #566: Refactor Plugin Command, test improvements, passing ...

2017-06-21 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/566 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/566?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@a7f55ec`). [Click here to learn what

[GitHub] cordova-lib pull request #566: Refactor Plugin Command, test improvements, p...

2017-06-21 Thread dpogue
Github user dpogue commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/566#discussion_r123302742 --- Diff: src/cordova/plugin/search.js --- @@ -0,0 +1,41 @@ +/** +Licensed to the Apache Software Foundation (ASF) under one +or more

[GitHub] cordova-plugin-media pull request #138: CB-12671 iOS: Fix auto-test with sto...

2017-06-20 Thread matrosov-nikita
Github user matrosov-nikita closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/138 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-media issue #138: CB-12671 iOS: Fix auto-test with stopping m...

2017-06-20 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-media/pull/138 @filmaj, thanks :) I've merged this change. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-media issue #138: CB-12671 iOS: Fix auto-test with stopping m...

2017-06-19 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/138 @matrosov-nikita with your new committership, feel free to merge this in yourself :) --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] cordova-ios pull request #319: Updating unit tests + unit test runner and ad...

2017-06-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-ios/pull/319 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-14 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-ios/pull/319 Yay, green! And looks like the codecov reporting is fixed too ;) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-14 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-ios/pull/319 # [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/319?src=pr=h1) Report > :exclamation: No coverage uploaded for pull request base (`master@8c77a0b`). [Click here to learn what

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-14 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-ios/pull/319 Made some more changes, rebased, confirmed the unit tests now run on my Windows 10 VM. Sucks to be running tests conditionally but I'm not sure what other option we have. --- If your

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-13 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-ios/pull/319 Props to @shazron for finding out there was an [integration test munging the cordova-ios repo](https://github.com/apache/cordova-ios/blob/8c77a0b991ace06b470dba9496a24e6ef75c2be3/tests/spec

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-13 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-ios/pull/319 Ah, no, wait, I can repro if I run the full `npm test` - although those files are not missing in my git tree (git status is empty). 🤔 --- If your project is set up for it, you can reply

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-13 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-ios/pull/319 Do you run a code-syncing background service like `realsync` or something? Could that be doing it? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-13 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-ios/pull/319 I'm trying `npm test` now instead of `npm run unit-tests`... maybe the e2e tests are making changes to the git tree? --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-13 Thread filmaj
clone. Worth noting that after cloning and `npm install`ing, a bunch of files were changed under node_modules, according to `git`. At what point in the process does your repo miss the files? After cloning? Or after `npm install`ing? OR maybe during the test run somehow

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-13 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/319 Same error. Did: ``` $ git checkout -- . $ npm test ``` and it shows the same two deleted files. --- If your project is set up for it, you can reply to this email

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-13 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-ios/pull/319 Hmm, the diff just shows that those files were moved? If you `git checkout -- .` from the repo source, and rerun, do you get the same behaviour? --- If your project is set up for it,

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-13 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-ios/pull/319 Uh oh 😟 interesting, I don't see that in my local setup. I must have messed the history up, thanks for checking. I'll try with a fresh clone myself and see if I can repro. --- If

[GitHub] cordova-ios issue #319: Updating unit tests + unit test runner and adding pl...

2017-06-13 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/319 I cloned your fork and checked out the feature branch with all your commits. Then: ``` $ npm install --dev $ npm test ... > cordova-ios@4.5.0-dev unit-tests /Users/shaz

[GitHub] cordova-ios pull request #319: Updating unit tests + unit test runner and ad...

2017-06-13 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-ios/pull/319 Updating unit tests + unit test runner and adding platformAPI addPlugin unit tests # Summary of Changes - moved `jasmine.json` to `tests/spec`, next to all the unit tests. eliminates

[GitHub] cordova-plugin-test-framework pull request #25: CB-12847: added `bugs` entry...

2017-06-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/25 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-media issue #138: CB-12671 iOS: Fix auto-test with stopping m...

2017-06-03 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-plugin-media/pull/138 @alsorokin, could you please take a look at this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-plugin-test-framework pull request #25: CB-12847: added `bugs` entry...

2017-05-25 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/25 CB-12847: added `bugs` entry to package.json. ### What does this PR do? Adds a bugs entry to the package.json. ### What testing has been done on this change

[GitHub] cordova-plugin-battery-status pull request #53: CI Rerun test

2017-05-25 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-battery-status/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-battery-status issue #53: CI Rerun test

2017-05-25 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/53 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-battery-status issue #53: CI Rerun test

2017-05-25 Thread jcesarmobile
Github user jcesarmobile commented on the issue: https://github.com/apache/cordova-plugin-battery-status/pull/53 cordova-qa run tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-battery-status pull request #53: CI Rerun test

2017-05-25 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-battery-status/pull/53 CI Rerun test ### Platforms affected ### What does this PR do? ### What testing has been done on this change

[GitHub] cordova-plugin-test-framework issue #24: Add important build step about pack...

2017-05-23 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/24 Ooo, also, could this PR be issued against the master branch? Next time we do a patch release, we will ensure to pull this commit from master into the release branch anyways

[GitHub] cordova-plugin-test-framework pull request #24: Add important build step abo...

2017-05-23 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-test-framework/pull/24#discussion_r118083583 --- Diff: README.md --- @@ -63,6 +64,8 @@ For example, the `cordova-plugin-device` plugin has this nested [`plugin.xml`](h

[GitHub] cordova-plugin-test-framework pull request #24: Add important build step abo...

2017-05-22 Thread davidschreiber
GitHub user davidschreiber opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/24 Add important build step about packages.json This step is necessary or tests won't build. The original issue that fixed this issue in all Cordova projects is was only

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-05-11 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-test-platform/pull/1 Doc requirements for platform api expectations Not ready for review yet! Thanks! :) ### Platforms affected ### What does this PR do? Document

[GitHub] cordova-js pull request #142: CB-12748 - Update CI to test node 4 and 6

2017-05-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/142 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-js pull request #142: CB-12748 - Update CI to test node 4 and 6

2017-05-01 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-js/pull/142 CB-12748 - Update CI to test node 4 and 6 ### What does this PR do? Updates AppVeyor and Travis CI tests to use node 4 and 6. ### What testing has been done on this change

[GitHub] cordova-plugin-camera pull request #260: CB-12650: Fix manual test for uploa...

2017-04-25 Thread matrosov-nikita
Github user matrosov-nikita closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/260 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so,

[GitHub] cordova-plugin-camera issue #260: CB-12650: Fix manual test for uploading im...

2017-04-25 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/260 Merged this in. For some reason, the PR did not automatically close. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] cordova-plugin-media issue #138: CB-12671 iOS: Fix auto-test with stopping m...

2017-04-24 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-media/pull/138 This good to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-camera issue #260: CB-12650: Fix manual test for uploading im...

2017-04-24 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/260 Good to merge this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-media issue #138: CB-12671 iOS: Fix auto-test with stopping m...

2017-04-19 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/138 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media issue #138: CB-12671 iOS: Fix auto-test with stopping m...

2017-04-19 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/138 Cordova CI Build has one or more failures. **Commit** - [Link](https://github.com/apache/cordova-plugin-media/pull/138/commits/ec8bfb6c24deb4305d6fa89d70b266e5bcfd7588)

[GitHub] cordova-plugin-media issue #138: CB-12671 iOS: Fix auto-test with stopping m...

2017-04-19 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-media/pull/138 Cordova CI Build has completed successfully. **Commit** -

[GitHub] cordova-plugin-media pull request #138: Fix auto-test with stopping media th...

2017-04-19 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-plugin-media/pull/138 Fix auto-test with stopping media that is in starting state ### Platforms affected iOS ### What does this PR do? Fix auto-test, the error can

[GitHub] cordova-plugin-camera issue #260: CB-12650: Fix manual test for uploading im...

2017-04-12 Thread cordova-qa
/8003ab283c04af0e939340e069e795fb8609192f) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/155/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova

[GitHub] cordova-plugin-camera issue #260: CB-12650: Fix manual test for uploading im...

2017-04-12 Thread cordova-qa
/042cfba6a61c27217931bfe9a517d866ead210bc) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/154/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova

[GitHub] cordova-plugin-test-framework pull request #23: Fixing a few markdown render...

2017-04-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/23 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework issue #23: Fixing a few markdown rendering ite...

2017-04-12 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/23 Thanks for the pull request! Merged in. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-camera pull request #260: Fix manual test for uploading image

2017-04-12 Thread matrosov-nikita
GitHub user matrosov-nikita opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/260 Fix manual test for uploading image ### Platforms affected Android ### What does this PR do? This PR corrects dependency in `tests/plugin.xml

[GitHub] cordova-plugin-test-framework pull request #23: Fixing a few markdown render...

2017-04-11 Thread robrohan
GitHub user robrohan opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/23 Fixing a few markdown rendering items A few headings didn't have white space above them (due to the anchor tags). Just added the white space so the file renders correctly

[GitHub] cordova-docs pull request #636: Update the plugman test for android

2017-03-23 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-docs/pull/636 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios pull request #290: test

2017-02-24 Thread iPhuan
Github user iPhuan closed the pull request at: https://github.com/apache/cordova-ios/pull/290 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-ios issue #290: test

2017-02-23 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/290 @iPhuan please close this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-contacts pull request #150: Intentionally fail one test to ch...

2017-02-23 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-contacts/pull/150 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-contacts issue #150: Intentionally fail one test to check CI

2017-02-23 Thread cordova-qa
/68d94e6783eb67a748a3780046966ca7a8d14bb8) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-contacts-pr/81/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova

[GitHub] cordova-plugin-contacts pull request #150: Intentionally fail one test to ch...

2017-02-23 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-contacts/pull/150 Intentionally fail one test to check CI Don't merge me You can merge this pull request into a Git repository by running: $ git pull https://github.com/alsorokin/cordova

Update on Android Unit Test Re-Write

2017-02-22 Thread Joe Bowser
Hey So, this would have happened sooner, but I have the new format with most of the tests migrated. Due to permission issues, I deleted the Cordova Resource API integration test, but if someone wants to figure out how to get that working, feel free. https://github.com/apache/cordova-android

[GitHub] cordova-plugin-file-transfer issue #176: CB-12439 (Tests) Re-enable the test...

2017-02-22 Thread cordova-qa
-file-transfer-pr/68/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/68//PLATFORM=windows-10-store

[GitHub] cordova-plugin-file-transfer issue #176: CB-12439 (Tests) Re-enable the test...

2017-02-21 Thread cordova-qa
-file-transfer-pr/67/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-file-transfer-pr/67//PLATFORM=windows-10-store

[GitHub] cordova-ios pull request #290: test

2017-02-18 Thread iPhuan
GitHub user iPhuan opened a pull request: https://github.com/apache/cordova-ios/pull/290 test ### Platforms affected ### What does this PR do? ### What testing has been done on this change? ### Checklist - [ ] [Reported

Cordova Android Test Re-Write

2017-02-15 Thread Joe Bowser
2. Once these are done, I will be expecting any non-trivial change to Cordova-Android to have a corresponding Instrumentation Test involving both HTML/CSS/JS and jUnit tests. If I see a PR without a jUnit test, added to the new test project, it will not be accepted. 3. Once this is done, I do plan

[GitHub] cordova-plugin-camera pull request #244: Android Appium test tweaks

2017-01-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/244 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera issue #244: Android Appium test tweaks

2017-01-03 Thread cordova-qa
/05594c46468576da846b31b03e624d72f7c9c476) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/115/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 10 Store]( http://cordova

[GitHub] cordova-plugin-camera issue #244: Android Appium test tweaks

2017-01-03 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/244 Rebased and squashed commit and updated message to have the same format as you pointed out @alsorokin. Thanks for the review! I'll merge upon tests passing. --- If your project is

[GitHub] cordova-plugin-camera issue #244: Android Appium test tweaks

2017-01-03 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/244 Filed [CB-12312](https://issues.apache.org/jira/browse/CB-12312) for this one. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-plugin-camera pull request #244: Android Appium test tweaks

2016-12-26 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/244#discussion_r93867563 --- Diff: appium-tests/android/android.spec.js --- @@ -373,7 +384,6 @@ describe('Camera tests Android.', function () {

[GitHub] cordova-plugin-camera issue #244: Android Appium test tweaks

2016-12-26 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/244 Nit: it would be nice if first two checklist items would be fulfilled. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] cordova-plugin-camera issue #244: Android Appium test tweaks

2016-12-25 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/244 LGTM 👍 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-camera pull request #244: Android Appium test tweaks

2016-12-25 Thread alsorokin
ormVersion "5.1" --target api22 --- End diff -- I still think that the user should know better which emulator he wants to use in the test run. For example, one of the emulator may not have camera enabled. I doubt that Appium would know that when selecting "best" e

[GitHub] cordova-plugin-camera issue #244: Android Appium test tweaks

2016-12-23 Thread cordova-qa
/4e26e2a04ae256e4305419a9d469771dd4e0f8c8) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/113/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova

[GitHub] cordova-plugin-camera issue #244: Android Appium test tweaks

2016-12-23 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/244 @alsorokin thanks for the feedback, I've addressed your points. Let me know if you have any other concerns or if you are good with merging it. --- If your project is set up for it,

[GitHub] cordova-plugin-camera pull request #244: Android Appium test tweaks

2016-12-23 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/244#discussion_r93798887 --- Diff: appium-tests/android/android.spec.js --- @@ -373,7 +384,6 @@ describe('Camera tests Android.', function () {

[GitHub] cordova-plugin-camera pull request #244: Android Appium test tweaks

2016-12-23 Thread filmaj
`, `platformVersion` and `deviceName` capabilities you provide. These capabilities apply regardless if you are running the test locally or on Sauce Labs. I think, moving forward, for a paramedic refactor I am gathering use cases for / noting issues to address, we would want to expose

[GitHub] cordova-plugin-camera pull request #244: Android Appium test tweaks

2016-12-23 Thread alsorokin
Github user alsorokin commented on a diff in the pull request: https://github.com/apache/cordova-plugin-camera/pull/244#discussion_r93737605 --- Diff: appium-tests/android/android.spec.js --- @@ -373,7 +384,6 @@ describe('Camera tests Android.', function () {

[GitHub] cordova-plugin-camera pull request #244: Android Appium test tweaks

2016-12-23 Thread alsorokin
ormVersion "5.1" --target api22 --- End diff -- I think `--saucePlatformVersion` is meant to be used together with `--shouldUseSauce` For a local test run, I think it makes sense to use `--target` arg, which specifies the emulator name to run on. --- If your project i

[GitHub] cordova-plugin-camera issue #244: Android Appium test tweaks

2016-12-22 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-camera/pull/244 Oh! I totally forgot to ping @alsorokin for a review :) If you find the time, please review good sir! --- If your project is set up for it, you can reply to this email and

[GitHub] cordova-plugin-screen-orientation issue #7: test Jenkins PR job

2016-12-21 Thread cordova-qa
/ba26294f664e637dd5f730ff3a4b2cd16e111ec4) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-screen-orientation-pr/2/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store

[GitHub] cordova-plugin-screen-orientation pull request #7: test Jenkins PR job

2016-12-21 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-screen-orientation/pull/7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-screen-orientation pull request #7: test Jenkins PR job

2016-12-21 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-screen-orientation/pull/7 test Jenkins PR job do not merge You can merge this pull request into a Git repository by running: $ git pull https://github.com/alsorokin/cordova-plugin-screen

[GitHub] cordova-plugin-camera issue #244: Android Appium test tweaks

2016-12-16 Thread cordova-qa
/f4616d88cd1b87433f0f8b98a1d228253be461aa) **Dashboard** - [Link](http://cordova-ci.cloudapp.net:8080/job/cordova-plugin-camera-pr/110/) | Builder Name | Console Output | Test Report | Device Logs | | :---: | :---: | :---: | :---:| | [Windows 8.1 Store]( http://cordova

[GitHub] cordova-plugin-camera pull request #244: Android Appium test tweaks

2016-12-16 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/244 Android Appium test tweaks ### Platforms affected Android ### What does this PR do? - updated comments on how to run the tests. - extra

[GitHub] cordova-android pull request #348: Do not test for non-existent build folder

2016-11-03 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/348 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request #348: Do not test for non-existent build folder

2016-11-03 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-android/pull/348 Do not test for non-existent build folder ### Platforms affected ### What does this PR do? ### What testing has been done on this change

[GitHub] cordova-plugin-file-transfer pull request #163: CB-12100 (ios) Fixed test pl...

2016-11-02 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/163 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer issue #163: CB-12100 (ios) Fixed test plugin in...

2016-11-02 Thread vladimir-kotikov
Github user vladimir-kotikov commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/163 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-file-transfer issue #163: CB-12100 (ios) Fixed test plugin in...

2016-11-01 Thread cordova-qa
Github user cordova-qa commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/163 Can one of the admins verify this patch? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-file-transfer pull request #163: CB-12100 (ios) Fixed test pl...

2016-11-01 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/163 CB-12100 (ios) Fixed test plugin install at platform add on cordova@6… ### Platforms affected iOS ### What does this PR do? Fixes the problem described

[GitHub] cordova-windows pull request #201: CB-11993 - windows platform doesn't test ...

2016-10-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-windows/pull/201 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-windows issue #201: CB-11993 - windows platform doesn't test all nod...

2016-10-15 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-windows/pull/201 ## [Current coverage](https://codecov.io/gh/apache/cordova-windows/pull/201?src=pr) is 74.34% (diff: 100%) > Merging

[GitHub] cordova-windows issue #201: CB-11993 - windows platform doesn't test all nod...

2016-10-15 Thread shazron
Github user shazron commented on the issue: https://github.com/apache/cordova-windows/pull/201 Failing on Travis 0.12, 4, and 6 (but works on 0.10). Env vars expected are null because Travis is on Linux and not on Windows. e.g

[GitHub] cordova-windows pull request #201: CB-11993 - windows platform doesn't test ...

2016-10-15 Thread shazron
GitHub user shazron opened a pull request: https://github.com/apache/cordova-windows/pull/201 CB-11993 - windows platform doesn't test all node versions on appveyor and travis ### Platforms affected Self. ### What does this PR do? Makes appveyor

[GitHub] cordova-lib issue #491: CB-11776 Add test case for different edit-config tar...

2016-10-06 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/491 Thanks @ktop! Merged! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-lib pull request #491: CB-11776 Add test case for different edit-con...

2016-10-06 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/491 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-docs issue #636: Update the plugman test for android

2016-10-05 Thread stevengill
`cordova plugin add` to test plugins. Appreciate you spending time to send a PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled

[GitHub] cordova-plugin-test-framework pull request #21: CB-11917 - Remove pull reque...

2016-10-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/21 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

<    1   2   3   4   5   6   7   8   >