[GitHub] cordova-plugin-splashscreen pull request #129: CB-12935: (ios, android) Enab...

2017-06-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/129 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do?

[GitHub] cordova-plugin-network-information pull request #56: CB-12935: (ios, android...

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-network-information/pull/56 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-network-information pull request #56: CB-12935: (ios, android...

2017-06-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-network-information/pull/56 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do?

[GitHub] cordova-plugin-media-capture pull request #80: CB-12935: (ios, android) Enab...

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media-capture/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Nightly build #411 for cordova has failed

2017-06-26 Thread Apache Jenkins Server
Nightly build #411 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/411/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/411/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-cli pull request #255: CLI Refactor

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/255 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-cli pull request #281: CB-12895 : updated to use eslint instead of j...

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-cli/pull/281 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

2017-06-26 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/32#discussion_r124158440 --- Diff: bin/template/www/cordova-sw.js --- @@ -0,0 +1,23 @@ + +// Note, these will be updated automatically at build time +var

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

2017-06-26 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/32#discussion_r124158393 --- Diff: bin/template/cordova/Api.js --- @@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

2017-06-26 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/32#discussion_r124158333 --- Diff: bin/template/cordova/Api.js --- @@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {

[GitHub] cordova-browser pull request #36: CB-12804 Fixes some simple details - manif...

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-browser/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-browser pull request #36: CB-12804 Fixes some simple details - manif...

2017-06-26 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-browser/pull/36 CB-12804 Fixes some simple details - manifest.json ### Platforms affected browser ### What does this PR do? addresses issues raised with pr #32 ### What

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

2017-06-26 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/32#discussion_r124157183 --- Diff: cordova-js-src/confighelper.js --- @@ -61,14 +61,9 @@ function readConfig(success, error) { } }; -

[GitHub] cordova-browser pull request #32: CB-12804 : support manifest.json

2017-06-26 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-browser/pull/32#discussion_r124157156 --- Diff: bin/template/cordova/Api.js --- @@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {

Fwd: Regarding Issue for Video Upload

2017-06-26 Thread Darshan Sonavane
Hi , I am using Ionic framework for developing an application with cordova. I have to create application for android as well as ios platform. In Android i am able to select a video from gallery as well as i have converted the selected video to base64 string but i am unable to do with ios. I

[GitHub] cordova-lib pull request #570: CB-12361 : updated cordova-lib addHelper.spec...

2017-06-26 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/570 CB-12361 : updated cordova-lib addHelper.spec tests Not ready to be merged/reviewed yet! Thank you! ### Platforms affected ### What does this PR do?

[GitHub] cordova-lib pull request #569: CB-12361: added main function unit tests for ...

2017-06-26 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-lib/pull/569 CB-12361: added main function unit tests for plugin add.spec.js work in progress. Please don't merge You can merge this pull request into a Git repository by running: $ git pull

[GitHub] cordova-browser pull request #35: CB-11181 add default favicon

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-browser/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-browser pull request #35: CB-11181 add default favicon

2017-06-26 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/cordova-browser/pull/35 CB-11181 add default favicon ### Platforms affected Browser ### What does this PR do? adds default favicon, that 'should' be overwritten by apps targeting

[GitHub] cordova-android pull request #388: CB-9971: Suppressed unwanted java stderr ...

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request #390: CB-12954 remove jshint leftovers

2017-06-26 Thread filmaj
Github user filmaj closed the pull request at: https://github.com/apache/cordova-android/pull/390 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android issue #390: CB-12954 remove jshint leftovers

2017-06-26 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/390 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/390?src=pr=h1) Report > Merging [#390](https://codecov.io/gh/apache/cordova-android/pull/390?src=pr=desc) into

[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup

2017-06-26 Thread infil00p
Github user infil00p commented on a diff in the pull request: https://github.com/apache/cordova-android/pull/384#discussion_r124071629 --- Diff: bin/lib/create.js --- @@ -259,41 +273,53 @@ exports.create = function(project_path, config, options, events) {

[GitHub] cordova-android pull request #390: CB-12954 remove jshint leftovers

2017-06-26 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-android/pull/390 CB-12954 remove jshint leftovers There were some jshint rc and ignore files leftover. With the switch to eslint, we can get rid of it You can merge this pull request into a Git repository

[GitHub] cordova-android issue #384: CB-11244: Studio project cleanup

2017-06-26 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/384 We're going to keep working on #389, closing this old branch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-android pull request #384: CB-11244: Studio project cleanup

2017-06-26 Thread infil00p
Github user infil00p closed the pull request at: https://github.com/apache/cordova-android/pull/384 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android pull request #389: CB-11244: Studio Project Compatibility: N...

2017-06-26 Thread infil00p
GitHub user infil00p opened a pull request: https://github.com/apache/cordova-android/pull/389 CB-11244: Studio Project Compatibility: Now with merge commit ### Platforms affected Android ### What does this PR do? This PR is the new current working PR for

[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...

2017-06-26 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/568 Thanks for the feedback @stevengill, good point. I've just removed `npm run ci` and updated travis and appveyor to just run `npm test` - just like a developer would on their local machine. ---

[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...

2017-06-26 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/568 looks good to me. Only thing I would add is updating travis and appveyor as well. They run the integration tests as a separate task currently. --- If your project is set up for it, you can

[GitHub] cordova-cli issue #281: CB-12895 : updated to use eslint instead of jshint

2017-06-26 Thread audreyso
Github user audreyso commented on the issue: https://github.com/apache/cordova-cli/pull/281 Refactored! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

Re: cordova-lib proposal on test directory reorganization

2017-06-26 Thread Filip Maj
Still looking for a bit more feedback, please take a look if you have time! Thanks Anis for your feedback :) Don't worry about the diff / changeset (~1900 files changed!), the PR description, I think, summarizes the changes well enough. Almost all the changes are renaming files and tweaking the

[GitHub] cordova-android issue #388: CB-9971: Suppressed unwanted java stderr output ...

2017-06-26 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/388 LGTM! ![images](https://user-images.githubusercontent.com/52645/27539560-9ceda950-5a42-11e7-89d0-df90cc8a5684.jpg) --- If your project is set up for it, you can reply to this

[GitHub] cordova-plugin-media-capture pull request #80: CB-12935: (ios, android) Enab...

2017-06-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-media-capture/pull/80 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do?

[GitHub] cordova-plugin-media pull request #144: CB-12935: (ios, android) Enable para...

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-media/pull/144 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-media pull request #144: CB-12935: (ios, android) Enable para...

2017-06-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-media/pull/144 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do?

[GitHub] cordova-plugin-inappbrowser pull request #224: CB-12935: (ios, android) Enab...

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/224 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request #224: CB-12935: (ios, android) Enab...

2017-06-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/224 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do?

[GitHub] cordova-plugin-globalization pull request #58: CB-12935: (ios, android) Enab...

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-globalization/pull/58 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-android issue #388: CB-9971: Suppressed unwanted java stderr output ...

2017-06-26 Thread matrosov-nikita
Github user matrosov-nikita commented on the issue: https://github.com/apache/cordova-android/pull/388 @filmaj, is it good to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] cordova-plugin-globalization pull request #58: CB-12935: (ios, android) Enab...

2017-06-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-globalization/pull/58 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do?

[GitHub] cordova-plugin-geolocation pull request #90: CB-12935: (ios, android) Enable...

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-geolocation/pull/90 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-geolocation pull request #90: CB-12935: (ios, android) Enable...

2017-06-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-geolocation/pull/90 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do?

[GitHub] cordova-plugin-file-transfer pull request #181: CB-12935: (ios, android) Ena...

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file-transfer/pull/181 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-file-transfer pull request #181: CB-12935: (ios, android) Ena...

2017-06-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/181 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do?

[GitHub] cordova-plugin-file pull request #209: CB-12935: (ios, android) Enable param...

2017-06-26 Thread alsorokin
Github user alsorokin closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/209 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-plugin-file pull request #209: CB-12935: (ios, android) Enable param...

2017-06-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-file/pull/209 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do?

[GitHub] cordova-plugin-dialogs pull request #94: CB-12935: (ios, android) Enable par...

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/94 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-dialogs pull request #94: CB-12935: (ios, android) Enable par...

2017-06-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-dialogs/pull/94 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do?

[GitHub] cordova-plugin-device-orientation pull request #37: CB-12935: (ios, android)...

2017-06-26 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-device-orientation/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] cordova-plugin-device-orientation pull request #37: CB-12935: (ios, android)...

2017-06-26 Thread alsorokin
GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-device-orientation/pull/37 CB-12935: (ios, android) Enable paramedic builds on Travis CI ### Platforms affected iOS, Android ### What does this PR do?