[GitHub] cordova-plugin-dialogs pull request #69: Added options to customize keyboard...

Github user chemerisuk closed the pull request at: https://github.com/apache/cordova-plugin-dialogs/pull/69 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

Nightly build #425 for cordova has succeeded!

Nightly build #425 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/425/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-ios issue #324: CB-12966: (ios) Fix bug by escaping project name in ...

Github user shazron commented on the issue: https://github.com/apache/cordova-ios/pull/324 Not passing the linter: ``` bin\templates\scripts\cordova\lib\Podfile.js: line 93, col 51, Mixed double and single quotes. bin\templates\scripts\cordova\lib\Podfile.js: line 93, col

[GitHub] cordova-docs pull request #713: CB-12980: (iOS) Improve instruction and add ...

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-docs/pull/713#discussion_r126568456 --- Diff: www/docs/en/dev/guide/platforms/ios/webview.md --- @@ -220,5 +222,16 @@ After using either of these two methods, continue with the **"Using

[GitHub] cordova-android issue #389: CB-11244: Studio Project Compatibility: Now with...

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/389 Heh, with me merging in #391, you might need to rebase 🙈 At least you'll get wider test feedback on Windows with it. --- If your project is set up for it, you can reply to this

Re: Proof-of-Concept: Studio Project Structure Cleanup

Hey After the eslint merge, I redid the PR, so here's the new branch for the StudioProjectCleanup. Can more people look at it, I'll be working on some refactors on here, but AFAIK, there's no good reason to not merge this into master and get ready to start ramping up Cordova-Android 7.0.0

Re: Cordova-Android 7.0.0 Review request

BUMP! Let's see if we can get some traction behind these: Here's the latest StudioProjectCompat PR: https://github.com/apache/cordova-android/pull/389 On Thu, Jun 22, 2017 at 10:57 AM, Joe Bowser wrote: > BTW: I also want to pull this in: > >

[GitHub] cordova-plugin-file-transfer issue #141: CB-10974 Cordova file transfer Cont...

Github user cozzbie commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/141 Issue seems to be mostly an android problem because same code works fine on iOS. Using @cooperjbrandon advice and adding `options.chunkedMode = false;` to just the android code

[GitHub] cordova-mobile-spec pull request #145: CB-10718: Update instruction

Github user halton commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/145#discussion_r126541593 --- Diff: createmobilespec/createmobilespec.js --- @@ -345,16 +345,13 @@ if (argv.global) { console.log("To clone repositories:");

[GitHub] cordova-mobile-spec pull request #145: CB-10718: Update instruction

Github user shazron commented on a diff in the pull request: https://github.com/apache/cordova-mobile-spec/pull/145#discussion_r126538962 --- Diff: createmobilespec/createmobilespec.js --- @@ -345,16 +345,13 @@ if (argv.global) { console.log("To clone

[GitHub] cordova-plugin-inappbrowser issue #89: CB-3750: Add loading spinner for ios

Github user shazron commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/89 Please file feature request issues for the needed features at issues.cordova.io Thanks! --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-android issue #362: CB-12453: Remove unnecessary double quotes from ...

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/362 I've merged in the e2e testing changes on Appveyor (Windows) into master, so a rebase should trigger running these changes in a Windows environment via our CI. --- If your project is set

[GitHub] cordova-android issue #392: WIP: Run native android unit tests in CI

Github user codecov-io commented on the issue: https://github.com/apache/cordova-android/pull/392 # [Codecov](https://codecov.io/gh/apache/cordova-android/pull/392?src=pr=h1) Report > Merging [#392](https://codecov.io/gh/apache/cordova-android/pull/392?src=pr=desc) into

[GitHub] cordova-android pull request #391: CB-12950: E2E test tweaks + Appveyor now ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/391 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/391 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-android issue #362: CB-12453: Remove unnecessary double quotes from ...

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/362 @matrosov-nikita can you rebase with latest master in here? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-android issue #362: CB-12453: Remove unnecessary double quotes from ...

Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/362 Yep, will take a look. I would feel better about merging in #391 first, as that would run the end to end tests on appveyor (windows-based CI), which would validate some of this

[GitHub] cordova-plugin-camera pull request #279: CB-13002: (Android, iOS) Fix occasi...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/279 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request #279: CB-13002: (Android, iOS) Fix occasi...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/279 CB-13002: (Android, iOS) Fix occasional Appium tests failures ### Platforms affected Android, iOS ### What does this PR do? Fixes a problem in Appium tests which

[GitHub] cordova-plugin-statusbar issue #82: README: Fix issue tracker link

Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/82 Good catch at the individual issue being linked - not intended. As long as the PULL_REQUEST_TEMPLATE.md doesn't really work for README changes (doesn't effect any platform,

[GitHub] cordova-plugin-camera pull request #278: CB-13000: (CI) Speed up android bui...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/278 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-plugin-camera pull request #278: CB-13000: (CI) Speed up android bui...

GitHub user alsorokin opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/278 CB-13000: (CI) Speed up android builds ### Platforms affected Android ### What does this PR do? https://issues.apache.org/jira/browse/CB-13000 Speed up testing