Nightly build #445 for cordova has failed

2017-08-01 Thread Apache Jenkins Server
Nightly build #445 for cordova has failed. Please check failure details on build details page at https://builds.apache.org/job/cordova-nightly/445/ You can also take a look at build console: https://builds.apache.org/job/cordova-nightly/445/consoleFull - Jenkins for Apache Cordova

[GitHub] cordova-lib pull request #588: CB-13056 : Removed parsers & platformApi poly...

2017-08-01 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/588 CB-13056 : Removed parsers & platformApi polyfill for webos, blackberry, & ubuntu ### Platforms affected ### What does this PR do? Removed parsers &

[GitHub] cordova-lib pull request #587: CB-13056 : added deprecation notice for webos

2017-08-01 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/587 CB-13056 : added deprecation notice for webos ### Platforms affected ### What does this PR do? Added deprecation notice for webos ### What testing has

[GitHub] cordova-lib issue #586: CB-13057 : Remove cordova platform save command

2017-08-01 Thread audreyso
Github user audreyso commented on the issue: https://github.com/apache/cordova-lib/pull/586 Can I delete: 1. commented out tests or parts of tests that contain platforms.json or platform_metadata? 2. Can I delete save.js and save.spec.js? --- If your project is set up for

[GitHub] cordova-lib pull request #586: CB-13057 : Remove cordova platform save comma...

2017-08-01 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/586 CB-13057 : Remove cordova platform save command ### Platforms affected ### What does this PR do? Remove cordova platform save command ### What testing

[GitHub] cordova-lib pull request #585: CB-13057 : added deprecation warning for cord...

2017-08-01 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/585 CB-13057 : added deprecation warning for cordova platform save ### Platforms affected ### What does this PR do? Added deprecation warning for cordova platform

[GitHub] cordova-plugin-inappbrowser issue #234: CB-12975: (docs) Resort and reword c...

2017-08-01 Thread janpio
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/234 Did I miss anything or were there further, later changes that required another rebase? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-inappbrowser pull request #225: CB-12975: (docs) Resort and r...

2017-08-01 Thread janpio
Github user janpio closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser pull request #234: CB-12975: (docs) Resort and r...

2017-08-01 Thread janpio
Github user janpio closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/234 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-08-01 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 @janpio I have merged in your changes to master, see 7611645469aa4f9a4b0ebeb826317030cc2900a2. Can you close this pull request? --- If your project is set up for it,

[GitHub] cordova-plugin-inappbrowser issue #234: CB-12975: (docs) Resort and reword c...

2017-08-01 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/234 OK I had to rebase your patch one more time - it is merged in in 7611645469aa4f9a4b0ebeb826317030cc2900a2. @janpio can you close this pull request now? --- If your

[GitHub] cordova-plugin-test-framework pull request #26: CB-12895 : replaced jshint w...

2017-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] cordova-plugin-test-framework issue #26: CB-12895 : replaced jshint with esl...

2017-08-01 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/26 Yep! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] cordova-plugin-test-framework issue #26: CB-12895 : replaced jshint with esl...

2017-08-01 Thread audreyso
Github user audreyso commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/26 Thanks for the review! Okay to merge @filmaj? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-08-01 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Sounds good, I'll check that out. Thanks for taking that on! > because now "This branch is 3 commits ahead of apache:master. " ☝️ that's what you want! ---

[GitHub] cordova-plugin-test-framework pull request #26: CB-12895 : replaced jshint w...

2017-08-01 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/26 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing

[GitHub] cordova-plugin-file pull request #213: Add mandatory iOS 10 privacy descript...

2017-08-01 Thread shishlina
GitHub user shishlina opened a pull request: https://github.com/apache/cordova-plugin-file/pull/213 Add mandatory iOS 10 privacy description ### Platforms affected iOS ### What does this PR do? Ensures the plugin enables users to select photos from the

[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-08-01 Thread janpio
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Yeah no, I have no idea what actually happened and why and how I could undo it :/ So if you @filmaj are ok with it, let's just go with #234. --- If your project is set up

[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-08-01 Thread janpio
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 As a first "recovery" I branched after my now rewritten commit into patch-1b and created a pull request from there at #234. This seems to have worked and almost looked as it

[GitHub] cordova-plugin-inappbrowser pull request #234: [WIP] CB-12975: (docs) Resort...

2017-08-01 Thread janpio
GitHub user janpio opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/234 [WIP] CB-12975: (docs) Resort and reword cordova.InAppBrowser.open `options` lists This is a followup to #225 to test if I got it working. Do not merge yet please.

[GitHub] cordova-plugin-inappbrowser issue #225: CB-12975: (docs) Resort and reword c...

2017-08-01 Thread janpio
Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/225 Thanks for the proper explanation! I almost understood it and went to work with Sourcetree... https://www.atlassian.com/blog/sourcetree/interactive-rebase-sourcetree

[GitHub] cordova-plugin-file pull request #212: CB-13028 (CI) Browser builds on Travi...

2017-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-file/pull/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the