Nightly build #492 for cordova has succeeded!

Nightly build #492 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/492/consoleFull - Jenkins for Apache Cordova

Re: [Vote] 4.5.1 iOS Release

I vote +1: * created a hello-world app and deployed to emulator/device * attempted to add cordova-plugin-console to the app and it correctly was rejected * Ran coho audit-license-headers over the relevant repos * Ran coho check-license to ensure all dependencies and subdependencies have

[Vote] 4.5.1 iOS Release

Please review and vote on this 4.5.1 iOS Release by replying to this email (and keep discussion on the DISCUSS thread) Release issue: https://issues.apache.org/jira/browse/CB-13310 The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/CB-13310 The package

[GitHub] cordova-lib pull request #594: CB-13288 : updated index.js and test to fix c...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/594 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-osx pull request #41: CB-13304: forward non file:// URLs to system

Github user albertolalama closed the pull request at: https://github.com/apache/cordova-osx/pull/41 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-osx issue #41: CB-13304: forward non file:// URLs to system

Github user albertolalama commented on the issue: https://github.com/apache/cordova-osx/pull/41 @tripodsan I tried using `allow-navigation` and `allow-intent` as per your suggestion. Unfortunately, I was not able to get it to open URLs externally. I have submitted #42 for

[GitHub] cordova-osx pull request #42: CB-13304: expose preference to control WebView...

GitHub user albertolalama opened a pull request: https://github.com/apache/cordova-osx/pull/42 CB-13304: expose preference to control WebView navigation ### Platforms affected OSX ### What does this PR do? Exposes a preference in config.xml,

[GitHub] cordova-plugin-inappbrowser issue #219: [CB-9148] (android) add setType() me...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/219 Agree with @jcesarmobile, this should have a new JIRA associated with this issue. --- - To unsubscribe,

[GitHub] cordova-plugin-inappbrowser pull request #201: (Android) Implement Download ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/201 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-plugin-inappbrowser issue #221: CB-12834: (android) Fix bug when ope...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/221 CRAP, this was a typo. @RafaelKr can you re-open this one? I meant to close #201 --- - To unsubscribe,

[GitHub] cordova-plugin-inappbrowser pull request #221: CB-12834: (android) Fix bug w...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/221 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

Github user DavidRyu123 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/85 With a combination of wkwebview and "viewport-fit=cover", the white area issue has gone. It made some pages bounce, so I should remove 'position: absolute' in my css. Thanks for

[GitHub] cordova-plugin-inappbrowser issue #185: iOS friendlier UI

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/185 Can you create JIRA issue to correspond to this PR? That's one of the things that is holding up this PR. ---

[GitHub] cordova-plugin-inappbrowser pull request #172: [CB-5758] (android/iOS) Possi...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/172 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-plugin-inappbrowser issue #173: Add property enablepictureinpicture ...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/173 Can you add a JIRA issue to this PR? Thanks! --- - To unsubscribe, e-mail:

[GitHub] cordova-plugin-inappbrowser issue #172: [CB-5758] (android/iOS) Possibility ...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/172 Please re-do this PR, and please don't change the plugin.xml to be based on your repository. There are too much history dragged in from the repo to accept this PR as-is. ---

[GitHub] cordova-plugin-inappbrowser issue #166: Fix for - Stretched tool-bar icons

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/166 Agreed, this does look weird, but should we be hard coding this, or is there a better solution for this? (i.e. resizing the buttons) ---

[GitHub] cordova-plugin-inappbrowser issue #165: Enable thirdparty cookies on >=Andro...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/165 This needs a JIRA issue attached to it. I don't see any conflicts, however. --- - To unsubscribe, e-mail:

[GitHub] cordova-plugin-inappbrowser issue #159: Adding more configuration options fo...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/159 There's no proposal in the cordova repo, nor is there a JIRA issue regarding this feature addition. There needs to be these things before we can add this API change to the

[GitHub] cordova-plugin-inappbrowser issue #156: send back loaderror when "show" fail...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/156 Closing this issue, since it should be sending the error as a plugin result on the Callback instead of sending a random JSON object. ---

[GitHub] cordova-plugin-inappbrowser pull request #156: send back loaderror when "sho...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/156 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-plugin-inappbrowser issue #122: Added Android cookie sharing functio...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/122 So, is this functionality not working? It would help if there was a JIRA issue attached to this PR. I don't see XWalk functionality being a huge issue since XWalk is no longer

[GitHub] cordova-plugin-inappbrowser pull request #116: Added support for file:/// ac...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/116 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-plugin-inappbrowser issue #116: Added support for file:/// access

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/116 Closing this PR as abandoned, since it's been over a year since @shazron last checked in on this. --- - To

[GitHub] cordova-plugin-inappbrowser issue #115: Support for passing request headers ...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/115 This is an API change and should be discussed on the list, or at the very least have a JIRA issue attached to it. Also, the conflicts are definitely going to prevent this from

[GitHub] cordova-plugin-inappbrowser issue #111: give the ability to trust a certific...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/111 This has the following wrong with it: 1. You changed the package.json 2. You don't have a JIRA issue attached to this 3. There are other conflicts with the current

[GitHub] cordova-plugin-inappbrowser issue #99: inAppBrowser custom application schem...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/99 The code changes in iOS are delaying this. That being said, I don't know if blindly adding Application URIs in an InAppBrowser is a good idea in this case. ---

[GitHub] cordova-plugin-inappbrowser issue #88: CB-3750: Add loading spinner for andr...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/88 This still needs to merge cleanly to be added. Please fix all the conflicts to add this code if you are still interested in adding this PR. ---

[GitHub] cordova-plugin-inappbrowser issue #87: CB-8552 Add toolbar option for androi...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/87 @cjpearson Are you still interested in contributing this? Can you fix the merge conflicts in this PR? Thanks ---

[GitHub] cordova-plugin-inappbrowser pull request #77: Android enhancements

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/77 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-plugin-inappbrowser issue #77: Android enhancements

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/77 You can't change the name of the plugin. This code is also old and conflicts with the repo, so this PR will be closed. ---

[GitHub] cordova-plugin-inappbrowser pull request #73: Added editablelocation option ...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/73 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-plugin-inappbrowser issue #73: Added editablelocation option for and...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/73 This is a Won't Fix because you aren't supposed to be able to change the URI on the Address Bar of the InAppBrowser. Closing because this is a "Won't Fix" and because this has

[GitHub] cordova-plugin-inappbrowser pull request #62: Send 'Activity not found' as a...

Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-inappbrowser/pull/62 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-plugin-inappbrowser issue #62: Send 'Activity not found' as an error...

Github user infil00p commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/62 Closing this PR since it's got too many random commits on it as @clelland has mentioned earlier. --- - To

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

Github user kbrin423 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/85 After applying "viewport-fit=cover", my caret position in textarea is not good because textarea moved. If I scroll my caret position change ---

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

Github user smanuel commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/85 @mhartington this works as a charm on iPhone X but now on iPhone 8 the statusbar doesn't overlay the webview because frame.origin.y is 20 ---

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

Github user DavidRyu123 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/85 @mhartington Thanks for your contribution Mike. I wonder if there is anyone who are experiencing that ion-input text moved 20px to top after applying "viewport-fit=cover"

[GitHub] cordova-plugin-camera pull request #286: CB-13307: (Android) Fixed issue whe...

GitHub user DavidBriglio opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/286 CB-13307: (Android) Fixed issue when unable to load image with mime t… …ype "image/*", and failing to recognize new contentprovider uri authority. ### Platforms

[GitHub] cordova-plugin-camera pull request #285: CB-13307: (Android) Fixed issue whe...

Github user DavidBriglio closed the pull request at: https://github.com/apache/cordova-plugin-camera/pull/285 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail:

[GitHub] cordova-plugin-camera pull request #285: CB-13307: (Android) Fixed issue whe...

GitHub user DavidBriglio opened a pull request: https://github.com/apache/cordova-plugin-camera/pull/285 CB-13307: (Android) Fixed issue when unable to load image with mime t… …ype "image/*", and failing to recognize new contentprovider uri authority. ### Platforms

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

Github user mhartington commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/85 This pr does not address everything. In order to have full iPhoneX support you need the following 1) `viewport-fit=cover` added to your meta tag, this will tell the

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

Github user DavidRyu123 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/85 I have tried both solutions and found out those render some weird behavior in view. So kinda waiting for an update. @dpa99c @thefolenangel ---

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

Github user thefolenangel commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/85 @dpa99c I have applied that "fix" and now my app's view can be scrolled, which makes the buttons that I have fixed to bottom:0px, go up with about 10-15px, and shows my

[GitHub] cordova-plugin-file-transfer issue #178: CB-12745: Adding support for non ba...

Github user Viras- commented on the issue: https://github.com/apache/cordova-plugin-file-transfer/pull/178 Are there any intentions on merging this pull or should I do it myself directly? --- - To unsubscribe,

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

Github user dpa99c commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/85 @DavidRyu123 To remove the white space set `viewport-fit=cover` on the viewport `` tag. See https://stackoverflow.com/a/46232813/777265 ---

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

Github user AshHimself commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/85 I also tried and it did not work either. On Thu, Sep 21, 2017 at 9:07 PM, DavidRyu123 wrote: > I have tried this PR and there is

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

Github user DavidRyu123 commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/85 I have tried this PR and there is still white space issue in iPhone 7 plus and under with iOS11 GM. --- -

[GitHub] cordova-plugin-inappbrowser pull request #241: minor grammar fix

GitHub user jezmck opened a pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/241 minor grammar fix (I'm hoping that the JIRA etc process is not necessary for this small tweak to the readme.) You can merge this pull request into a Git repository by running:

[GitHub] cordova-plugin-statusbar issue #85: CB-13273: fix statusbar spacing with new...

Github user thefolenangel commented on the issue: https://github.com/apache/cordova-plugin-statusbar/pull/85 what is the status of this pull? --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For

[GitHub] cordova-plugin-inappbrowser issue #239: Enabling Appcache for the android we...

Github user janpio commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/239 No need to apologize, I was just curious what this does and if it would make sense to actually have this in the plugin for all users, maybe behind a configuration or option.

[GitHub] cordova-plugin-inappbrowser issue #239: Enabling Appcache for the android we...

Github user walisc commented on the issue: https://github.com/apache/cordova-plugin-inappbrowser/pull/239 Hi @janpio and @janpio Apologies for this pull request. Was intended for my company's branch. We need to enable AppCaching for the inappbrowser as we serve our app remotely (for