Nightly build #1226 for cordova has succeeded!

2019-11-07 Thread Apache Jenkins Server
Nightly build #1226 for cordova has succeeded! The latest nightly has been published and you can try it out with 'npm i -g cordova@nightly' For details check build console at https://builds.apache.org/job/cordova-nightly/1226/consoleFull - Jenkins for Apache Cordova

Re: [VOTE] Cordova-ESLint 1.0.0 Release

2019-11-07 Thread Jesse
+1 - coho verify archive - ran tests On Thu, Nov 7, 2019 at 3:25 AM wrote: > I vote +1: > * `npm test` passes (Lints itself) > * I manually tested it on cordova-create > > Am Do., 7. Nov. 2019 um 12:07 Uhr schrieb Bryan Ellis : > > > Please review and vote on this Cordova ESLint Major Release

[GitHub] [cordova-eslint] raphinesse merged pull request #5: Test all exported configurations

2019-11-07 Thread GitBox
raphinesse merged pull request #5: Test all exported configurations URL: https://github.com/apache/cordova-eslint/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [cordova-eslint] raphinesse merged pull request #6: Add GitHub Actions CI

2019-11-07 Thread GitBox
raphinesse merged pull request #6: Add GitHub Actions CI URL: https://github.com/apache/cordova-eslint/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [cordova-eslint] raphinesse commented on a change in pull request #6: Add GitHub Actions CI

2019-11-07 Thread GitBox
raphinesse commented on a change in pull request #6: Add GitHub Actions CI URL: https://github.com/apache/cordova-eslint/pull/6#discussion_r343677714 ## File path: .github/workflows/nodejs.yml ## @@ -0,0 +1,47 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [cordova-eslint] timbru31 commented on a change in pull request #6: Add GitHub Actions CI

2019-11-07 Thread GitBox
timbru31 commented on a change in pull request #6: Add GitHub Actions CI URL: https://github.com/apache/cordova-eslint/pull/6#discussion_r343676101 ## File path: .github/workflows/nodejs.yml ## @@ -0,0 +1,47 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [cordova-eslint] raphinesse commented on a change in pull request #6: Add GitHub Actions CI

2019-11-07 Thread GitBox
raphinesse commented on a change in pull request #6: Add GitHub Actions CI URL: https://github.com/apache/cordova-eslint/pull/6#discussion_r343674154 ## File path: .github/workflows/nodejs.yml ## @@ -0,0 +1,47 @@ +# Licensed to the Apache Software Foundation (ASF) under

[GitHub] [cordova-eslint] timbru31 commented on a change in pull request #6: Add GitHub Actions CI

2019-11-07 Thread GitBox
timbru31 commented on a change in pull request #6: Add GitHub Actions CI URL: https://github.com/apache/cordova-eslint/pull/6#discussion_r343670030 ## File path: .github/workflows/nodejs.yml ## @@ -0,0 +1,47 @@ +# Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [cordova-eslint] raphinesse opened a new pull request #6: Add GitHub Actions CI

2019-11-07 Thread GitBox
raphinesse opened a new pull request #6: Add GitHub Actions CI URL: https://github.com/apache/cordova-eslint/pull/6 This PR adds CI via GitHub Actions to this repository. - I have opted to keep it simple and use only one job that does both the linting and the test running. I think

[GitHub] [cordova-eslint] raphinesse opened a new pull request #5: Add tests for all exported configurations

2019-11-07 Thread GitBox
raphinesse opened a new pull request #5: Add tests for all exported configurations URL: https://github.com/apache/cordova-eslint/pull/5 This PR adds Jasmine tests that load each exported configuration once with ESLint to verify that they follow the correct schema.

Re: [VOTE] Cordova-ESLint 1.0.0 Release

2019-11-07 Thread raphinesse
I vote +1: * `npm test` passes (Lints itself) * I manually tested it on cordova-create Am Do., 7. Nov. 2019 um 12:07 Uhr schrieb Bryan Ellis : > Please review and vote on this Cordova ESLint Major Release v1.0.0 > by replying to this email (and keep discussion on the DISCUSS thread) > > The

[VOTE] Cordova-ESLint 1.0.0 Release

2019-11-07 Thread Bryan Ellis
Please review and vote on this Cordova ESLint Major Release v1.0.0 by replying to this email (and keep discussion on the DISCUSS thread) The archive has been published to dist/dev: https://dist.apache.org/repos/dist/dev/cordova/eslint-v1.0.0 The package was published from its corresponding git

[GitHub] [cordova-eslint] erisu merged pull request #4: chore: updated package-lock & added RELEASENOTES.md

2019-11-07 Thread GitBox
erisu merged pull request #4: chore: updated package-lock & added RELEASENOTES.md URL: https://github.com/apache/cordova-eslint/pull/4 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [cordova-eslint] erisu merged pull request #3: chore: add .npmignore

2019-11-07 Thread GitBox
erisu merged pull request #3: chore: add .npmignore URL: https://github.com/apache/cordova-eslint/pull/3 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [cordova-eslint] raphinesse commented on a change in pull request #3: chore: add .npmignore

2019-11-07 Thread GitBox
raphinesse commented on a change in pull request #3: chore: add .npmignore URL: https://github.com/apache/cordova-eslint/pull/3#discussion_r343547457 ## File path: .npmignore ## @@ -0,0 +1 @@ +.asf.yaml Review comment: I think we should use ```suggestion .*

[GitHub] [cordova-eslint] erisu opened a new pull request #4: chore: updated package-lock & added RELEASENOTES.md

2019-11-07 Thread GitBox
erisu opened a new pull request #4: chore: updated package-lock & added RELEASENOTES.md URL: https://github.com/apache/cordova-eslint/pull/4 ## Context Final changes for releasing `1.0.0` This is an automated message

[GitHub] [cordova-eslint] erisu opened a new pull request #3: chore: add .npmignore

2019-11-07 Thread GitBox
erisu opened a new pull request #3: chore: add .npmignore URL: https://github.com/apache/cordova-eslint/pull/3 ## Change Context remove `.asf.yaml` from bundled npm package This is an automated message from the Apache

[GitHub] [cordova-eslint] erisu merged pull request #1: chore: added missing package repo & bug field

2019-11-07 Thread GitBox
erisu merged pull request #1: chore: added missing package repo & bug field URL: https://github.com/apache/cordova-eslint/pull/1 This is an automated message from the Apache Git Service. To respond to the message, please log