incubator-cordova-docs pull request: updates in WP7

2012-10-31 Thread purplecabbage
GitHub user purplecabbage opened a pull request: https://github.com/apache/incubator-cordova-docs/pull/38 updates in WP7 You can merge this pull request into a Git repository by running: $ git pull https://github.com/purplecabbage/incubator-cordova-docs WP7_2.2.0Updates

incubator-cordova-docs pull request: updates in WP7

2012-10-31 Thread purplecabbage
Github user purplecabbage closed the pull request at: https://github.com/apache/incubator-cordova-docs/pull/38

Re: iOS 7 went GM

2013-09-12 Thread purplecabbage
As Shaz said, soon they will not. After iOS7 is out. There is still however a reason to support older Xcode version because enterprises can distribute their own apps. Sent from my iPhone On Sep 12, 2013, at 12:19 AM, Samuel Nova samuel.n...@terria.com wrote: Can anyone confirm that Apple

Re: addJavascriptInterface fails on Android API levels 17 and 18 (4.2.2 and 4.3)

2013-09-12 Thread purplecabbage
Android does not use jsi for this exact reason, so it is advised that you do the same. My advice, short of making a full on plugin, is to learn how to use cordova.exec directly and never worry about a bridge again. Sent from my iPhone On Sep 12, 2013, at 12:00 AM, dev at watch2web.com

Re: core plugins mistake

2013-09-17 Thread purplecabbage
not 15 mins after I posted the email On Mon, Sep 16, 2013 at 5:48 PM, purplecabbage purplecabb...@gmail.comwrote: When is this gonna be fixed? I guarantee there are other master commits that should be in this release. Sent from my iPhone On Sep 16, 2013, at 5:03 PM, Shazron shaz

Re: About Cordova 3, plugins, and tools

2013-09-17 Thread purplecabbage
Windows8 is currently all js and supports plugins. All existing plugin code outside of exec is used verbatim, while the exec call just maps it to a js proxy that implements what would otherwise be native. [1] FFOS (all js) is adopting this same mechanism, although currently the commandProxy

Re: [Android] WebView, InAppBrowser and UI Threads

2013-09-19 Thread purplecabbage
Why don't we make relative urls a developer concern? The developer should know their own package, and it can be easily resolved using current window.location and expected location of the file. A minor rant, while we are on the subject of iab: I don't understand why this executeScript madness

Re: Proposal: Change JIRA to have bugs as unassigned by default

2013-09-19 Thread purplecabbage
12 hours? I think we have to wait longer before moving on a proposal. Sent from my iPhone On Sep 19, 2013, at 7:29 AM, Andrew Grieve agri...@chromium.org wrote: Okay, I've made the change. Let's try it out :) I think start/stop is good if you've actually started working on something,

Re: [Android] The state of WebSQL on Android 4.x

2013-09-19 Thread purplecabbage
. @purplecabbage risingj.com On Wed, Sep 18, 2013 at 2:31 PM, Joe Bowser bows...@gmail.com wrote: Ok, We've been ignoring this for quite a while, but it's not going away: There's still people who want to use WebSQL, and WebSQL is still totally broken. Part of the reason it's broken

Re: [Android] WebView, InAppBrowser and UI Threads

2013-09-19 Thread purplecabbage
Andrew, can you post a detailed use case of what you think is broken with URL resolution? I think I am missing something. Sent from my iPhone On Sep 19, 2013, at 7:35 AM, Andrew Grieve agri...@chromium.org wrote: On Thu, Sep 19, 2013 at 3:50 AM, purplecabbage purplecabb...@gmail.comwrote

Re: Proposal: Change JIRA to have bugs as unassigned by default

2013-09-19 Thread purplecabbage
it look like we're abandoning Cordova, which isn't the case. That being said, we should rotate who handles the firehose. On Thu, Sep 19, 2013 at 8:36 AM, purplecabbage purplecabb...@gmail.com wrote: 12 hours? I think we have to wait longer before moving on a proposal. Sent from my iPhone

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread purplecabbage
Q is a good choice. Not talking about it was absolutely the wrong choice. There are no internal teams , there is only this list. Sent from my iPhone On Sep 24, 2013, at 6:48 AM, Braden Shepherdson bra...@chromium.org wrote: We debated internally at Google how much to talk about this. In

Re: Major refactoring of Plugman and CLI

2013-09-24 Thread purplecabbage
. Braden On Tue, Sep 24, 2013 at 2:20 PM, Shazron shaz...@gmail.com wrote: Definitely. Talking about changes is cool, not talking about it -- not cool. On Tue, Sep 24, 2013 at 11:01 AM, purplecabbage purplecabb...@gmail.com wrote: Q is a good choice. Not talking about it was absolutely

Re: Tagging 3.1.0 today?

2013-09-30 Thread purplecabbage
changes to plugins don't affect this, but the win8 cli stuff does affect cordova-cli release, although it should not modify other platforms. We should start by updating our js throughout, assuming there are no more coming changes. @purplecabbage risingj.com On Mon, Sep 30, 2013 at 11:54

Re: Windows 8.1

2013-10-04 Thread purplecabbage
Work in a different branch *always* Don't 'upgrade', both must co-exist for awhile at least. So don't consider it a port or an upgrade , consider it 'adding support for windows 8.1' Sent from my iPhone On Oct 4, 2013, at 5:53 AM, Maxime LUCE max...@somatic.fr wrote: Hi, I plan to port

Re: Windows 8.1

2013-10-16 Thread purplecabbage
Maxime, please hold off on this, I think we need to discuss it more. Continuing to use winjs has serious issues we cannot easily overcome. I am thinking of rewriting the windows8 in c#. Issues include: - security restrictions preventing dom modification - interaction with custom native

Re: Post 3.1 release committer community meeting

2013-10-17 Thread purplecabbage
time difference just got an hour better today... - tommy On 5 Oct 2013 08:33, Jesse purplecabb...@gmail.com wrote: I filled it out, however, Joe is not available until after the 15th. Maybe we should aim for the 16-18th as a window. @purplecabbage risingj.com On Fri, Oct 4, 2013

Re: CLI and Plugman test failures

2013-10-17 Thread purplecabbage
I believe the failures are the result of promise additions. Some 'expects' will have to wait. The error I kept seeing is an attempt to shell.rm Sent from my iPhone On Oct 17, 2013, at 10:21 AM, Steven Gill stevengil...@gmail.com wrote: I actually created an issue about cleaning up the

Re: CLI and Plugman test failures

2013-10-17 Thread purplecabbage
by the refactoring. Since jasmine-node supports the 'done' argument, it's pretty easy to put your expectations into a .then() and then call done(). Braden On Thu, Oct 17, 2013 at 1:44 PM, purplecabbage purplecabb...@gmail.comwrote: I believe the failures are the result of promise additions. Some

Re: new meta data for plugin.xml

2013-10-17 Thread purplecabbage
+ list platforms supported for each plugin + list all plugins available for a platform Sent from my iPhone On Oct 17, 2013, at 4:54 PM, Steven Gill stevengil...@gmail.com wrote: So looks like want to to start including more data on http://plugins.cordova.io. Repo tag - points to repo

Re: new meta data for plugin.xml

2013-10-18 Thread purplecabbage
This thread is about what info is displayed on plugins.cordova.io Sent from my iPhone On Oct 18, 2013, at 5:43 AM, Lucas Holmquist lholm...@redhat.com wrote: On Oct 17, 2013, at 7:54 PM, Steven Gill stevengil...@gmail.com wrote: So looks like want to to start including more data on

Re: config.xml discussion, we need to talk

2013-10-18 Thread purplecabbage
at 12:09 PM, Jesse purplecabb...@gmail.com wrote: IDE or cordova-cli ?? @purplecabbage risingj.com On Fri, Oct 18, 2013 at 12:02 PM, Steven Gill stevengil...@gmail.com wrote: I think SinplePlatform vs MultiPlatform is misleading because you can use the CLI to do single platform

Re: Cordova 3.2.0 Release

2013-10-22 Thread purplecabbage
Yes, pullable. Will test and make sure it makes it into 3.2.0 Sent from my iPhone On Oct 22, 2013, at 6:29 PM, Dick Van den Brink d_vandenbr...@outlook.com wrote: The WP7 and WP8 parsers are still different in Cordova-cli master, WP7 supports a pre_package hook while the WP8 version

Re: 2.9.1 Backport release

2013-10-23 Thread purplecabbage
I made some headway but am not done with WPx. I've had to work through many js issues. I am away until Monday though and haven't had a chance to update windows8. If someone wants to look at that it would be a huge help. I expect ios7 support is going to push the release back to be inline with

Re: Mobile spec tests and exclusion list

2013-10-28 Thread purplecabbage
. My preference is to just fix those though. On Sat, Oct 26, 2013 at 11:02 PM, purplecabbage purplecabb...@gmail.com wrote: Having a known failure in the tests on wp7 is no biggie, it has always been there. Just move on ... Sent from my iPhone On Oct 26, 2013, at 3:24 PM, Michal

Re: cordova-js commits on master but not on 3.2.x branch

2013-11-07 Thread purplecabbage
And the js commits for blackberry did not change the js for other platforms! Win win. Sent from my iPhone On Nov 7, 2013, at 6:56 PM, Carlos Santana csantan...@gmail.com wrote: Thank you Steve ! On Thu, Nov 7, 2013 at 8:06 PM, Steven Gill stevengil...@gmail.com wrote: Sweet. None

Canadian Holiday

2013-11-11 Thread purplecabbage
Today is a statutory holiday in Canada; Just in case anyone was expecting and not receiving a prompt reply from a Canuck. Sent from my iPhone

Re: Transitioning to a better File API implementation

2013-11-15 Thread purplecabbage
Considering the magnitude of the changes I would have expected that this was just a new file plugin. The previous version was based on a spec, and if we are deviating from it we should probably maintain both, and possibly even make a recommendation to the w3c. I hope we at least do a major

Re: plugins tag, and accessing the plugin list

2013-11-15 Thread purplecabbage
+1 to the short term fix and the deep dive punt Sent from my iPhone On Nov 15, 2013, at 10:19 AM, Michal Mocny mmo...@chromium.org wrote: Hmm, sounds pretty un-intrusive. Ship it! We should probably schedule a whole hack-a-thon for figuring out the future of config files. Maybe at our

Re: Platforms in subdirectory into repository

2013-11-27 Thread purplecabbage
/repos/asf?p=cordova-wp8.git ', version: '3.2.0-rc1', subdirectory: 'wp8' }, ... @purplecabbage risingj.com On Thu, Nov 14, 2013 at 11:48 AM, Maxime LUCE max...@somatic.fr wrote: Hi, I fixed tests issues in https://github.com/apache/cordova-cli/pull/69. I

Re: Windows8 and Contacts Api

2013-12-04 Thread purplecabbage
It is NOT supported on win8 because there is no central contact store. [1] is an error. On windows8 any app can be a contact provider by extending and registering the interface, but the API does not provide create functionality.

Re: iOS webview size

2013-12-07 Thread purplecabbage
Most device browsers report device-width as 320px for backwards compatability from when sites were designed to fit the iPhone screen. Lots of info here: https://developer.mozilla.org/en-US/docs/Mozilla/Mobile/Viewport_meta_tag Sent from my iPhone On Dec 7, 2013, at 4:17 AM, Maxime LUCE

Re: Plugin Hooks on Android

2014-01-08 Thread purplecabbage
I'm with Joe. Stay flexible, and future friendly. The messages that are posted probably just need to be better documented, or we need to point plugin devs towards Android's docs. Sent from my iPhone On Jan 8, 2014, at 9:11 PM, Joe Bowser bows...@gmail.com wrote: On Wed, Jan 8, 2014 at

Re: Need to revert a CLI breaking change causing CB-5957

2014-02-06 Thread purplecabbage
before an npm publish I agree Mark, the change is valuable, and I don't mean to single you out. I am just concerned about how it made it to npm while obviously broken on windows devices. @purplecabbage risingj.com On Wed, Feb 5, 2014 at 11:22 AM, Mark Koudritsky kam...@google.com

Re: Need to revert a CLI breaking change causing CB-5957

2014-02-08 Thread purplecabbage
without an actual device. Also, debugging on a WP8 devices or side-loading apps for testing requires the SDK (and the tools that come with it) to be installed too. -Original Message- From: purplecabbage [mailto:purplecabb...@gmail.com] Sent: Thursday, February 6, 2014 12:33 PM

Re: Using cordova in web workers

2014-02-12 Thread purplecabbage
Yes, as will the call to cordova.exec so there is little benefit in using a worker here, unless you wanted to do a bunch of work, and then call exec. Sent from my iPhone On Feb 12, 2014, at 8:30 PM, Christian G. Warden cwar...@xerus.org wrote: And stringByEvaluatingJavaScriptFromString

Re: [Vote] Cordova 3.4.0 release

2014-02-18 Thread purplecabbage
IMO, If it was not in the release candidate, it should not be pushed into the release. If we need to turn around and do a 3.4.1 to address an issue, then we can do that. On Feb 18, 2014, at 6:16 PM, Andrew Grieve agri...@chromium.org wrote: -1 There's one iOS fix that I think we

Re: CB-6121 (Windows command line script for Mobile spec)

2014-03-04 Thread purplecabbage
I looked at doing this for CB-5963, but I didn't consider writing a bat file. IMO this would be better served by a node module that runs everywhere. I did not consider taking it as far as you did Martin, nice work! Have you considered making it run in node so Mac users can share it? plus we

Re: How to implement the navigator.notification in Firefox OS?

2014-03-04 Thread purplecabbage
These are features I am looking to add to plugman. Currently there isn't a way to add CSS or generic JS, short of runtime heroics. It would be nice to be able to make a Cordova plugin that, for example, used topcoat, underscore or angular. Currently all plugin js gets wrapped in our

Re: [cordova-plugins/statusbar] Publishing as core

2014-03-07 Thread purplecabbage
have created a task in JIRA for all the statusbar related discussion. [1] There are numerous inconsistencies we need to address here. [1] https://issues.apache.org/jira/browse/CB-6177 @purplecabbage risingj.com On Wed, Mar 5, 2014 at 5:15 PM, Shazron shaz...@gmail.com wrote: Some

[GitHub] cordova-app-hello-world pull request: CB-2528 Add window.onerror

2014-03-10 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/6#issuecomment-37225171 I agree, this would be better placed inside js/index.js and probably it should be /*commented*/ out with instructions to developers to uncomment

[GitHub] cordova-app-hello-world pull request: CB-2528 Add window.onerror

2014-03-10 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-app-hello-world/pull/6#issuecomment-37232204 @jsoref be careful not to recommend a platform specific option. Alert makes sense in some cases, and console.log in some others. --- If your

Re: plugman create plugin on Windows issues

2014-03-14 Thread purplecabbage
What is your shell? If you use git bash then either escape \ = \\ or use / Sent from my iPhone On Mar 14, 2014, at 7:56 AM, Lisa Seacat DeLuca ldel...@us.ibm.com wrote: Bas, good catch. Still seeing the same error though when I use a : instead of ; C:\workspaces\lisa\test2plugman

[GitHub] cordova-wp8 pull request: CB-6268 WP8. Apply BackgroundColor from ...

2014-03-15 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/29#issuecomment-37719741 Okay, not sure where or why the 'feature' came from, but it does NOT exist in iOS either. The other platforms ( Android and BlackBerry ) support

[GitHub] cordova-wp8 pull request: CB-6268 WP8. Apply BackgroundColor from ...

2014-03-15 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/29#issuecomment-37720080 I have re-organized the issues for WP8 and Windows8, so they are now subtasks. https://issues.apache.org/jira/browse/CB-6273 You can use

Re: [GitHub] cordova-wp8 pull request: CB-5203 Using XmlHTTPRequest.open on WP8...

2014-03-18 Thread purplecabbage
The c# file is the right place to fix it, that's where the js interface comes from. What specifically is happening @dotnetwise? Do you have any error messages? Sent from my iPhone On Mar 18, 2014, at 8:17 AM, dotnetwise g...@git.apache.org wrote: Github user dotnetwise commented on the

[GitHub] cordova-wp8 pull request: CB-6299 Strip protocol and leading slash...

2014-03-19 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/30#issuecomment-38070676 Thanks. I'll add a test to spec and close this up today. Sent from my iPhone On Mar 19, 2014, at 7:42 AM, gabrielschulhof notificati

[GitHub] cordova-ios pull request: Adding rebroadcast capabilities to remot...

2014-03-22 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-ios/pull/94#issuecomment-38370798 http://cordova.apache.org/#contribute --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-cli pull request: CB-6267 Windows8. Apply BackgroundColor ...

2014-03-24 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/142#issuecomment-38505972 This is being merged, however, I believe this property can be changed after 'create' has been called. There should be a platform script that ensures any

[GitHub] cordova-cli pull request: CB-6256 Windows8. Apply start page uri f...

2014-03-24 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/140#issuecomment-38506897 This needs to be handled in the platform repo, projects can be built outside of the cordova-cli and if the property is in the application root config.xml

[GitHub] cordova-cli pull request: CB-6266 Windows8. Add Whitelisting rules...

2014-03-24 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/141#issuecomment-38506944 This needs to be handled in the platform repo, projects can be built outside of the cordova-cli and if the property is in the application root config.xml

[GitHub] cordova-cli pull request: Splash screen support via config.xml for...

2014-03-24 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/145#issuecomment-38506992 This needs to be handled in the platform repo, projects can be built outside of the cordova-cli and if the property is in the application root config.xml

[GitHub] cordova-plugin-camera pull request: Update index.md

2014-03-31 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-camera/pull/21#issuecomment-39139828 I agree it's ugly, and confusing. It should be made clearer that the line is NOT and example, but indeed a function signature. Do we do

Re: Plans for Windows Phone 8.1

2014-04-04 Thread purplecabbage
Yes. I am /build now. This will be a 4.0 feature to combine the source. Probably nothing is easy ;) Sent from my iPhone On Apr 4, 2014, at 8:45 AM, domokos.lor...@yahoo.com wrote: Hello, Any plans for Windows Phone 8.1? Would be very similar (probably exactly the same) to Windows 8.1

Re: [DISCUSS] Release 3.5.0

2014-04-04 Thread purplecabbage
I would like to see 3.5.0 ready to vote on late next week. I have some house keeping to do, as there are big fixes for windows 8 and wp8 that need to be pushed out. I've been away for /build so haven't been able to do much this week. Sent from my iPhone On Apr 4, 2014, at 9:07 AM,

Re: Ship stage.plugins.cordova.io

2014-04-04 Thread purplecabbage
Love it! Ship it! Sent from my iPhone On Apr 4, 2014, at 11:01 AM, David Kemp drk...@chromium.org wrote: Love the fact that its usable on my phone! LGTM On Fri, Apr 4, 2014 at 1:12 PM, Andrew Grieve agri...@chromium.org wrote: Just did some clicking through. It's night day better

Re: cli e2e tests - delete the older duplicates in spec/

2014-04-04 Thread purplecabbage
I am a +1 I would like to see ALL tests in a 'spec' or 'tests' folder though, as it is not obvious what 'e2e' is. Sent from my iPhone On Apr 4, 2014, at 12:27 PM, Josh Soref jso...@blackberry.com wrote: Mark wrote: Back in november we had a

Re: cli e2e tests - delete the older duplicates in spec/

2014-04-04 Thread purplecabbage
SGTM! Sent from my iPhone On Apr 4, 2014, at 1:00 PM, Mark Koudritsky kam...@google.com wrote: On Fri, Apr 4, 2014 at 3:36 PM, purplecabbage purplecabb...@gmail.comwrote: I am a +1 I would like to see ALL tests in a 'spec' or 'tests' folder though, as it is not obvious what 'e2e

[GitHub] cordova-windows pull request: CB-6256 CB-6266 Add support for doma...

2014-04-07 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/23#issuecomment-39775030 Hi Vladimir, Thanks for your contributions. I do not see an CLA on file when I look for your name at https://people.apache.org/committer

[GitHub] cordova-windows pull request: Update cordova.js

2014-04-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/21#issuecomment-39904054 Cannot merge this pull-req, cordova.js is build output of the cordovajs project. I will fix it there. and DUPE --- If your project is set up

[GitHub] cordova-windows pull request: Update cordova.js

2014-04-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/22#issuecomment-39904013 Cannot merge this pull-req, cordova.js is build output of the cordovajs project. I will fix it there. --- If your project is set up for it, you can

[GitHub] cordova-windows pull request: Update cordova.js

2014-04-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/22#issuecomment-39906082 Issue created here: https://issues.apache.org/jira/browse/CB-6419 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-windows pull request: Update cordova.js

2014-04-08 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/21#issuecomment-39906094 Issue created here: https://issues.apache.org/jira/browse/CB-6419 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-plugin-file pull request: Add error codes.

2014-04-09 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/37#issuecomment-40001813 +1 It may be good to provide a better example of error handling as well. I would expect having a function like this that you could just copy

[GitHub] cordova-plugman pull request: CB-6414 - fixes the issue where two ...

2014-04-09 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugman/pull/72#issuecomment-40002842 @jbavari Unrelated to this thread, you should add your name to github so readers of this thread can resolve jbavari == Josh Bavari, I was initially

[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...

2014-04-11 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/38#issuecomment-40234237 Thank you Nadya, Do you have an CLA on file? I see a Nadezhda Atanasova listed here: https://people.apache.org/committer-index.html

[GitHub] cordova-wp8 pull request: Fix for position fix not working.

2014-04-14 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/31#issuecomment-40396152 The addition of Windows Phone support has not been published to the registry. If you install from source [1] support for WP is there. [1] https

[GitHub] cordova-plugin-inappbrowser pull request: window.open(url, '_syste...

2014-04-14 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/39#issuecomment-40398079 This has been addressed in JS code [1] , and is a native patch is also part of pull-req #38 Expect these changes to land

[GitHub] cordova-plugin-inappbrowser pull request: Make InAppBrowser work w...

2014-04-14 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/38#issuecomment-40432983 I have merged your code into the dev branch, so this should close once it gets merged to master and published, Note: I added 'await' calls

[GitHub] cordova-windows pull request: CB-6435 ./VERSION /template/VERSIO...

2014-04-15 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/25#issuecomment-40528015 Closed, thank you. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-plugin-media-capture pull request: [CB-5054] fixed capture...

2014-04-16 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-media-capture/pull/4#issuecomment-40654059 Thanks Kyle, will look at this shortly. On Apr 16, 2014, at 12:41 PM, Kyle Linden notificati...@github.com wrote

Re: Proposal for cli and plugman code rearrangement

2014-04-16 Thread purplecabbage
Oops, I am okay with anytime tomorrow. How can they not list time zones in the UI? Sent from my iPhone On Apr 16, 2014, at 3:05 PM, Victor Sosa sosah.vic...@gmail.com wrote: Great!! Thanks Mark 2014-04-16 17:02 GMT-05:00 Mark Koudritsky kam...@google.com: I'll arrange a hangout

Re: should FileTransfer.download() auto mkdir target's path?

2014-04-17 Thread purplecabbage
can choose to make file-transfer it's own (higher level) thing with it's own conventions, or we can aim for cohesiveness ... the original design was based on being cohesive, I think. @purplecabbage risingj.com On Wed, Apr 16, 2014 at 12:42 PM, Ian Clelland iclell...@chromium.org

[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...

2014-04-21 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-40956290 I think it makes sense for the pickContact to at least support the `multiple` option. It should be available on all platforms. Also, I am

[GitHub] cordova-plugin-splashscreen pull request: CB-6483 Use splash scree...

2014-04-21 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/18#issuecomment-40992761 Thanks Sergey, Your pull req will not apply cleanly to dev. --- If your project is set up for it, you can reply to this email and have

[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...

2014-04-21 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/36#issuecomment-40994122 Hi @yaurthek, thanks for the contributuion. Have you signed the iCLA? I do not see you listed on https://people.apache.org/committer-index.html

[GitHub] cordova-plugin-inappbrowser pull request: Add necessary capability...

2014-04-21 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/33#issuecomment-40994721 Merged to dev branch, this will be available in the next release of the plugin. Thanks. --- If your project is set up for it, you can reply

Re: Proposal: hooks support for plugins

2014-04-22 Thread purplecabbage
If you need a shell script, that can be easily hidden behind the node module. Sent from my iPhone On Apr 22, 2014, at 9:34 AM, Brian LeRoux b...@brian.io wrote: Maybe harsh but I'm in favor of abandoning shell scripts altogether and forcing modules as the way for hooks. Cross platform yada

[GitHub] cordova-plugin-contacts pull request: Add pickContact functionalit...

2014-04-22 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-contacts/pull/26#issuecomment-41075134 Yeah, they are different, I think you're right to keep them that way. Re:multiple, separate pull req is fine. Jira enhancement? --- If your

Re: [iOS] Objective-C object binding to UIWebWiew's JavaScriptCore

2014-04-22 Thread purplecabbage
+1 to test first. Any other path is risky IMHO. Sent from my iPhone On Apr 22, 2014, at 11:27 AM, Shazron shaz...@gmail.com wrote: I've always thought of it as a conditional compilation option (#ifdef DEBUG). A plugin is a good idea, that way it is isolated. The plugin would be an

[GitHub] cordova-mobile-spec pull request: CB-6437[Improvements support f...

2014-04-22 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-mobile-spec/pull/55#issuecomment-41097230 Or just add a .gitignore --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] cordova-windows pull request: Update cordova.js

2014-04-22 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/22#issuecomment-41106257 This issue has been addressed and will appear in the 3.5.0 release. Issue here: https://issues.apache.org/jira/browse/CB-6419 Please close

[GitHub] cordova-windows pull request: Update cordova.js

2014-04-22 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/21#issuecomment-41106324 This issue has been addressed and will appear in the 3.5.0 release. Issue here: https://issues.apache.org/jira/browse/CB-6419 Please close

Re: Looking for input on syntax to use for specifying plugin deps in config.xml

2014-04-22 Thread purplecabbage
I think consistency with input and output config.xml files makes more sense than consistency with plugin.xml. So +1 feature/ Sent from my iPhone On Apr 22, 2014, at 8:06 PM, Gorkem Ercan gorkem.er...@gmail.com wrote: On Tue, Apr 22, 2014 at 8:44 PM, Andrew Grieve agri...@chromium.org wrote:

Re: [DISCUSS] Plugin master branches

2014-04-23 Thread purplecabbage
@purplecabbage risingj.com -- Carlos Santana csantan...@gmail.com

Re: Looking for input on syntax to use for specifying plugin deps in config.xml

2014-04-23 Thread purplecabbage
in config.xml (e.g. apps depend on platforms as well). So, how about using cdv:plugin? Name is quite clear :). On Wed, Apr 23, 2014 at 12:35 AM, purplecabbage purplecabb...@gmail.com wrote: I think consistency with input and output config.xml files makes more sense than consistency

[GitHub] cordova-plugin-file-transfer pull request: on iOS, Android and Ama...

2014-04-23 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#discussion_r11916904 --- Diff: plugin.xml --- @@ -2,7 +2,7 @@ plugin xmlns=http://apache.org/cordova/ns/plugins/1.0; xmlns:android=http

[GitHub] cordova-plugin-file-transfer pull request: CB-6503 allow file uplo...

2014-04-23 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file-transfer/pull/27#issuecomment-41204151 Thanks. The automagical link is just when the pull request is merged into master, the jira issue gets updated with the commit

[GitHub] cordova-windows pull request: CB-6256 CB-6266 Add support for doma...

2014-04-23 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/23#issuecomment-41207048 Hi @vladimir-kotikov I have added a comment in Jira here : https://issues.apache.org/jira/browse/CB-6266?focusedCommentId=13978791page

[GitHub] cordova-plugin-inappbrowser pull request: window.open failing with...

2014-04-23 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-inappbrowser/pull/22#issuecomment-41241090 Just pass an options object ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-25 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/170#issuecomment-41448489 I think you should tag the OSX repo so that platforms.js can point to some 'known to work' version if it, and not just to 'master' master is the bleeding

Re: [JS] merging to master for cordova-js and cordova-plugman

2014-04-25 Thread purplecabbage
I believe the plan was, merge now to save headaches later *but* also hide the browserify functionality behind a flag, so it could co-exist. Sent from my iPhone On Apr 25, 2014, at 5:40 PM, Anis KADRI anis.ka...@gmail.com wrote: On Fri, Apr 25, 2014 at 11:05 AM, Andrew Grieve

[GitHub] cordova-plugin-file pull request: fix the Windows 8 implementation...

2014-04-27 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-file/pull/36#issuecomment-41493185 Thanks, will merge Monday. Just On Apr 27, 2014, at 12:21 AM, Melvyn notificati...@github.com wrote: Hi, I'm just letting you

[GitHub] cordova-cli pull request: Windows 8.1 update breaks app manifest p...

2014-04-28 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/171#issuecomment-41593880 Issue created here: https://issues.apache.org/jira/browse/CB-6536 Merged, and issue closed. --- If your project is set up for it, you can reply

[GitHub] cordova-windows pull request: cordova run test + add common.js l...

2014-04-28 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-windows/pull/19#issuecomment-41599483 The inclusion of 'eval' to load code is problematic. This pull-request will not be merged. You can close it. --- If your project is set up for it, you

[GitHub] cordova-wp8 pull request: CB-5203 Using XmlHTTPRequest.open on WP8...

2014-04-28 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-wp8/pull/19#issuecomment-41606953 @dotnetwise The .cs file writes js to the WebBrowser to handle XHR. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-28 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/170#issuecomment-41610058 I have added a VERSION file and tagged 3.5.0-dev --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] cordova-cli pull request: CB-6506 RTC: Add support for OSX

2014-04-28 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-cli/pull/170#issuecomment-41613278 yes, I see that now. Do not need both, although I am a little confused why iOS + OSX both have them in a lib folder while every other platform has

Re: Help Wanted: Pull Requests

2014-04-29 Thread purplecabbage
Um, Sergey is a committer, has been from since we moved to Apache. Sent from my iPhone On Apr 29, 2014, at 10:14 AM, Parashuram Narasimhan (MS OPEN TECH) panar...@microsoft.com wrote: We also have a couple of pull requests open for Contacts, and other plugins. Would love to see them

[GitHub] cordova-plugin-splashscreen pull request: CB-6483 Use splash scree...

2014-04-30 Thread purplecabbage
Github user purplecabbage commented on the pull request: https://github.com/apache/cordova-plugin-splashscreen/pull/18#issuecomment-41862976 Merged, this should auto-close soon --- If your project is set up for it, you can reply to this email and have your reply appear

  1   2   3   4   5   6   7   8   9   >