[GitHub] cordova-lib issue #600: CB-13478 : Fix CRLF line endings and lint integratio...

2017-10-26 Thread akdor1154
Github user akdor1154 commented on the issue: https://github.com/apache/cordova-lib/pull/600 is that sufficient? wanted to keep stylistic and behavioural changes in separate commits. --- - To unsubscribe, e-mail

[GitHub] cordova-lib pull request #602: CB-12774 : Don't munge scoped plugin IDs anym...

2017-10-25 Thread akdor1154
Github user akdor1154 commented on a diff in the pull request: https://github.com/apache/cordova-lib/pull/602#discussion_r147012928 --- Diff: src/cordova/util.js --- @@ -255,11 +255,20 @@ function findPlugins (pluginDir) { var plugins = []; if (fs.existsSync

[GitHub] cordova-lib pull request #602: CB-12774 : Don't munge scoped plugin IDs anym...

2017-10-23 Thread akdor1154
GitHub user akdor1154 opened a pull request: https://github.com/apache/cordova-lib/pull/602 CB-12774 : Don't munge scoped plugin IDs anymore. Comment requested. In order to get plugins that are under an npm scope (e.g. `@akdor1154/some-plugin`) to install, a previous change from

[GitHub] cordova-lib issue #601: CB-13485: Test with Node8

2017-10-23 Thread akdor1154
Github user akdor1154 commented on the issue: https://github.com/apache/cordova-lib/pull/601 Ah, don't we love npm 5? I didn't expect this to break so early, I'll look tomorrow. --- - To unsubscribe, e-mail: dev

[GitHub] cordova-lib pull request #601: CB-13485: Test with Node8

2017-10-23 Thread akdor1154
GitHub user akdor1154 opened a pull request: https://github.com/apache/cordova-lib/pull/601 CB-13485: Test with Node8 ### What does this PR do? Enables testing on Node 8 with Travis, and fixes the failing tests (no behaviour changes seem necessary). ### What testing

[GitHub] cordova-lib pull request #600: CB-13478 : Fix CRLF line endings and lint int...

2017-10-20 Thread akdor1154
GitHub user akdor1154 opened a pull request: https://github.com/apache/cordova-lib/pull/600 CB-13478 : Fix CRLF line endings and lint integration tests. ### Platforms affected N/A ### What does this PR do? - Change CRLFs to LFs - Configures eslint