Github user filmaj commented on the issue:
https://github.com/apache/cordova-docs/pull/719
It is. We need the docs updated to remove references to plugins that are
being integrated/removed - we have more of these kinds of changes coming down
the pipeline
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/187
I think we also want to remove the stuff from the README around how
`trustAllHosts` is supported on Android.
---
If your project is set up for it, you can reply to this email
Github user filmaj commented on the issue:
https://github.com/apache/cordova-js/pull/148
Ah, this test clarifies the style _so much better_.
I know we've thrown the idea around to change this, but until we do, I
think it may be worth documenting this. The README, in general
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/187#discussion_r136122199
--- Diff: www/FileTransfer.js ---
@@ -163,7 +162,7 @@ FileTransfer.prototype.upload = function(filePath,
server, successCallback, erro
Github user filmaj commented on the issue:
https://github.com/apache/cordova-docs/pull/714
No, it's more like: one of the PMC members needs to go through the manual
steps of a) integrating translations (to me it is unclear how to do this), b)
building cordova-docs locally and c
Github user filmaj commented on the issue:
https://github.com/apache/cordova-js/pull/146
Just to make sure people here see it: reverting this commit, and leaving
relative `require` calls in e.g. the integrated console plugin in cordova-ios
will lead to errors such as:
https
Github user filmaj commented on the issue:
https://github.com/apache/cordova-js/pull/146
OK, sorry that this change broke stuff! My bad.
Chalk up a "make cordova's `require` work more like node / other `require`
implementations" to the todo list?
---
If your proj
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-js/pull/147
CB-8990: bump nodejs requirement to 4.0.0+
So that we can close https://issues.apache.org/jira/browse/CB-8990
You can merge this pull request into a Git repository by running:
$ git pull
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/227
Hey, i'm on vacation for the next couple of weeks (getting married!). CAN
you get someone else to review? Perhaps @stevesgill
On Aug 15, 2017 11:50 AM, "N
Github user filmaj commented on the issue:
https://github.com/apache/cordova-docs/pull/719
Here's what I see when running your branch locally via `gulp serve`:
https://user-images.githubusercontent.com/52645/29198361-34564cc4-7df8-11e7-9766-3e916fef86de.png;>
---
If y
Github user filmaj commented on the issue:
https://github.com/apache/cordova-docs/pull/719
So i checked this branch out, built the docs, served via `gulp serve`, and
I still see the plugin API reference in the left-hand side. So we're still
missing something here...
---
If your
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/39
Same deal here, looks like @macdonst started this already in #36
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device-motion/pull/57
I'd also suggest we add an [`` tag to the
plugin.xml](https://cordova.apache.org/docs/en/latest/plugin_ref/spec.html#info)
where we can be more noisy about the deprecation status
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device-motion/pull/57
Isn't this at odds with @macdonst's PR open in #53 ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device-motion/pull/57
Yeah but it's basically the same stuff, no? I think we should combine what
you two have done. I like that you link to the transition blog post. I like
that Simon also updated
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-js/pull/146
CB-13163: fix using relative paths in calls to require.
Using relative paths in calls to `require` failed.
The single-character patch caused me to chuckle.
Added a test
Github user filmaj commented on the issue:
https://github.com/apache/cordova-docs/pull/717
Not a problem at all :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user filmaj commented on the issue:
https://github.com/apache/cordova-lib/pull/589
Thanks for the PR! I have rebased and merged in at 2dc7fe1a. @remcohaszing
can you close this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user filmaj commented on the issue:
https://github.com/apache/cordova-docs/pull/717
I've rebased, merged and tweaked the commit message over in 4e0692a20.
@janpio can you close this PR?
Thanks for the fix!
---
If your project is set up for it, you can reply
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/284#discussion_r132287655
--- Diff: doc/readme.md ---
@@ -186,7 +186,7 @@ After building the Android and iOS projects, the
Android application will contai
Version
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/284#discussion_r132287819
--- Diff: doc/readme.md ---
@@ -230,7 +230,7 @@ cordova {platform | platforms} [
| | --save | Updates the version specified
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/284#discussion_r132287980
--- Diff: doc/readme.md ---
@@ -374,7 +374,7 @@ based on the following criteria (listed in order of
precedence):
### Examples
Github user filmaj commented on the issue:
https://github.com/apache/cordova-docs/pull/714
Filed that issue here: https://issues.apache.org/jira/browse/CB-13162
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user filmaj commented on the issue:
https://github.com/apache/cordova-docs/pull/714
One of the Cordova PMC members needs to build and update the website based
on the latest docs.
We should automate this ð
---
If your project is set up for it, you can reply
Github user filmaj commented on the issue:
https://github.com/apache/cordova-docs/pull/714
I've merged this in in 9f31ce77b
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user filmaj commented on the issue:
https://github.com/apache/cordova-docs/pull/716
Thanks for taking a stab at this! Let me know when you're happy with it and
I'll merge it in.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
@janpio I have merged in your changes to master, see
7611645469aa4f9a4b0ebeb826317030cc2900a2.
Can you close this pull request?
---
If your project is set up
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/234
OK I had to rebase your patch one more time - it is merged in in
7611645469aa4f9a4b0ebeb826317030cc2900a2.
@janpio can you close this pull request now?
---
If your
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-test-framework/pull/26
Yep! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
Sounds good, I'll check that out. Thanks for taking that on!
> because now "This branch is 3 commits ahead of apache:master. "
âï¸ that's
Github user filmaj commented on the issue:
https://github.com/apache/cordova-windows/pull/235
I'm not familiar with this changeset enough, but I think this probably
needs unit tests :)
Once more, ping @stevengill.
---
If your project is set up for it, you can reply
Github user filmaj commented on the issue:
https://github.com/apache/cordova-lib/pull/565
OK, with the testing all cleaned up in lib now, we can come back to this PR.
@matrosov-nikita let's add a unit test for this please.
Ping @stevengill / @audreyso for review / FYI
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/399
One example: [this
repo](https://github.com/Egorand/android-testing-runtime-permissions)'s [main
test
file](https://github.com/Egorand/android-testing-runtime-permissions/blob/master/app
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/399
Well glad that cleared up the CI failures.
Should we add unit, or instrumentation, native tests for this?
Also ping @infil00p for review.
---
If your project is set up
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/389
Hey @infil00p, latest master has a tiny tweak to the appveyor build file
that works around some troubles appveyor is experiencing with one of their VM
images. I think if you rebase
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/397
Hey @matrosov-nikita, rebase w/ latest master, I should have a fix
(workaround) in for appveyor troubles.
---
If your project is set up for it, you can reply to this email and have your
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/399
Hey @macdonst if you rebase w/ latest master, I think we can clear up the
appveyor failure we're seeing in here.
---
If your project is set up for it, you can reply to this email and have
Github user filmaj closed the pull request at:
https://github.com/apache/cordova-android/pull/400
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-android/pull/400
Trying AppVeyor-supplied workaround for current appveyor time out issues
See
http://help.appveyor.com/discussions/problems/7159-builds-timing-out-after-an-hour
You can merge this pull
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/82
I rebased / merged this in. Thanks @janpio !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/227
Ideally this kind of stuff lands across all major platforms in Cordova.
Generally, if something is not doable due to platform-specific
restrictions, we, at the minimum
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/130
Confirmed that this patch fixes the crash. Merged it in.
Thanks for the contribution @SharUpOff! + on your first ever GitHub PR, too
---
If your project is set up
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/130
And @SharUpOff your intuition is confirmed: the logcat logs show that after
pressing the back button in my app after loading it up, Cordova tries to load
about:url
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/130
OK, I've been able to reproduce the behaviour - sort of. In my case, it
wasn't that the my app showed the splashscreen, but that the app crashed while
exiting!
My test
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r129673561
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,173 @@
+
+
+# New Platform Checklist
+
+## Stand-alone scripts
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r129671498
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,173 @@
+
+
+# New Platform Checklist
+
+## Stand-alone scripts
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/130
Ah, great! Thanks for describing that. I will take a look at that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r129181275
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r129180869
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r129105861
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/398
@faziltm please do not issue pull requests to this repo as a means of
asking a question or having someone look at your environment. You are
unnecessarily loading the CI server. I am going
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/397#discussion_r129094172
--- Diff: bin/templates/cordova/lib/prepare.js ---
@@ -214,7 +215,11 @@ function updateProjectAccordingTo (platformConfig,
locations
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/397
Just for the record, here's the full stack trace I get when I try these
steps:
```
~/src
â cordova create testapp com.example.testapp testapp
Warning: using prerelease
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/17
This plugin does not use anything from the ionic ecosystem. Cordova does
not depend on ionic - perhaps the other way around is true (ionic depends on
cordova). I will close
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-file/pull/211#discussion_r128926981
--- Diff: src/ios/CDVLocalFilesystem.m ---
@@ -551,8 +551,13 @@ - (void)copyFileToURL:(CDVFilesystemURL *)destURL
withName:(NSString *)newName f
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/67
I see lots of problems with this PR:
1. The travis build fails, for starters.
2. Why eliminate sauce labs testing? That is a core component of the
end-to-end testing
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128902594
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128902258
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128838089
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128837876
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128833191
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128838640
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128836281
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834498
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128837070
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128837925
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128836475
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128838987
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128833488
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128838263
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128837813
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834387
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128833714
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128839290
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128839772
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834664
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128837509
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128837232
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128836016
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
Github user filmaj commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834741
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
+
+bin
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-test-platform/pull/2
CB-11347: a bit more documentation around platform API
+ links to a few additional discussion PRs.
FYI / please review @purplecabbage @shazron
You can merge this pull request
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/57
Do we absolutely require using the mac image?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/282
The code you link to (step 4 of the guide) doesn't use
cordova-plugin-camera's JS API. It uses:
```
navigator.getUserMedia = navigator.getUserMedia
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/282
@douglasmoraisdev how can I test that this change is needed? Is there a
particular camera API i need to access on API 24+ to see the failure? Just want
to reproduce the failed / fixed
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/396
I'm not sure this is needed as we already do plenty of checking for the
`ANDROID_HOME` environment variable. If you set that env var to the location of
your Android SDK (whether
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/227
Is this supported on any platforms other than iOS?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/109
See the relevant [dev mailing list discussion about integrating
splashscreen into the
platforms](https://lists.apache.org/thread.html
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/150
Alright, I took a look at this again after an extended break and I have
more comments, and want to bring more information to the community about the
future of this plugin
Github user filmaj commented on the issue:
https://github.com/apache/cordova-ios/pull/313
@andreszs I would also recommend toning down your entitlement-based outrage
for a _free_ open source software. There's so much work to do in Cordova. If
this is unbearable for you, please come
Github user filmaj closed the pull request at:
https://github.com/apache/cordova-plugin-file-transfer/pull/185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/393
I think if the PR author rebases w/ latest master, they will find that test
no longer exists / no longer applicable.
I bet it was Travis VM being too slow / our timeout
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-plugin-file-transfer/pull/185
CB-7995: document that `FileTransferError.exception` on iOS is never used
https://issues.apache.org/jira/browse/CB-7995
You can merge this pull request into a Git
Github user filmaj closed the pull request at:
https://github.com/apache/cordova-docs/pull/715
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-docs/pull/715
CB-12735: AllowInlineMediaPlayback preference requires different <vidâ¦
For https://issues.apache.org/jira/browse/CB-12735
As of iOS 10, the attribute name to add to eleme
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/395
You cool with this change @infil00p ? Just making sure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user filmaj opened a pull request:
https://github.com/apache/cordova-android/pull/395
CB-12423: make explicit JDK 1.8 or greater is needed in the README.
Lining it up with
https://cordova.apache.org/docs/en/latest/guide/platforms/android/index.html#installing
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/389
Yes, seriously, because the code interpolates activity name / package name
/ etc. into hard-coded paths!
---
If your project is set up for it, you can reply to this email and have your
Github user filmaj closed the pull request at:
https://github.com/apache/cordova-android/pull/394
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/182
Yes this is an important change.
I'm wondering how we can set up testing for these kinds of issues. Perhaps
that's a wider question about how to test the browser
Github user filmaj commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/225
Sure! No problem.
First you'd need to clone the repository down to your machine, giving you a
local copy to work with. You already have your own fork of the repository
1 - 100 of 461 matches
Mail list logo
