Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/219
Agree with @jcesarmobile, this should have a new JIRA associated with this
issue.
---
-
To unsubscribe, e
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/221
CRAP, this was a typo. @RafaelKr can you re-open this one? I meant to
close #201
---
-
To unsubscribe, e
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/185
Can you create JIRA issue to correspond to this PR? That's one of the
things that is holding up this PR
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/173
Can you add a JIRA issue to this PR? Thanks!
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/172
Please re-do this PR, and please don't change the plugin.xml to be based on
your repository. There are too much history dragged in from the repo to accept
this PR
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/166
Agreed, this does look weird, but should we be hard coding this, or is
there a better solution for this? (i.e. resizing the buttons
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/165
This needs a JIRA issue attached to it. I don't see any conflicts, however.
---
-
To unsubscribe, e-mail
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/159
There's no proposal in the cordova repo, nor is there a JIRA issue
regarding this feature addition. There needs to be these things before we can
add this API change
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/156
Closing this issue, since it should be sending the error as a plugin result
on the Callback instead of sending a random JSON object
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/122
So, is this functionality not working? It would help if there was a JIRA
issue attached to this PR. I don't see XWalk functionality being a huge issue
since XWalk is no longer
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/116
Closing this PR as abandoned, since it's been over a year since @shazron
last checked
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/115
This is an API change and should be discussed on the list, or at the very
least have a JIRA issue attached to it. Also, the conflicts are definitely
going to prevent this from
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/111
This has the following wrong with it:
1. You changed the package.json
2. You don't have a JIRA issue attached to this
3. There are other conflicts with the current
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/99
The code changes in iOS are delaying this. That being said, I don't know
if blindly adding Application URIs in an InAppBrowser is a good idea in this
case
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/88
This still needs to merge cleanly to be added. Please fix all the
conflicts to add this code if you are still interested in adding this PR
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/87
@cjpearson Are you still interested in contributing this? Can you fix the
merge conflicts in this PR? Thanks
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/77
You can't change the name of the plugin. This code is also old and
conflicts with the repo, so this PR will be closed
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/73
This is a Won't Fix because you aren't supposed to be able to change the
URI on the Address Bar of the InAppBrowser. Closing because this is a "Won't
Fix" and becaus
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/62
Closing this PR since it's got too many random commits on it as @clelland
has mentioned earlier
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/399
@filmaj Another being this article
https://medium.com/exploring-android/handling-android-runtime-permissions-in-ui-tests-981f9dc11a4e
---
If your project is set up for it, you can reply
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/399
We should add some instrumentation native tests for this, but I have no
idea how that would work, and would have to do more research into this.
---
If your project is set up for it, you
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/130
Going to about:blank is done as a garbage collection technique before
closing out the WebView entirely so that the memory is freed. There's a
hilarious TODO here saying
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/396
Did you see the fix @purplecabbage did to pull this info from the Windows
registry for Windows users? We're probably going to go with that solution for
Windows because of the whole PATH
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/396
We are going to make Gradle a requirement. Using Android Studio's copy of
Gradle was a stop-gap solution to get builds working again, and we should
really stop doing this.
---
If your
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/310
This appears to have fell by the wayside. Why hasn't this been pulled into
cordova-android?
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/393
This somehow broke the project creation test. Can you figure out what
happened with your PR that caused this to break?
---
If your project is set up for it, you can reply to this email
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/395
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
@filmaj Hard copied paths? SRSLY?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
@filmaj Given how old this branch is, those are the same tests that master
was running until three commits ago.
---
If your project is set up for it, you can reply to this email and have
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
@filmaj So, I should do another merge commit just to get more tests?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
The merge commit that I did was e456175a
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/389
@filmaj Github says otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/391
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/274
THIS IS BRILLIANT! Why is this a closed issue?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/385
@filmaj Yeah, that definitely needs an update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/362
@filmaj Can you look at this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r124071629
--- Diff: bin/lib/create.js ---
@@ -259,41 +273,53 @@ exports.create = function(project_path, config,
options, events
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/384
We're going to keep working on #389, closing this old branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-android/pull/384
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/389
CB-11244: Studio Project Compatibility: Now with merge commit
### Platforms affected
Android
### What does this PR do?
This PR is the new current working PR
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/384#discussion_r123844605
--- Diff: bin/lib/create.js ---
@@ -125,16 +131,24 @@ function writeProjectProperties(projectPath,
target_api) {
fs.writeFileSync(dstPath
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/386
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/387
LGTM, pulling in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user infil00p commented on the issue:
https://github.com/apache/cordova-docs/pull/712
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/384
CB-11244: Studio project cleanup
### Platforms affected
Android
### What does this PR do?
Modernizes Android and makes it so we can do Modern Android Development
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/380
I think this should be discussed on the list. There's upsides and
downsides to this, and it could attract more developers to adopt JDK 7 and
newer Java features.
---
If your project
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/378
I can't cleanly merge this, it looks like it's already in.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/283
This is closed as abandoned. It's sad, because asking for tests shouldn't
cause anything to become abandoned.
---
If your project is set up for it, you can reply to this email and have
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/380
Yeah, I'm not sure this is such a great plan.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
@cjpearson After reading this, I can see this issue appearing even if we do
move the management into cordova-android. This is a tooling issue that we're
going to have to handle
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/374
The PR should not be against the 6.2.x branch, closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/375#discussion_r114163718
--- Diff: framework/src/org/apache/cordova/engine/SystemWebViewEngine.java
---
@@ -326,6 +329,12 @@ public void setPaused(boolean value
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/375#discussion_r114163459
--- Diff: framework/src/org/apache/cordova/engine/SystemWebViewEngine.java
---
@@ -326,6 +329,12 @@ public void setPaused(boolean value
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/62
@filmaj Not sure. I'm not sure what the reporter is trying to do here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-splashscreen/pull/125
@Lazza Which Samsung Devices would have this problem? Would a Samsung
Galaxy S3 to S8 have this?
---
If your project is set up for it, you can reply to this email and have
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-statusbar/pull/77
BTW: I agree with the original author about reflection not being in
Android. I think that adding reflection for compile-time bugs is one of the
worst things ever, like drowning
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/34
@matrosov-nikita Which Samsung devices are affected? All of them? Only the
Samsung Galaxy S3/4/5? If we could get more info on that, we can test for this
and try and make
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/85
Why are you returning no error message when you're sending back the
ILLEGAL_ACCESS error when the permission is denied?
---
If your project is set up for it, you can reply
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
@dblood OK, so what do I need to do to test this thing to verify this
works? Do you have a monitor script available somewhere? Please don't check
off the last box if there's
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/257
I can't find the issue in JIRA. At any rate, I don't think we should pull
this in right now, and I think that we should probably move this into the
android platform source
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-camera/pull/262
Based on what I'm seeing here, it really shouldn't say "Camera cancelled"
because you're selecting an image from the gallery, not taking a picture. They
both should say
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/215
What tests have you added?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user infil00p commented on the issue:
https://github.com/apache/cordova-plugin-device/pull/62
The CordovaWebView object is not actually an Android WebView, so this
actually shouldn't be done.
---
If your project is set up for it, you can reply to this email and have your
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/373
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/691#discussion_r109232693
--- Diff: www/_posts/2017-03-31-android-release.md ---
@@ -0,0 +1,38 @@
+---
+layout: post
+author:
+name: Steve Gill
+url
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/691#discussion_r109232446
--- Diff: www/_posts/2017-03-31-android-release.md ---
@@ -0,0 +1,38 @@
+---
+layout: post
+author:
+name: Steve Gill
+url
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/371
Actually, it did. GitHub is being weird.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-android/pull/371
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/371
Blargh. This didn't actually land into master. Sorry guys, this will be
in the next patch release.
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/371
CB-12574 - Bumping Version
### Platforms affected
### What does this PR do?
### What testing has been done on this change?
### Checklist
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/370
@PierBover Based on the information provided in your issue, it's very
unlikely that your issue was caused by this pull request. The issue is related
to compilation, not Javascript
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/304
1. We need a JIRA for this
2. This has become more interesting since we need to add an Android O
version of this code to handle it better, because the renderer goes away, not
the whole
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/370
@filmaj I don't think it matters since we're overwriting whatever
gradle-wrapper specifies with our own version of Gradle location anyway because
we can't guarantee the version of Gradle
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/337
https://issues.apache.org/jira/browse/CB-12601 is the bug for this new
issue.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/337
It's obviously a bug, and we should probably make sure the pause event
fires before we pause the timers somehow, since it's clear there's a threading
issue. That said, broken apps
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/337
Sorry, but this is more important than the pause event, this stays.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/370
@filmaj The reason we didn't do the same thing for Linux is because:
1. Android Studio could literally be installed anywhere on Linux. (No,
seriously. The instructions
GitHub user infil00p reopened a pull request:
https://github.com/apache/cordova-android/pull/370
CB-12595: Fix Android Studio Detection (may need refactoring)
### Platforms affected
Android
### What does this PR do?
Allows for the installation
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-android/pull/370
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/370
CB-12595: Fix Android Studio Detection (may need refactoring)
### Platforms affected
Android
### What does this PR do?
Allows for the installation
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/368
CB-12574 - Bumping Version
### Platforms affected
Android
### What does this PR do?
Bumps Gradle Version
### What testing has been done on this change
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/366
This doesn't work in Windows, so there's still work to be done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/367
OK, it passes here: https://travis-ci.org/infil00p/cordova-android, so it's
time to tidy this up and merge this in.
---
If your project is set up for it, you can reply to this email
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/367
SoI had to delete a test that no longer will ever pass thanks to the
Android SDK tools, and the other problem we're running into now is that we DO
in fact require Gradle to be higher
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/367
Tested against a Linode box with Android Tools updated to latest and Gradle
Installed: (via
http://exponential.io/blog/2015/03/30/install-gradle-on-ubuntu-linux/)
I have no idea
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/366
@filmaj This needs to at least pass Appveyor before I we should really look
at it. I'm sure it works, but jshint is showing a lot of quote errors.
(Related: I've been burned by this more
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/367#discussion_r105255990
--- Diff: bin/lib/check_reqs.js ---
@@ -78,21 +79,46 @@ module.exports.check_ant = function
Github user infil00p commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/367#discussion_r105252250
--- Diff: bin/lib/check_reqs.js ---
@@ -78,21 +79,46 @@ module.exports.check_ant = function
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/365
@csantanapr The .gitignore prevents us from committing JARs. This PR
didn't even work because we didn't distribute the JAR. We're not allowed to
distribute a JAR.
---
If your project
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/367
Ah, how did that rogue commit get in there. I'll be doing some git
gardening before merging this, FYI
---
If your project is set up for it, you can reply to this email and have your
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/367
CB-12524: Working around Android SDK update by finding Gradle in Android
Studio itself, if that fails, we look for a locally installed Gradle
### Platforms affected
Android
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/365
Closing this PR because we can't distribute JARs, we have to find another
solution. Apologies.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user infil00p closed the pull request at:
https://github.com/apache/cordova-android/pull/365
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/358
@kalliste This test is based on the old test framework. Can you pull down
the latest and take a look at this test and see if you can fit it in here?
https://github.com/apache/cordova
GitHub user infil00p opened a pull request:
https://github.com/apache/cordova-android/pull/365
CB-12524: Fix the GradleBuilder so that it builds the project with an
included Gradle
### Platforms affected
Android
### What does this PR do?
This PR adds
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/357
I'm pretty sure this is already being done on the UI thread.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/310
Looks fine, but we should wait for it all to go in together if possible.
@dpogue You have commit rights, so can you make sure that this gets pulled in
when the parent issue gets resolved
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/304
Do you have a stack trace for this? This is old, but it doesn't conflict,
so I might pull it in, but it would help to see an error report or something
before throwing this over the fence
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/283
What's the status for this? I refactored the unit tests so we can actually
have tests that back this code now, as opposed to before where it wasn't quite
as straight forward.
---
If your
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/358
@kalliste Thanks for submitting the ICLA. Is it possible for you to add a
Unit Test to the new Unit Testing framework for this patch? People have been
complaining about this being
1 - 100 of 368 matches
Mail list logo
