Cordova Slack Digest Wed, 01 Jul 2020 09:42:41 GMT
User count: 3980 https://cordova.slack.com/
Join the conversation at http://slack.cordova.io/
---
Channel random (1)
=
Thu, 25 Jun 2020 16:39:52 GMT
@harish959 says Hey Cordova Community
I wanted to give you a heads up on a
Github user purplecabbage closed the pull request at:
https://github.com/apache/cordova-plugin-battery-status/pull/21
---
-
To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org
For additional commands, e-mail: dev-h
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-js/pull/146
This broke other stuff :(
cordova-browser cannot install cordova-plugin-device-motion fails, for
example.
---
If your project is set up for it, you can reply to this email and have
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r129178197
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r129108993
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128879785
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128877837
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-test-platform/pull/1
Another thing to note is that the tests that are in this repo *could* be
used to verify the platformAPI for anyone attempting to implement it.
---
If your project is set up
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128874756
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128835893
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128835035
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834822
--- Diff: PlatformRequirements.md ---
@@ -0,0 +1,144 @@
+
+# New Platform Checklist
+
+## Stand-alone scripts
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/573#discussion_r127039183
--- Diff: spec/cordova/platform/addHelper.spec.js ---
@@ -16,34 +16,439 @@
*/
/* eslint-env jasmine */
+var path = require
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/130
Localized documentation is not editable.
Please see https://github.com/cordova/cordova-discuss/wiki/Translations
for more details.
Thank you for your
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/144
good call!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/168
https://developer.mozilla.org/en-US/docs/Web/HTTP/Methods/PATCH
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/174
Thoughts here @infil00p ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-file-transfer/pull/177
@feidianbo Can you provide an example url that would have failed and now
will pass, short of writing the whole test.
---
If your project is set up for it, you can reply
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-android/pull/386#discussion_r124902965
--- Diff: bin/templates/cordova/Api.js ---
@@ -112,16 +110,13 @@ Api.createPlatform = function (destination, config,
options, events
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/571
Merged, closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user purplecabbage closed the pull request at:
https://github.com/apache/cordova-lib/pull/571
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-lib/pull/571
CB-11980 Update readme to reflect new repos
### Platforms affected
node, text change only
### What does this PR do?
updates readme
### What testing has been done
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-ios/pull/323
This does not appear to run against node 4.x on Travis CI
```
$ node --version
v6.9.1
```
---
If your project is set up for it, you can reply to this email and have
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-ios/pull/323
CB-12960 Run tests on node 4.x and 6.x
### Platforms affected
This one
### What does this PR do?
Runs tests against node 4.x and 6.x
### What testing has been
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-android/pull/391
Yeah that might be the same issue with iOS ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-android/pull/391
Yeah, iOS doesn't even care ...
https://github.com/apache/cordova-ios/blob/master/.travis.yml
Windows does 4+6 ( without `nvm` )
https://github.com/apache/cordova-windows
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r124158440
--- Diff: bin/template/www/cordova-sw.js ---
@@ -0,0 +1,23 @@
+
+// Note, these will be updated automatically at build time
+var
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r124158393
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
"loca
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r124158333
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
"loca
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-browser/pull/36
CB-12804 Fixes some simple details - manifest.json
### Platforms affected
browser
### What does this PR do?
addresses issues raised with pr #32
### What
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r124157183
--- Diff: cordova-js-src/confighelper.js ---
@@ -61,14 +61,9 @@ function readConfig(success, error
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-browser/pull/32#discussion_r124157156
--- Diff: bin/template/cordova/Api.js ---
@@ -113,52 +110,135 @@ Api.prototype.getPlatformInfo = function () {
"loca
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-browser/pull/35
CB-11181 add default favicon
### Platforms affected
Browser
### What does this PR do?
adds default favicon, that 'should' be overwritten by apps targeting
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-browser/pull/34
CB-11710 Add missing 'clean.bat' file
### Platforms affected
browser ( when run on windows )
### What does this PR do?
adds missing clean.bat file
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-battery-status/pull/55
Awesome!
Is the next step to just copy this to the other plugin repos?
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-browser/pull/33
CB-11711 clean should destroy platforms/browser/www folder contents
### Platforms affected
browser
### What does this PR do?
removes www/ folder during clean
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-geolocation/pull/37
Sorry for not seeing this sooner, and thanks for contributing.
We use Crowdin, a translation and localization management platform to
collaborate amongst translators
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/567#discussion_r123380130
--- Diff: spec-cordova/prepare.spec.js ---
@@ -17,175 +17,265 @@
under the License.
*/
-var shell = require('shelljs
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-android/pull/387
CB-12605 In Windows get Android studio path from the registry
### Platforms affected
Android on windows
### What does this PR do?
Allows installs of Android Studio
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/516
cordova-serve now lives in it's own repo at
github.com/apache/cordova-serve
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-cli/pull/255
Ima close this soon.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-cli/pull/281
this needs a refactor with recent changes
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-cli/pull/283
That is correct!
The cordova-lib changes are already on master, so together they are broken
without these changes.
---
If your project is set up for it, you can reply to this email
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-cli/pull/283
CB-12901 Cli Refactor
### What does this PR do?
- fixed failing tests.
- adjusted tests to call cordova instead of cordova.raw
- added tests to compare cordova.raw
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-browser/pull/31
This needs to be addressed in the cordova-serve repo if it is an issue.
Closing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/708
Nope, it seems there are some mixed up deletions ) from a quick glance.
This is the data that shows up on
https://cordova.apache.org/docs/en/latest/guide/support/index.html right
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/562
This all looks great to me, good work.
I would like to move forward with this asap as it is big, and affects a lot
of different areas.
Let's keep our merge conflict exposure low
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/562#discussion_r122330032
--- Diff: src/util/alias.js ---
@@ -0,0 +1,27 @@
+/**
+Licensed to the Apache Software Foundation (ASF) under one
+or more
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-browser/pull/32
Cb 12804
### Platforms affected
cordova-browser
### What does this PR do?
adds manifest.json support
### What testing has been done on this change?
added
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-device-orientation/pull/36
lgtm
When we publish it next, we should also deprecate it in npm land.
https://docs.npmjs.com/cli/deprecate
---
If your project is set up for it, you can
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-device-motion/pull/53
lgtm
When we publish it next, we should also deprecate it in npm land.
https://docs.npmjs.com/cli/deprecate
---
If your project is set up for it, you can reply
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-inappbrowser/pull/99
Attn: @shazron @infil00p
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/558
+1, let's merge this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-browser/pull/25
I like this, and thank you, however, I am planning on removing zip
functionality.
I believe zipping was only added because someone decided that `build`
needed some sort of output
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-browser/pull/2
browser platform uses cordova-serve now. closing.
Please send a pr to cordova
https://github.com/apache/cordova-lib/tree/master/cordova-serve if this is
still relevant
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-browser/pull/28
This pr is ready for review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113560349
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113543204
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/699
ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-docs/pull/699#discussion_r113523749
--- Diff: www/_posts/2017-04-21-cordova-7.md ---
@@ -0,0 +1,46 @@
+---
+layout: post
+author:
+name: Audrey So
+url
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
It is always nice to have, but not specifically required; sending a pr is
proof of the intent to contribute.
In this case the graphics are really just resized
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-media-capture/pull/76
they are both device specific, and cordova specific
I see these as something that an app developer should be providing
themselves, unfortunately there is not an API
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-dialogs/pull/30
No, @ktran13, it was not.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
cleaned up a few merge issues, this is now in master, thanks @cnspaha
Next the plugin will need to go thru the typical Apache vote process before
being pushed
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
there is nothing more that @ego7repo can do.
I am reviewing this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/548
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-windows/pull/80
http://cordova.apache.org/docs/en/6.x/guide/cli/index.html#using-merges-to-customize-each-platform
---
If your project is set up for it, you can reply to this email and have your
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-lib/pull/516
This is interesting, is it possible in other brower targets?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-lib/pull/538#discussion_r112554925
--- Diff:
cordova-lib/spec-cordova/fixtures/platforms/cordova-browser/bin/lib/create.js
---
@@ -39,14 +39,14 @@ module.exports.createProject
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-windows/pull/80
Sorry Peter,
You are about 2 years too late. What is the goal you are trying to achieve?
It is difficult to use different UI frameworks for different platforms ...
although
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-browser/pull/28
I'll be doing more work on this branch, I just wanted it to be out in the
open.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-browser/pull/28
CB-12527
### Platforms affected
Browser
### What does this PR do?
Adds platformAPI, and removes need for polyfil
### What testing has been done
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-lib/pull/541
Exit with exitCode:1 if a plugin could not be restored from config.xml
### Platforms affected
lib
### What does this PR do?
see description
### What
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-lib/pull/538
Emit platformAPI loading error, remove GradleBuilder and Browser creaâ¦
â¦te console logs
### Platforms affected
### What does this PR do
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-windows/pull/230
CB-12617 Removed node 0.x
### Platforms affected
### What does this PR do?
### What testing has been done on this change
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-windows/pull/229
Allow build when using --bundle and multiple architectures. This closâ¦
â¦es #175
### Platforms affected
### What does this PR do
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/688
This pr was a replacement for #402 which I closed prematurely.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-docs/pull/688
Remove misleading reference to "publisherId" cause it is ignored
The only way to override the `Publisher` value in the generated
`AppxManifest.xml` is to provide a cust
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/402
No, I closed it. Sorry, I didn't think it was still valid.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/402
One commit, a merge and a close ... unrelated.
Much like 25485819612937251bb521a9b68f73cae54065c3
---
If your project is set up for it, you can reply to this email and have your
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/212
closing this now very old pr. Thanks for contributing, if this is still
valid and needed, please rebase and resend.
---
If your project is set up for it, you can reply to this email
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/259
closing, ... please resend/rebase if this is still valid.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/402
Is this still an issue? Did you find a suitable solution @pke ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/443
Pretty sure this has already been said in Russian ...
Thanks for your contribution. The file you made the change in is actually a
generated file that comes via a crowdin translation
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/611
look good, merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/634
Also, the file you modified is build generated from crowdin.
Plugin documentation lives with the plugins.
---
If your project is set up for it, you can reply to this email and have
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/669
Thanks for your contribution @p-w
The file you made the change in is actually a generated file that comes via
a crowdin translation, please have a look at README.md for details
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-docs/pull/664
closing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-docs/pull/687
Documented that some files are auto-gen from other sources
### Platforms affected
### What does this PR do?
### What testing has been done
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11
If this is still valid, please rebase. Otherwise it will be closed.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-android/pull/369
LGTM!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/13
[windows] Fix failing tests, added Promise if it is not defined 8.1
### Platforms affected
### What does this PR do?
### What
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/12#discussion_r105305926
--- Diff: www/screenorientation.js ---
@@ -18,83 +18,127 @@
* under the License.
*
*/
+var
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/12#discussion_r105282708
--- Diff: demo/config.xml ---
@@ -1,14 +1,31 @@
+/*
--- End diff --
This is suddenly NOT a valid XML file
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-screen-orientation/pull/11#discussion_r105280210
--- Diff: www/screenorientation.js ---
@@ -54,7 +54,7 @@
screenObject.lock = function(orientation
GitHub user purplecabbage opened a pull request:
https://github.com/apache/cordova-lib/pull/524
CB-12528 use fs instead of our own existsSync
### Platforms affected
Lib
### What does this PR do?
Removes unneeded API
### What testing has been
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-cli/pull/267
This PR will need to follow #270 and will need to be rebased, and have a
conflict fix.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user purplecabbage commented on a diff in the pull request:
https://github.com/apache/cordova-cli/pull/267#discussion_r103999595
--- Diff: src/cli.js ---
@@ -160,7 +183,7 @@ module.exports = function (inputArgs, cb) {
};
function getSubCommand(args, cmd
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-cli/pull/255
This now has conflicts, and even more when considered with other prs.
Should I look to reimplement this cleanly?
---
If your project is set up for it, you can reply to this email
Github user purplecabbage commented on the issue:
https://github.com/apache/cordova-cli/pull/268
Ship it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
1 - 100 of 881 matches
Mail list logo
