[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...

2017-06-26 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/568 Thanks for the feedback @stevengill, good point. I've just removed `npm run ci` and updated travis and appveyor to just run `npm test` - just like a developer would on their local machine. ---

[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...

2017-06-26 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/568 looks good to me. Only thing I would add is updating travis and appveyor as well. They run the integration tests as a separate task currently. --- If your project is set up for it, you can

[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...

2017-06-23 Thread imhotep
Github user imhotep commented on the issue: https://github.com/apache/cordova-lib/pull/568 I support this change. I believe it will make writing tests for new features easier if each source file has a matching spec file and all source/spec folders are mirrored. --- If your project

[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...

2017-06-22 Thread codecov-io
Github user codecov-io commented on the issue: https://github.com/apache/cordova-lib/pull/568 # [Codecov](https://codecov.io/gh/apache/cordova-lib/pull/568?src=pr=h1) Report > Merging [#568](https://codecov.io/gh/apache/cordova-lib/pull/568?src=pr=desc) into