Re: cordova-lib proposal on test directory reorganization

2017-06-27 Thread kerrishotts
Everything looked good from my once over -- thanks for the work you're putting in to this! Sent from my phone. ___ Kerri > On Jun 27, 2017, at 12:44, Filip Maj wrote: > > I'm planning on merging this in later today if there are no more >

Re: cordova-lib proposal on test directory reorganization

2017-06-27 Thread Filip Maj
I'm planning on merging this in later today if there are no more comments. So far only positive ones! On Mon, Jun 26, 2017 at 7:45 AM, Filip Maj wrote: > Still looking for a bit more feedback, please take a look if you have > time! Thanks Anis for your feedback :) > > Don't

Re: cordova-lib proposal on test directory reorganization

2017-06-26 Thread Filip Maj
Still looking for a bit more feedback, please take a look if you have time! Thanks Anis for your feedback :) Don't worry about the diff / changeset (~1900 files changed!), the PR description, I think, summarizes the changes well enough. Almost all the changes are renaming files and tweaking the

cordova-lib proposal on test directory reorganization

2017-06-22 Thread Filip Maj
Proposal up in PR form here: https://github.com/apache/cordova-lib/pull/568 tl;dr consolidating `spec-cordova/` and `spec-plugman` directories into one, setting up to for one-unit-test-spec.js per source-module.js file. Looking for eyes and feedback! If you have any, please drop comments in the