[GitHub] [cordova-test-platform] breautek merged pull request #19: chore: package-lock

2020-11-29 Thread GitBox
breautek merged pull request #19: URL: https://github.com/apache/cordova-test-platform/pull/19 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cordova-test-platform] breautek opened a new pull request #19: chore: package-lock

2020-11-27 Thread GitBox
breautek opened a new pull request #19: URL: https://github.com/apache/cordova-test-platform/pull/19 ### Platforms affected ### Motivation and Context Progresses https://github.com/apache/cordova/issues/4 ### Description

[GitHub] [cordova-test-platform] raphinesse merged pull request #17: pkg fixup

2020-10-04 Thread GitBox
raphinesse merged pull request #17: URL: https://github.com/apache/cordova-test-platform/pull/17 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cordova-test-platform] raphinesse commented on a change in pull request #17: pkg fixup

2020-10-03 Thread GitBox
raphinesse commented on a change in pull request #17: URL: https://github.com/apache/cordova-test-platform/pull/17#discussion_r499161520 ## File path: package.json ## @@ -18,17 +20,6 @@ "author": "Apache Software Foundation", "license": &

[GitHub] [cordova-test-platform] timbru31 merged pull request #18: chore(asf): update git notification settings

2020-10-03 Thread GitBox
timbru31 merged pull request #18: URL: https://github.com/apache/cordova-test-platform/pull/18 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cordova-test-platform] timbru31 opened a new pull request #18: chore(asf): update git notification settings

2020-10-03 Thread GitBox
timbru31 opened a new pull request #18: URL: https://github.com/apache/cordova-test-platform/pull/18 ### Platforms affected ### Motivation and Context ### Description ### Testing ### Checklist

[GitHub] [cordova-test-platform] erisu commented on a change in pull request #17: pkg fixup

2020-10-03 Thread GitBox
erisu commented on a change in pull request #17: URL: https://github.com/apache/cordova-test-platform/pull/17#discussion_r499159095 ## File path: package.json ## @@ -18,17 +20,6 @@ "author": "Apache Software Foundation", "license": &

[GitHub] [cordova-test-platform] erisu commented on a change in pull request #17: pkg fixup

2020-10-03 Thread GitBox
erisu commented on a change in pull request #17: URL: https://github.com/apache/cordova-test-platform/pull/17#discussion_r499158727 ## File path: package.json ## @@ -18,17 +20,6 @@ "author": "Apache Software Foundation", "license": &

[GitHub] [cordova-test-platform] raphinesse opened a new pull request #17: pkg fixup

2020-10-03 Thread GitBox
raphinesse opened a new pull request #17: URL: https://github.com/apache/cordova-test-platform/pull/17 - chore(pkg): remove field "maintainers" - fix(pkg): fix declaration for binary "create"

[GitHub] [cordova-test-platform] raphinesse merged pull request #16: chore: clean up package.json

2020-10-02 Thread GitBox
raphinesse merged pull request #16: URL: https://github.com/apache/cordova-test-platform/pull/16 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [cordova-test-platform] raphinesse opened a new pull request #16: chore: clean up package.json

2020-10-02 Thread GitBox
raphinesse opened a new pull request #16: URL: https://github.com/apache/cordova-test-platform/pull/16 See https://github.com/apache/cordova/issues/55 This is an automated message from the Apache Git Service. To respond

[GitHub] [cordova-eslint] raphinesse merged pull request #5: Test all exported configurations

2019-11-07 Thread GitBox
raphinesse merged pull request #5: Test all exported configurations URL: https://github.com/apache/cordova-eslint/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [GitHub] janpio opened a new issue #2: TEst

2018-08-23 Thread Jan Piotrowski
Seems apache/cordova is misconfiged, I created an INFRA issue to change the notification email from dev@ to commits@: https://issues.apache.org/jira/browse/INFRA-16945 Am Do., 23. Aug. 2018 um 11:11 Uhr schrieb GitBox : > > janpio opened a new issue #2: TEst > URL: https://github.c

[GitHub] janpio closed issue #2: TEst

2018-08-23 Thread GitBox
janpio closed issue #2: TEst URL: https://github.com/apache/cordova/issues/2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go

[GitHub] janpio commented on issue #2: TEst

2018-08-23 Thread GitBox
janpio commented on issue #2: TEst URL: https://github.com/apache/cordova/issues/2#issuecomment-415347724 Manually closing this now. This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] janpio opened a new issue #2: TEst

2018-08-23 Thread GitBox
janpio opened a new issue #2: TEst URL: https://github.com/apache/cordova/issues/2 _From @janpio on August 23, 2018 9:11_ test _Copied from original issue: apache/cordova-discuss#109_ This is an automated

[GitHub] cordova-lib issue #601: CB-13485: Test with Node8

2017-10-23 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/601 yeah i ran into this last time i tried to do it. npm 5 doesn't handle `npm link` properly. Doesn't work with our current link all the cordova deps strategy ---

[GitHub] cordova-lib issue #601: CB-13485: Test with Node8

2017-10-23 Thread akdor1154
Github user akdor1154 commented on the issue: https://github.com/apache/cordova-lib/pull/601 Ah, don't we love npm 5? I didn't expect this to break so early, I'll look tomorrow. --- - To unsubscribe, e-mail:

[GitHub] cordova-lib pull request #601: CB-13485: Test with Node8

2017-10-23 Thread akdor1154
GitHub user akdor1154 opened a pull request: https://github.com/apache/cordova-lib/pull/601 CB-13485: Test with Node8 ### What does this PR do? Enables testing on Node 8 with Travis, and fixes the failing tests (no behaviour changes seem necessary). ### What testing

[GitHub] cordova-lib pull request #594: CB-13288 : updated index.js and test to fix c...

2017-09-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-lib/pull/594 --- - To unsubscribe, e-mail: dev-unsubscr...@cordova.apache.org For additional commands, e-mail: dev-h...@cordova.apache.org

[GitHub] cordova-lib pull request #594: CB-13288 : updated index.js and test to fix c...

2017-09-15 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-lib/pull/594 CB-13288 : updated index.js and test to fix cordova plugin search ### Platforms affected ### What does this PR do? Updated index.js and test to fix cordova

[GitHub] cordova-js pull request #148: CB-13232: added test for cordova's unique loca...

2017-08-31 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-js/pull/148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] cordova-js issue #148: CB-13232: added test for cordova's unquie local style...

2017-08-31 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-js/pull/148 Ah, this test clarifies the style _so much better_. I know we've thrown the idea around to change this, but until we do, I think it may be worth documenting this. The README, in general

[GitHub] cordova-js pull request #148: CB-13232: added test for cordova's unquie loca...

2017-08-30 Thread stevengill
GitHub user stevengill opened a pull request: https://github.com/apache/cordova-js/pull/148 CB-13232: added test for cordova's unquie local style require This is in response to https://github.com/apache/cordova-js/pull/146 You can merge this pull request into a Git repository

[GitHub] shazron closed pull request #40: Test again, the sequel. No JIRA prefix.

2017-08-02 Thread git
shazron closed pull request #40: Test again, the sequel. No JIRA prefix. URL: https://github.com/apache/cordova-browser/pull/40 This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] shazron closed pull request #39: CB-123 - Test again

2017-08-02 Thread git
shazron closed pull request #39: CB-123 - Test again URL: https://github.com/apache/cordova-browser/pull/39 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] shazron commented on issue #39: CB-123 - Test again

2017-08-02 Thread git
shazron commented on issue #39: CB-123 - Test again URL: https://github.com/apache/cordova-browser/pull/39#issuecomment-319768397 Test comment (with prefix) This is an automated message from the Apache Git Service

[GitHub] shazron commented on issue #40: Test again, the sequel. No JIRA prefix.

2017-08-02 Thread git
shazron commented on issue #40: Test again, the sequel. No JIRA prefix. URL: https://github.com/apache/cordova-browser/pull/40#issuecomment-319768329 Test comment (no prefix) This is an automated message from the Apache Git

[GitHub] cordova-plugin-test-framework pull request #26: CB-12895 : replaced jshint w...

2017-08-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-plugin-test-framework/pull/26 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] cordova-plugin-test-framework issue #26: CB-12895 : replaced jshint with esl...

2017-08-01 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/26 Yep! LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] cordova-plugin-test-framework issue #26: CB-12895 : replaced jshint with esl...

2017-08-01 Thread audreyso
Github user audreyso commented on the issue: https://github.com/apache/cordova-plugin-test-framework/pull/26 Thanks for the review! Okay to merge @filmaj? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] cordova-plugin-test-framework pull request #26: CB-12895 : replaced jshint w...

2017-08-01 Thread audreyso
GitHub user audreyso opened a pull request: https://github.com/apache/cordova-plugin-test-framework/pull/26 CB-12895 : replaced jshint with eslint ### Platforms affected ### What does this PR do? Replaced jshint with eslint ### What testing

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-26 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r129673561 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,173 @@ + + +# New Platform Checklist + +## Stand-alone scripts

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-26 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r129671498 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,173 @@ + + +# New Platform Checklist + +## Stand-alone scripts

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-24 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r129181275 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-24 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r129180869 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-24 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r129178197 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-24 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r129108993 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-24 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r129106466 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-24 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r129105861 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-24 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r129104787 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-24 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r129092432 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-22 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128902594 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-22 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128902258 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128880654 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128880058 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128879785 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128879376 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128878157 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128877837 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128877652 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128876824 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform issue #1: Doc requirements for platform api expectatio...

2017-07-21 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-test-platform/pull/1 Another thing to note is that the tests that are in this repo *could* be used to verify the platformAPI for anyone attempting to implement it. --- If your project is set up

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128874756 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128869649 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread stevengill
Github user stevengill commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128869395 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128838089 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128837876 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128833191 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128838640 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128836281 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834498 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128837070 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128837925 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128836475 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128838987 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128833488 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128838263 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128837813 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834387 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128833714 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128839290 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128839772 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834664 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128837509 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128837232 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128836016 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread filmaj
Github user filmaj commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834741 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128835893 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128835035 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread purplecabbage
Github user purplecabbage commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834822 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834432 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #1: Doc requirements for platform api exp...

2017-07-21 Thread audreyso
Github user audreyso commented on a diff in the pull request: https://github.com/apache/cordova-test-platform/pull/1#discussion_r128834249 --- Diff: PlatformRequirements.md --- @@ -0,0 +1,144 @@ + +# New Platform Checklist + +## Stand-alone scripts + +bin

[GitHub] cordova-test-platform pull request #2: CB-11347: a bit more documentation ar...

2017-07-21 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-test-platform/pull/2 CB-11347: a bit more documentation around platform API + links to a few additional discussion PRs. FYI / please review @purplecabbage @shazron You can merge this pull request

[GitHub] cordova-android pull request #391: CB-12950: E2E test tweaks + Appveyor now ...

2017-07-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/cordova-android/pull/391 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-07-10 Thread infil00p
Github user infil00p commented on the issue: https://github.com/apache/cordova-android/pull/391 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-07-04 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-android/pull/391 Here's a JIRA issue: https://issues.apache.org/jira/browse/CB-12960 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-06-28 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/391 @alsorokin perfect! Yeah no worries, I can do it too. How about let's file an issue for it first and then go from there? As for this particular PR, today I will attempt to start an

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-06-28 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-android/pull/391 As I've already done this for plugins and have the knowledge, I can do the same thing for iOS and Android if you like, after this is merged. --- If your project is set up for it, you can

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-06-28 Thread alsorokin
Github user alsorokin commented on the issue: https://github.com/apache/cordova-android/pull/391 Take a look at this: http://austinpray.com/ops/2015/09/20/change-travis-node-version.html So, we're basically download nvm and pass it a node version stored in the environment

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-06-27 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-android/pull/391 Yeah that might be the same issue with iOS ... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-06-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/391 Might be tough as we tell travis to use the Android image preset via `language: android` so it comes pre-installed with some bits from the Android SDK... --- If your project is set up for

[GitHub] cordova-lib pull request #568: Reorganized unit test directory structure + u...

2017-06-27 Thread filmaj
Github user filmaj closed the pull request at: https://github.com/apache/cordova-lib/pull/568 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + Appveyor now runs E2...

2017-06-27 Thread purplecabbage
Github user purplecabbage commented on the issue: https://github.com/apache/cordova-android/pull/391 Yeah, iOS doesn't even care ... https://github.com/apache/cordova-ios/blob/master/.travis.yml Windows does 4+6 ( without `nvm` )

Re: cordova-lib proposal on test directory reorganization

2017-06-27 Thread kerrishotts
PM, Filip Maj <maj@gmail.com> wrote: >>> Proposal up in PR form here: https://github.com/apache/cordova-lib/pull/568 >>> >>> tl;dr consolidating `spec-cordova/` and `spec-plugman` directories >>> into one, setting up to f

[GitHub] cordova-android issue #391: CB-12950: E2E test tweaks + moar testing on Wind...

2017-06-27 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-android/pull/391 I just realized... on Windows, we run against both node v4 and node v6. On travis, only against node v6. We should make this consistent. Which one? The `package.json` file _does_ specify as

[GitHub] cordova-android pull request #391: WIP: E2E test tweaks + moar testing on Wi...

2017-06-27 Thread filmaj
GitHub user filmaj opened a pull request: https://github.com/apache/cordova-android/pull/391 WIP: E2E test tweaks + moar testing on Windows Please don't merge! Testing how appveyor behaves when we tell it to install the latest Android SDK, and run the e2e tests. FINGERS

Re: cordova-lib proposal on test directory reorganization

2017-06-27 Thread Filip Maj
t; wrote: >> Proposal up in PR form here: https://github.com/apache/cordova-lib/pull/568 >> >> tl;dr consolidating `spec-cordova/` and `spec-plugman` directories >> into one, setting up to for one-unit-test-spec.js per source-module.js >> file. >> >> Lo

[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...

2017-06-26 Thread filmaj
Github user filmaj commented on the issue: https://github.com/apache/cordova-lib/pull/568 Thanks for the feedback @stevengill, good point. I've just removed `npm run ci` and updated travis and appveyor to just run `npm test` - just like a developer would on their local machine

[GitHub] cordova-lib issue #568: Reorganized unit test directory structure + updated ...

2017-06-26 Thread stevengill
Github user stevengill commented on the issue: https://github.com/apache/cordova-lib/pull/568 looks good to me. Only thing I would add is updating travis and appveyor as well. They run the integration tests as a separate task currently. --- If your project is set up for it, you can

  1   2   3   4   5   6   7   8   >