[jira] Commented: (COUCHDB-549) include_docs=true doesn't honour conflicts=true

2011-03-08 Thread Filipe Manana (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003934#comment-13003934 ] Filipe Manana commented on COUCHDB-549: --- Hi patrick, I'm +1 for this ticket. The

[jira] Commented: (COUCHDB-549) include_docs=true doesn't honour conflicts=true

2011-03-08 Thread Adam Kocoloski (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-549?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13003957#comment-13003957 ] Adam Kocoloski commented on COUCHDB-549: I'm +1 on both directions outlined by

[jira] Commented: (COUCHDB-1084) Remove unnecessary btree lookup inside couch_db_updater

2011-03-08 Thread Damien Katz (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004089#comment-13004089 ] Damien Katz commented on COUCHDB-1084: -- Thanks for the feedback on the code style,

[jira] Commented: (COUCHDB-1084) Remove unnecessary btree lookup inside couch_db_updater

2011-03-08 Thread Jan Lehnardt (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004131#comment-13004131 ] Jan Lehnardt commented on COUCHDB-1084: --- Relaximation r/w test, on My MacBook

[jira] Created: (COUCHDB-1085) Make the replication manager restart replications that end up in an error state

2011-03-08 Thread Filipe Manana (JIRA)
Make the replication manager restart replications that end up in an error state --- Key: COUCHDB-1085 URL: https://issues.apache.org/jira/browse/COUCHDB-1085 Project: CouchDB

[jira] Updated: (COUCHDB-1085) Make the replication manager restart replications that end up in an error state

2011-03-08 Thread Filipe Manana (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Filipe Manana updated COUCHDB-1085: --- Attachment: COUCHDB-1085.patch Make the replication manager restart replications that end

[jira] Commented: (COUCHDB-1084) Remove unnecessary btree lookup inside couch_db_updater

2011-03-08 Thread Filipe Manana (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004144#comment-13004144 ] Filipe Manana commented on COUCHDB-1084: E P I C !! :) Remove unnecessary

btree refactoring

2011-03-08 Thread Randall Leeds
When I start hacking on COUCHDB-1076 a couple nights ago I found that the cleanest way I could see for allowing kp_nodes to be skipped during traversal was for the fold function to couch_btree:foldl to be arity 4, with kp_node | kv_node as the first argument. Evaluating that function for every

Re: btree refactoring

2011-03-08 Thread Paul Davis
On Tue, Mar 8, 2011 at 2:28 PM, Randall Leeds randall.le...@gmail.com wrote: When I start hacking on COUCHDB-1076 a couple nights ago I found that the cleanest way I could see for allowing kp_nodes to be skipped during traversal was for the fold function to couch_btree:foldl to be arity 4, with

Re: btree refactoring

2011-03-08 Thread Robert Dionne
+1 I'd definitely have a hard look at it. I'm wondering if it makes sense to first revisit davisp's refactoring. Not the second one but the first one he recently did which was just a clean up and simplification of the code. It may have broken something but if I recall it was more readable

[jira] Commented: (COUCHDB-455) get_result,infinity error when replicating an empty database

2011-03-08 Thread Lukasz Mielicki (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004216#comment-13004216 ] Lukasz Mielicki commented on COUCHDB-455: - Hi, I'm seeing something similar

Re: btree refactoring

2011-03-08 Thread Randall Leeds
Thanks for the feedback, you too. I'll take a hard look at what Paul's done and I'll start in and see if it makes sense. I'm aiming for less eye bleed, not more. And as far as not changing existing usage... there's not too many places where query_modify or add_remove are called. And for the fold

[jira] Commented: (COUCHDB-1084) Remove unnecessary btree lookup inside couch_db_updater

2011-03-08 Thread Jan Lehnardt (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004320#comment-13004320 ] Jan Lehnardt commented on COUCHDB-1084: --- Relaximation r/w test on a Mac Mini with

[jira] Commented: (COUCHDB-1084) Remove unnecessary btree lookup inside couch_db_updater

2011-03-08 Thread Adam Kocoloski (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004331#comment-13004331 ] Adam Kocoloski commented on COUCHDB-1084: - Doesn't that graph show a 10-15% drop

[jira] Commented: (COUCHDB-1084) Remove unnecessary btree lookup inside couch_db_updater

2011-03-08 Thread Randall Leeds (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004362#comment-13004362 ] Randall Leeds commented on COUCHDB-1084: The difference between the SSD and

[jira] Commented: (COUCHDB-1084) Remove unnecessary btree lookup inside couch_db_updater

2011-03-08 Thread Jan Lehnardt (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004366#comment-13004366 ] Jan Lehnardt commented on COUCHDB-1084: --- Definitely more testing :) Randal, if

[jira] Commented: (COUCHDB-1084) Remove unnecessary btree lookup inside couch_db_updater

2011-03-08 Thread Damien Katz (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13004376#comment-13004376 ] Damien Katz commented on COUCHDB-1084: -- This isn't the first time i've seen weird