[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69846759 Couple of small aesthetic things. 1. When editing the View and clicking the `Edit Index` tab to shrink it, it's smooth up until the last moment when ther

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69846358 Small thing. An extra space is getting prepended to the map function each time it's saved. To reproduce: 1. Select any database. 2. All Design Docs -> Ne

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread benkeen
Github user benkeen commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22905830 --- Diff: app/addons/documents/actions.js --- @@ -0,0 +1,164 @@ +// Licensed under the Apache License, Version 2.0 (the "License"); you may not

[GitHub] couchdb-fauxton pull request: Moved momentjs to js/libs folder

2015-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] couchdb-fauxton pull request: Moved momentjs to js/libs folder

2015-01-13 Thread ocelotpotpie
Github user ocelotpotpie commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/226#issuecomment-69821776 +1 because correct paths are nice. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your p

[GitHub] couchdb-fauxton pull request: Moved momentjs to js/libs folder

2015-01-13 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/226#issuecomment-69821814 haha thanks man :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Moved momentjs to js/libs folder

2015-01-13 Thread benkeen
GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/226 Moved momentjs to js/libs folder I placed the moment.js lib in the wrong location in an earlier commit. This puts it into the libs folder to be with its friends. You can merge this pull

[jira] [Closed] (COUCHDB-2507) Update Doc Editor page to make better use of space

2015-01-13 Thread Ben Keen (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Keen closed COUCHDB-2507. - > Update Doc Editor page to make better use of space > -- >

[jira] [Resolved] (COUCHDB-2507) Update Doc Editor page to make better use of space

2015-01-13 Thread Ben Keen (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Keen resolved COUCHDB-2507. --- Resolution: Fixed > Update Doc Editor page to make better use of space > ---

[GitHub] couchdb-fauxton pull request: Update full page document editor

2015-01-13 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/204#issuecomment-69814231 Thanks, @michellephung :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] couchdb-fauxton pull request: Update full page document editor

2015-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/204 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[jira] [Commented] (COUCHDB-2507) Update Doc Editor page to make better use of space

2015-01-13 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275885#comment-14275885 ] ASF subversion and git services commented on COUCHDB-2507: -- Com

[GitHub] couchdb-fauxton pull request: Update full page document editor

2015-01-13 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/204#issuecomment-69813944 nice job on this btw. :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d

[GitHub] couchdb-fauxton pull request: Update full page document editor

2015-01-13 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/204#issuecomment-69813589 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[jira] [Updated] (COUCHDB-2541) couchdbctl

2015-01-13 Thread Alexander Shorin (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shorin updated COUCHDB-2541: -- Issue Type: New Feature (was: Improvement) > couchdbctl > -- > >

[jira] [Created] (COUCHDB-2541) couchdbctl

2015-01-13 Thread Alexander Shorin (JIRA)
Alexander Shorin created COUCHDB-2541: - Summary: couchdbctl Key: COUCHDB-2541 URL: https://issues.apache.org/jira/browse/COUCHDB-2541 Project: CouchDB Issue Type: Improvement Securi

[GitHub] couchdb pull request: Goodbye, etap!

2015-01-13 Thread chewbranca
Github user chewbranca commented on the pull request: https://github.com/apache/couchdb/pull/296#issuecomment-69798116 @kxepal woohoo! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[jira] [Closed] (COUCHDB-1963) Move from etap to eunit

2015-01-13 Thread Joan Touzet (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joan Touzet closed COUCHDB-1963. > Move from etap to eunit > --- > > Key: COUCHDB-1963 >

[PROPOSAL] CouchDB tests organization

2015-01-13 Thread Alexander Shorin
Hi everyone! I would like to a bit change our tests layout. Currently, we have roughly the following picture: - couchdb: javascript-based integration tests - couchdb-couch: eunit both functional and integration tests - couchdb-couch-replicator: eunit both functional and integration tests - couchdb

[GitHub] couchdb-fauxton pull request: Update full page document editor

2015-01-13 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/204#issuecomment-69786845 Thanks for everyone's input! The colours have been adjusted a little; the header darkened (grey not white) and the highlight row darkened for increased emphasis,

[jira] [Resolved] (COUCHDB-1963) Move from etap to eunit

2015-01-13 Thread Alexander Shorin (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1963?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shorin resolved COUCHDB-1963. --- Resolution: Fixed Fix Version/s: 2.0.0 > Move from etap to eunit > --

[GitHub] couchdb pull request: Goodbye, etap!

2015-01-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb/pull/296 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22876420 --- Diff: app/addons/documents/actions.js --- @@ -0,0 +1,164 @@ +// Licensed under the Apache License, Version 2.0 (the "License"); you may

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22876340 --- Diff: app/addons/documents/actions.js --- @@ -0,0 +1,164 @@ +// Licensed under the Apache License, Version 2.0 (the "License"); you may

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22875951 --- Diff: app/addons/documents/actions.js --- @@ -0,0 +1,164 @@ +// Licensed under the Apache License, Version 2.0 (the "License"); you may

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69776649 @robertkowalski I've pushed a new commit with all your feedback. The only thing I haven't done is convert all the expect's to asserts. --- If your project i

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22875319 --- Diff: app/addons/documents/actions.js --- @@ -0,0 +1,164 @@ +// Licensed under the Apache License, Version 2.0 (the "License"); you may n

[jira] [Resolved] (COUCHDB-2533) Fix Fauxton CI

2015-01-13 Thread Robert Kowalski (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Kowalski resolved COUCHDB-2533. -- Resolution: Fixed running on travis now > Fix Fauxton CI > -- > >

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22865560 --- Diff: app/addons/documents/tests/componentsSpec.react.jsx --- @@ -0,0 +1,199 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22865875 --- Diff: app/addons/documents/tests/componentsSpec.react.jsx --- @@ -0,0 +1,199 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22864950 --- Diff: app/addons/documents/actions.js --- @@ -0,0 +1,164 @@ +// Licensed under the Apache License, Version 2.0 (the "License"); you may

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69751254 the added sourcefiles need license headers --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69749636 The react tests are not unmounting elements, `React.unmountComponentAtNode(mytestedCompontent);` --- If your project is set up for it, you can reply to t

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69745704 ![bildschirmfoto 2015-01-13 um 14 45 12](https://cloud.githubusercontent.com/assets/298166/5721511/db9eaf68-9b32-11e4-9a35-42a303f1efaf.png) the a

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69745443 Starting now functional testing: ![bildschirmfoto 2015-01-13 um 14 43 04](https://cloud.githubusercontent.com/assets/298166/5721489/9c903a44-9b32-

[GitHub] couchdb-fauxton pull request: New Style for notifications

2015-01-13 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/109#issuecomment-69743433 Hi @kxepal , the screenshots are outdated, when you fetch the latest changes you will see that the colors changed as I got some feedback from Sean for the

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69721484 @robertkowalski, @benkeen I've fixed all the issues you have mentioned and rebased again master. --- If your project is set up for it, you can reply to this

[jira] [Updated] (COUCHDB-1705) Update Function does not parse multipart/form-data

2015-01-13 Thread Alexander Fedorenchik (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-1705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Fedorenchik updated COUCHDB-1705: --- Attachment: base64_fixed.patch What about a compromise solution? Encode body

[GitHub] couchdb pull request: Fix Makefile, finish separation of CouchDB/F...

2015-01-13 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb/pull/293#issuecomment-69716753 There isn't. There is no need to produce merges on master branch for small fixes. It's makes a sense when it is release branch or you develop some feature with many commi

[GitHub] couchdb pull request: Fix Makefile, finish separation of CouchDB/F...

2015-01-13 Thread candeira
Github user candeira commented on the pull request: https://github.com/apache/couchdb/pull/293#issuecomment-69714762 Hi @kxepal, I'm guessing that github says "Closed with unmerged commmits" because you picked the PR directly from the ASF git repo. Where is that workflow documented?

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-13 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22848698 --- Diff: app/addons/fauxton/components.react.jsx --- @@ -0,0 +1,170 @@ +// Licensed under the Apache License, Version 2.0 (the "License"); yo