[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70601632 Looks great. The only thing I spotted was on IE11, editing a View and clicking Save reloads the page but the Edit Index tab section has disappeared. But this is

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70594028 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70573471 +1 this looks good Robert. Ran 10 times locally, all turning up green. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70571730 Sure, no problem! I'll look at it shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70568352 green test, @benkeen mind taking a look on my attempt to fix the flaky test? f25b52d i run it approx. 10 times and it stayed green. if the code l

[GitHub] couchdb-couch-stats pull request: Declare dependency on couch_log

2015-01-19 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-stats/pull/5 Declare dependency on couch_log COUCHDB-2552 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-couch-stats 2552-unknown-m

[GitHub] couchdb-couch pull request: Make sure we load all applications wit...

2015-01-19 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/32 Make sure we load all applications with stats defs couch_stats app relies on application:loaded_applications. While in the test suite we have to load the apps manually prior to start cou

[jira] [Commented] (COUCHDB-2539) Ensure every subproject to have README and LICENSE files

2015-01-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282810#comment-14282810 ] ASF subversion and git services commented on COUCHDB-2539: -- Com

[GitHub] couchdb-bear pull request: Update README

2015-01-19 Thread kxepal
Github user kxepal closed the pull request at: https://github.com/apache/couchdb-bear/pull/1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Commented] (COUCHDB-2539) Ensure every subproject to have README and LICENSE files

2015-01-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282806#comment-14282806 ] ASF subversion and git services commented on COUCHDB-2539: -- Com

[jira] [Commented] (COUCHDB-2552) unknown metric: [couchdb,mrview,map_docs]

2015-01-19 Thread Alexander Shorin (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282788#comment-14282788 ] Alexander Shorin commented on COUCHDB-2552: --- A bit more notes about. Typo is i

[GitHub] couchdb-fauxton pull request: Style fix for clicking on doc line n...

2015-01-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/237#issuecomment-70536301 Old and busted: https://www.dropbox.com/s/u8xxkak3h1fufei/Screenshot%202015-01-19%2009.20.01.png?dl=0 New and shiny: https://www.dropbox.com/s

[GitHub] couchdb-fauxton pull request: Style fix for clicking on doc line n...

2015-01-19 Thread benkeen
GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/237 Style fix for clicking on doc line nums @seanbarclay noticed that clicking on the gutter (line numbers) on the full page document editor made the row be highlighted in a blue. This c

[jira] [Created] (COUCHDB-2553) Updating View/Index on IE11 causes "Edit Index" tab section to disappear

2015-01-19 Thread Ben Keen (JIRA)
Ben Keen created COUCHDB-2553: - Summary: Updating View/Index on IE11 causes "Edit Index" tab section to disappear Key: COUCHDB-2553 URL: https://issues.apache.org/jira/browse/COUCHDB-2553 Project: CouchDB

[jira] [Commented] (COUCHDB-2541) couchdbctl

2015-01-19 Thread Alexander Shorin (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282748#comment-14282748 ] Alexander Shorin commented on COUCHDB-2541: --- Ah, I'm fine with either. Just `f

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70531412 Looks great. The only thing I spotted was on IE11, editing a View and clicking Save reloads the page but the Edit Index tab section has disappeared. But this is

[GitHub] couchdb-couch-mrview pull request: Fix typo in metrics definition

2015-01-19 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/14#issuecomment-70530802 The name is related to query server command which it counts, so they need to be in sync. --- If your project is set up for it, you can reply to this email an

[jira] [Commented] (COUCHDB-2541) couchdbctl

2015-01-19 Thread Jan Lehnardt (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282741#comment-14282741 ] Jan Lehnardt commented on COUCHDB-2541: --- > `couchdb` script is one the made in bas

[GitHub] couchdb-couch-mrview pull request: Fix typo in metrics definition

2015-01-19 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/14#issuecomment-70530606 Oh, that is my fault. Originally this metric was defined in couchdb-couch and here is the commit the moved it to mrview: https://github.com/apach

[GitHub] couchdb-couch-mrview pull request: Fix typo in metrics definition

2015-01-19 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch-mrview/pull/14 Fix typo in metrics definition We call increment_counter with map_docs. Change definition in stats_description.cfg to match. COUCHDB-2552 You can merge this pull request int

[jira] [Updated] (COUCHDB-2524) clearing out .delete directories in couch_server:init prevents boot of the node

2015-01-19 Thread Alexander Shorin (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shorin updated COUCHDB-2524: -- Fix Version/s: 2.0.0 > clearing out .delete directories in couch_server:init prevents

[jira] [Resolved] (COUCHDB-2524) clearing out .delete directories in couch_server:init prevents boot of the node

2015-01-19 Thread Alexander Shorin (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alexander Shorin resolved COUCHDB-2524. --- Resolution: Fixed Assignee: ILYA > clearing out .delete directories in couch_s

[GitHub] couchdb-fauxton pull request: Improvements to doc collapsed state

2015-01-19 Thread seanbarclay
Github user seanbarclay commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/230#issuecomment-70529778 Hey @benkeen - looks like if you select an item and click expand/collapse- it will expand or collapse all. It should only expand/collapse selected items. It

[jira] [Commented] (COUCHDB-2524) clearing out .delete directories in couch_server:init prevents boot of the node

2015-01-19 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282730#comment-14282730 ] ASF subversion and git services commented on COUCHDB-2524: -- Com

[GitHub] couchdb-couch pull request: Modify init_delete_dir to be async

2015-01-19 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/27#issuecomment-70529641 \o/ --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] couchdb-couch pull request: Modify init_delete_dir to be async

2015-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[jira] [Created] (COUCHDB-2552) unknown metric: [couchdb,mrview,map_docs]

2015-01-19 Thread ILYA (JIRA)
ILYA created COUCHDB-2552: - Summary: unknown metric: [couchdb,mrview,map_docs] Key: COUCHDB-2552 URL: https://issues.apache.org/jira/browse/COUCHDB-2552 Project: CouchDB Issue Type: Bug Securit

[jira] [Assigned] (COUCHDB-2552) unknown metric: [couchdb,mrview,map_docs]

2015-01-19 Thread ILYA (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2552?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ILYA reassigned COUCHDB-2552: - Assignee: ILYA > unknown metric: [couchdb,mrview,map_docs] > -

[jira] [Commented] (COUCHDB-2541) couchdbctl

2015-01-19 Thread Alexander Shorin (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282693#comment-14282693 ] Alexander Shorin commented on COUCHDB-2541: --- I propose for us to have such and

[jira] [Assigned] (COUCHDB-2551) Retain Documents sidebar expand/collapse state on all navigation

2015-01-19 Thread Ben Keen (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2551?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Keen reassigned COUCHDB-2551: - Assignee: Ben Keen > Retain Documents sidebar expand/collapse state on all navigation > ---

[jira] [Created] (COUCHDB-2551) Retain Documents sidebar expand/collapse state on all navigation

2015-01-19 Thread Ben Keen (JIRA)
Ben Keen created COUCHDB-2551: - Summary: Retain Documents sidebar expand/collapse state on all navigation Key: COUCHDB-2551 URL: https://issues.apache.org/jira/browse/COUCHDB-2551 Project: CouchDB

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70523920 +1 maybe @benkeen can take a final look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[jira] [Resolved] (COUCHDB-2542) Cleanup: remove old Ace editor "crimson" theme

2015-01-19 Thread Ben Keen (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Keen resolved COUCHDB-2542. --- Resolution: Fixed > Cleanup: remove old Ace editor "crimson" theme > ---

[jira] [Closed] (COUCHDB-2542) Cleanup: remove old Ace editor "crimson" theme

2015-01-19 Thread Ben Keen (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Keen closed COUCHDB-2542. - > Cleanup: remove old Ace editor "crimson" theme > -- > >

[jira] [Work stopped] (COUCHDB-2542) Cleanup: remove old Ace editor "crimson" theme

2015-01-19 Thread Ben Keen (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2542?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on COUCHDB-2542 stopped by Ben Keen. - > Cleanup: remove old Ace editor "crimson" theme > --

[GitHub] couchdb-fauxton pull request: Added sidebar to permissions page

2015-01-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/231#issuecomment-70521827 All fixed, thanks @garrensmith. N.B. Now the sidebar consistently shows up, I think I'll create a follow up ticket to retain the hide/show state of the s

[jira] [Commented] (COUCHDB-2541) couchdbctl

2015-01-19 Thread Jan Lehnardt (JIRA)
[ https://issues.apache.org/jira/browse/COUCHDB-2541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14282636#comment-14282636 ] Jan Lehnardt commented on COUCHDB-2541: --- Are you proposing we should have such a t

[GitHub] couchdb-couch pull request: Add a configurable timeout for get_pro...

2015-01-19 Thread janl
Github user janl commented on the pull request: https://github.com/apache/couchdb-couch/pull/31#issuecomment-70517554 just a note that “the operators“, at least in the beginning, are end-users as well, so we want to make this as friendly as possible. --- If your project is set up

[GitHub] couchdb-fauxton pull request: Removes the unused Ace crimson theme

2015-01-19 Thread benkeen
Github user benkeen closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] couchdb-fauxton pull request: Removes the unused Ace crimson theme

2015-01-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/229#issuecomment-70516215 Merged as 60d29b7 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have t

Re: [PROPOSAL] CouchDB tests organization

2015-01-19 Thread Jan Lehnardt
Sounds sensible to me :) Good job there! Best Jan -- > On 13 Jan 2015, at 19:24 , Alexander Shorin wrote: > > Hi everyone! > > I would like to a bit change our tests layout. Currently, we have > roughly the following picture: > - couchdb: javascript-based integration tests > - couchdb-couch:

[GitHub] couchdb-fauxton pull request: Improvements to doc collapsed state

2015-01-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/230#issuecomment-70515188 Thanks, @garrensmith! Note to self: after reviewing with Sean, be sure to remove the extra `doc-item-expanded` - wasn't needed. --- If your project is

[GitHub] couchdb-fauxton pull request: Added sidebar to permissions page

2015-01-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/231#issuecomment-70506479 Ack! Thanks for spotting that @garrensmith, I'll take a look. --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] couchdb-couch pull request: Modify init_delete_dir to be async

2015-01-19 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/27#issuecomment-70506054 History is rewritten for merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] couchdb-fauxton pull request: travis: notify about broken build

2015-01-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/236 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] couchdb-fauxton pull request: travis: notify about broken build

2015-01-19 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/236#issuecomment-70496410 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70496317 +1 working nicely --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] couchdb-fauxton pull request: travis: notify about broken build

2015-01-19 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/236 travis: notify about broken build notify #couchdb-dev about a broken build You can merge this pull request into a Git repository by running: $ git pull https://github.com/robert

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread garrensmith
GitHub user garrensmith reopened a pull request: https://github.com/apache/couchdb-fauxton/pull/233 React building blocks and navbar I've decided to break up #216 into two. This is the first one. It is the main react dependancies along with the main navigation bar done in React.js

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread garrensmith
Github user garrensmith closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70490948 @garrensmith, the travis run fails. can you fix the failing test? --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70485504 ugh, monday morning... should be fixed now, @garrensmith --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70482380 @robertkowalski I've fixed the './base' path and replaced " with '. I haven't added a separate commit for the whitespace this time as I want to reduce the nu

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70481974 I've getting a 'Uncaught TypeError: Cannot read property 'preventDefault' of undefined' in the console. This happens if I click on the 'x' then wait 1 second

[GitHub] couchdb-fauxton pull request: Adding React into Fauxton

2015-01-19 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70481697 I've broken this into two smaller pull requests for easier merging. They are #233 and #235 --- If your project is set up for it, you can reply to this emai

[GitHub] couchdb-fauxton pull request: React index editor

2015-01-19 Thread garrensmith
GitHub user garrensmith opened a pull request: https://github.com/apache/couchdb-fauxton/pull/235 React index editor This is part two of #216. This is the index editor. This required #233 to land first. You can merge this pull request into a Git repository by running: $ git pu

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/234 Don't redirect on dismissing the notification If you edited a document and then clicked on cancel, you were redirected to the database list closes COUCHDB-2550 You can m

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread garrensmith
GitHub user garrensmith opened a pull request: https://github.com/apache/couchdb-fauxton/pull/233 React building blocks and navbar I've decided to break up #216 into two. This is the first one. It is the main react dependancies along with the main navigation bar done in React.js Yo

[jira] [Created] (COUCHDB-2550) Bug in new notifications

2015-01-19 Thread Garren Smith (JIRA)
Garren Smith created COUCHDB-2550: - Summary: Bug in new notifications Key: COUCHDB-2550 URL: https://issues.apache.org/jira/browse/COUCHDB-2550 Project: CouchDB Issue Type: Bug Securit

[GitHub] couchdb-fauxton pull request: Fix COUCHDB-2543 by avoiding overlap...

2015-01-19 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/232#issuecomment-70468265 @sebastianrothbucher this looks good to me. +1, you can merge it. Thanks for the pull request --- If your project is set up for it, you can reply to this em

[GitHub] couchdb-fauxton pull request: Improvements to doc collapsed state

2015-01-19 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/230#issuecomment-70467796 +1 nice work @benkeen --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] couchdb-fauxton pull request: Added sidebar to permissions page

2015-01-19 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/231#issuecomment-70467188 @benkeen this doesn't quite work. If I click on the permissions page, all the design docs listed in the sidebar disappear. --- If your project is set up for