Re: [GSOC 2015] COUCHDB-2605 Visualize the CouchDB Cluster

I can share a few quick thoughts (which I admit is rare, but I happen to have a few minutes and this hit the top of my stack): * How do you envision this overflowing when you have hundreds of databases within a cluster, or maybe 64 nodes in a cluster. ** On a related note, drag and drop is cool,

Re: [GSOC 2015] COUCHDB-2605 Visualize the CouchDB Cluster

Hi All, are there any ideas and feedback for above mockup UIs? Community feedback will be useful in here. :) On Sun, Mar 22, 2015 at 11:51 PM, madhuka udantha wrote: > Hi, > > Here are the mockup UIs for Visualizing the CouchDB Clusters. It is just > the initial UIs. > > * Page 1-cluster.png*

Re: GSoc 2015 | COUCHDB-1743 Make the view server & protocol faster

Dear Robert and Alexander, Thanks for your suggestions. Robert, Yes I was thinking about a good, simple way to represent the schedule. My idea was to draw a chart which shows the time allocation with a range of dates and hourly basis. eg: Implementing show function handler Duration: May 10 to 30

[GitHub] couchdb-couch-replicator pull request: Return context from test_ut...

Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/8#issuecomment-85286204 Can you link to the PR that changes test_util? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as w

[GitHub] couchdb-couch-mrview pull request: Remove handlers of outdated mrv...

Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/5#issuecomment-85285843 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] couchdb-couch-mrview pull request: Export get_view_callback/3 for ...

Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/11#issuecomment-85285528 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-couch-mrview pull request: Fix typo in metrics definition

Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/14#issuecomment-85285422 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-couch-mrview pull request: Define ADMIN_USER and ADMIN_CTX...

Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/15#issuecomment-85285305 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-couch-index pull request: Return pending_updates field fro...

Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch-index/pull/3#issuecomment-85283918 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature en

[GitHub] couchdb-couch pull request: Add users db security rules on cluster...

Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch/pull/20#issuecomment-85281459 I haven't done a thorough review yet, but this seems related to PR #41 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-couch pull request: Add users db security rules on cluster...

Github user davisp commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/20#discussion_r26997498 --- Diff: src/couch_server.erl --- @@ -116,30 +116,37 @@ create(DbName, Options0) -> delete(DbName, Options) -> gen_server:call(couch_server

[GitHub] couchdb-couch pull request: Add IS_OLD_RECORD macro

Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch/pull/23#issuecomment-85280780 +1 to merge. I guess I should probably get to that. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. I

[GitHub] couchdb-couch pull request: add *.d to .gitignore

Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch/pull/28#issuecomment-85280587 Which dependencies in priv? *.d seems a bit overly general, perhaps limit to the directory they affect? --- If your project is set up for it, you can reply to this

[GitHub] couchdb-couch pull request: 2534 db security respect authed users

Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch/pull/29#issuecomment-85280210 +1 after squashing the refactor commit --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] couchdb-mem3 pull request: Make the hash algorithm configurable pe...

Github user davisp commented on the pull request: https://github.com/apache/couchdb-mem3/pull/3#issuecomment-85275680 Looks like this is missing adding the ets_lru worker to the mem3 supervision tree. --- If your project is set up for it, you can reply to this email and have your rep

[GitHub] couchdb-chttpd pull request: abort_multi_part_stream has been move...

Github user davisp commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/11#issuecomment-85272309 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] couchdb-chttpd pull request: Add users db security rules on cluste...

Github user davisp commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/12#issuecomment-85272031 +1 to squerge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this fea

[GitHub] couchdb-chttpd pull request: Add users db security rules on cluste...

Github user davisp commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/12#discussion_r26996242 --- Diff: src/chttpd_auth_cache.erl --- @@ -91,6 +102,12 @@ handle_info({'DOWN', _, _, Pid, Reason}, #state{changes_pid=Pid} = State) -> {norep

[GitHub] couchdb-chttpd pull request: Return {error, Reason} for illegal_da...

Github user davisp commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/26#issuecomment-85269588 The PR tile, linked ticket, and diff don't seem to match to me. The diff appears to change the error message to include the database name (which is fine, but I don'

Re: GSoc 2015 | COUCHDB-1743 Make the view server & protocol faster

Looks good! Left some suggestions! Are you going to complete the schedule? I just noticed that you have a special section for testing, from my experience I can suggest to add unit tests while you develop the feature, as adding tests weeks or months later to a big, grown codebase is not a lot of f

[GitHub] couchdb-chttpd pull request: Use started apps from test_util:start...

Github user davisp commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/24#issuecomment-85260053 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

[GitHub] couchdb-chttpd pull request: add _changes?feed=stream sugar for co...

Github user davisp commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/28#issuecomment-85257576 Voting 0 with no modifier as per same reason as @janl and @rnewson. Also agree using a comma instead of the slash when listing the possible values. --- If your pro

[GitHub] couchdb-chttpd pull request: add gitignore

Github user davisp commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/29#issuecomment-85257224 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enab

Closing old PRs

Hi all, I've been going through trying to review open PRs today (long overdue, I know) and I've noticed that there seem to be a lot of "open" PRs that have actually been merged. Did we ever find a way to be able to close PRs wihtout having to add a commit with the "Fixes #whatever" magic? Paul

[jira] [Commented] (COUCHDB-1415) Re-insering a document silently fails after compact is executed

[ https://issues.apache.org/jira/browse/COUCHDB-1415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376956#comment-14376956 ] ASF GitHub Bot commented on COUCHDB-1415: - Github user davisp commented on the p

[GitHub] couchdb pull request: Added warning in docs for COUCHDB-1415

Github user davisp commented on the pull request: https://github.com/apache/couchdb/pull/98#issuecomment-85254598 I'm pretty sure the underlying bug is fixed in 2.0. Might want to revisit the docs on this. --- If your project is set up for it, you can reply to this email and have you

[jira] [Commented] (COUCHDB-1438) GET /// triggers a 500 error

[ https://issues.apache.org/jira/browse/COUCHDB-1438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376955#comment-14376955 ] ASF GitHub Bot commented on COUCHDB-1438: - Github user davisp commented on the p

[GitHub] couchdb pull request: COUCHDB-1438 - fix - Ignore trailing / on ro...

Github user davisp commented on the pull request: https://github.com/apache/couchdb/pull/122#issuecomment-85254157 Its fixed on the clustered interface though we'll may want to port this to the couch_httpd.erl in couchdb-couch.git --- If your project is set up for it, you can reply t

[GitHub] couchdb pull request: Allow passing directories as the config sour...

Github user davisp commented on the pull request: https://github.com/apache/couchdb/pull/257#issuecomment-85251274 Also, this should be ported to the couchdb-config app since this won't merge to master. Should be a trivial move though. --- If your project is set up for it, you can re

[GitHub] couchdb pull request: Allow passing directories as the config sour...

Github user davisp commented on a diff in the pull request: https://github.com/apache/couchdb/pull/257#discussion_r26992836 --- Diff: src/couchdb/couch_app.erl --- @@ -37,7 +38,17 @@ get_ini_files(Default) -> {ok, [[]]} -> Default; {ok, [Values]} ->

[GitHub] couchdb pull request: Allow passing directories as the config sour...

Github user davisp commented on a diff in the pull request: https://github.com/apache/couchdb/pull/257#discussion_r26992810 --- Diff: src/couchdb/couch_app.erl --- @@ -37,7 +38,17 @@ get_ini_files(Default) -> {ok, [[]]} -> Default; {ok, [Values]} ->

[GitHub] couchdb pull request: Add systemd notification support

Github user davisp commented on the pull request: https://github.com/apache/couchdb/pull/258#issuecomment-85250241 This seems like it'd be better to write this as a plugin. For starters, randomly loading a module named sd_notify seems not good from a security point of view for

[GitHub] couchdb pull request: doc: explain new workflow for developing

Github user davisp commented on the pull request: https://github.com/apache/couchdb/pull/270#issuecomment-85248702 Erm, so +1 to merging this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb pull request: doc: explain new workflow for developing

Github user davisp commented on the pull request: https://github.com/apache/couchdb/pull/270#issuecomment-85248649 You can add that ./dev/run -n 1 will spin up a single node as well. Obviously that's just a single node running the full clustered interface. If anyone feels like making

[GitHub] couchdb pull request: Update INSTALL.Unix

Github user davisp commented on the pull request: https://github.com/apache/couchdb/pull/272#issuecomment-85247682 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] couchdb pull request: Test users db security rules on clustered in...

Github user davisp commented on the pull request: https://github.com/apache/couchdb/pull/288#issuecomment-85247064 LGTM --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled an

[GitHub] couchdb pull request: Consume JSON body even when its content is i...

Github user davisp commented on the pull request: https://github.com/apache/couchdb/pull/304#issuecomment-85245732 How do we get this closed if the patch already landed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] couchdb-fauxton pull request: tooling: don't require globally inst...

Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/325#issuecomment-85244731 +1 neat trick! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-jiffy pull request: Update jiffy to 0.13.3

Github user davisp commented on the pull request: https://github.com/apache/couchdb-jiffy/pull/1#issuecomment-85244644 For the update to 0.13 we should just sync from upstream. As has been pointed out if we commit to master on any of these we permanently break our ability to track the

[GitHub] couchdb-fauxton pull request: Design doc names truncated in sideba...

Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/330#issuecomment-85243077 Before: 

[GitHub] couchdb-fauxton pull request: Design doc names truncated in sideba...

GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/330 Design doc names truncated in sidebar Long design doc names displayed in the sidebar of the Docs page would overlap with the rightmost ("+") icon. This truncates them with an ellipsi

[GitHub] couchdb-fauxton pull request: Invalid 'undefined' class in All Doc...

Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/329#issuecomment-85209833 Thank you for your contribution! Every PR needs tests, can you provide a test? Example test: https://github.com/apache/couchdb-fauxton/blob/maste

[jira] [Commented] (COUCHDB-2577) Invalid 'undefined' class in All Docs header button element

[ https://issues.apache.org/jira/browse/COUCHDB-2577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376671#comment-14376671 ] ASF GitHub Bot commented on COUCHDB-2577: - GitHub user wadsashika opened a pull

[GitHub] couchdb-fauxton pull request: Invalid 'undefined' class in All Doc...

GitHub user wadsashika opened a pull request: https://github.com/apache/couchdb-fauxton/pull/329 Invalid 'undefined' class in All Docs header button element This remove the invalide undefined class in select button of All Docs header which appear when landing the page Close

[jira] [Commented] (COUCHDB-2554) Add API URL to Permissions page

[ https://issues.apache.org/jira/browse/COUCHDB-2554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376422#comment-14376422 ] Ben Keen commented on COUCHDB-2554: --- See PR: https://github.com/apache/couchdb-fauxton

[jira] [Resolved] (COUCHDB-2216) Changes table: Performance issue with larger databases

[ https://issues.apache.org/jira/browse/COUCHDB-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Keen resolved COUCHDB-2216. --- Resolution: Fixed Resolved by: https://github.com/apache/couchdb-fauxton/pull/303 > Changes table:

[jira] [Work stopped] (COUCHDB-2216) Changes table: Performance issue with larger databases

[ https://issues.apache.org/jira/browse/COUCHDB-2216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on COUCHDB-2216 stopped by Ben Keen. - > Changes table: Performance issue with larger databases > --

[GitHub] couchdb-fauxton pull request: Add API URL option to permissions pa...

GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/328 Add API URL option to permissions page This adds the API URL header link to the permissions page which opens the /db/_security endpoint and appropriate doc link. N.B. none of th

Re: [VOTE] Accept couchperuser codebase

+1 On Mon, Mar 23, 2015 at 3:10 PM, Andy Wenk wrote: > +1 > > On 23 March 2015 at 14:55, Noah Slater wrote: > > > +1 > > > > On Mon, 23 Mar 2015 at 14:18 Klaus Trainer > > wrote: > > > > > +1 > > > > > > > > > On 03/23/2015 01:01 PM, Robert Kowalski wrote: > > > > Hi list, > > > > > > > > couc

[GitHub] couchdb-fauxton pull request: Centralize-URL-for-Jump-to-Doc-tray

Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/315#issuecomment-85134870 I rebased to master, hopefully test will turn green soon --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[jira] [Work started] (COUCHDB-2554) Add API URL to Permissions page

[ https://issues.apache.org/jira/browse/COUCHDB-2554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Work on COUCHDB-2554 started by Ben Keen. - > Add API URL to Permissions page > --- > >

[jira] [Resolved] (COUCHDB-2587) URI encode unicode chars in db typeahead

[ https://issues.apache.org/jira/browse/COUCHDB-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Keen resolved COUCHDB-2587. --- Resolution: Fixed > URI encode unicode chars in db typeahead > -

[jira] [Closed] (COUCHDB-2587) URI encode unicode chars in db typeahead

[ https://issues.apache.org/jira/browse/COUCHDB-2587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ben Keen closed COUCHDB-2587. - > URI encode unicode chars in db typeahead > > > Ke

[GitHub] couchdb-fauxton pull request: Fix for deleting database with '/' i...

Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/323#issuecomment-85112378 Merged. (I squashed, hence the re-running of the test - but it was green) --- If your project is set up for it, you can reply to this email and have your reply a

[GitHub] couchdb-fauxton pull request: Fix for deleting database with '/' i...

Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/323 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] couchdb-fauxton pull request: Fix for non-wrapping seq num on Chan...

Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/327#issuecomment-85101457 Small fix to add a class back in to make long sequence numbers wrap on the changes page. Before: ![screen shot 2015-03-23 at 10 10 19 am](https://cl

[GitHub] couchdb-fauxton pull request: Fix for non-wrapping seq num on Chan...

GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/327 Fix for non-wrapping seq num on Changes page You can merge this pull request into a Git repository by running: $ git pull https://github.com/benkeen/couchdb-fauxton seq-num-wrapping

[jira] [Commented] (COUCHDB-2644) total_rows in find API response

[ https://issues.apache.org/jira/browse/COUCHDB-2644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14376144#comment-14376144 ] Nolan Lawson commented on COUCHDB-2644: --- Basically we would like a way to easily p

Re: GSoc 2015 | COUCHDB-1743 Make the view server & protocol faster

Dear Folks, I have prepared a draft proposal for the project based on what I have read so far. How deep I should explain the technical details of the project? Is the software process which I have suggested is ok? or should I use any other process? This is the link

[GitHub] couchdb-fauxton pull request: Fix for deleting database with '/' i...

Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/323#issuecomment-85058912 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[jira] [Created] (COUCHDB-2644) total_rows in find API response

chandra sekhar kode created COUCHDB-2644: Summary: total_rows in find API response Key: COUCHDB-2644 URL: https://issues.apache.org/jira/browse/COUCHDB-2644 Project: CouchDB Issue Typ

Re: [VOTE] Accept couchperuser codebase

+1 On 23 March 2015 at 14:55, Noah Slater wrote: > +1 > > On Mon, 23 Mar 2015 at 14:18 Klaus Trainer > wrote: > > > +1 > > > > > > On 03/23/2015 01:01 PM, Robert Kowalski wrote: > > > Hi list, > > > > > > couchperuser is a CouchDB daemon that ensures that a private per-user > > > database exist

Re: [VOTE] Accept couchperuser codebase

+1 On Mon, 23 Mar 2015 at 14:18 Klaus Trainer wrote: > +1 > > > On 03/23/2015 01:01 PM, Robert Kowalski wrote: > > Hi list, > > > > couchperuser is a CouchDB daemon that ensures that a private per-user > > database exists for each document in _users. These databases are > > writable only by the

Re: [VOTE] Accept couchperuser codebase

+1 On 03/23/2015 01:01 PM, Robert Kowalski wrote: > Hi list, > > couchperuser is a CouchDB daemon that ensures that a private per-user > database exists for each document in _users. These databases are > writable only by the corresponding user. Databases are in the form: > userdb-{hex encoded u

Re: GSOC 2015 [Visualize document revision tree and navigate betweenthese revisions]

Very good! Such layout indeed have better potential to handle upcoming feature requests. I wouldn't concentrate here on the details (like action menu - it's uncommon for Fauxton interface to have a dropdown list of actions since buttons are preferred instead) - the idea and the base layout are more

Re: GSOC 2015 [Visualize document revision tree and navigate betweenthese revisions]

Hi Robert, According to the suggestions of Alex I re designed the Interface. It will be great if you can give some feedback regarding the current UI. I will point to each suggestion as follows, *1. Tree could be wide. Very wide and tall. Proposed interface has a quite small limit for amount of co

[GitHub] couchdb-fauxton pull request: update ace@20.12.14

Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/285#issuecomment-84965824 merged as dcdd5eea062d0e5081b9adcd37757e0776ed and 067b0880da676c5bee7886d6994f07eb4c09216e --- If your project is set up for it, you can reply to th

[GitHub] couchdb-fauxton pull request: update ace@20.12.14

Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/285 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

Re: [VOTE] Accept couchperuser codebase

+1 -- ,,,^..^,,, On Mon, Mar 23, 2015 at 3:01 PM, Robert Kowalski wrote: > Hi list, > > couchperuser is a CouchDB daemon that ensures that a private per-user > database exists for each document in _users. These databases are > writable only by the corresponding user. Databases are in the form:

[VOTE] Accept couchperuser codebase

Hi list, couchperuser is a CouchDB daemon that ensures that a private per-user database exists for each document in _users. These databases are writable only by the corresponding user. Databases are in the form: userdb-{hex encoded username} For example, the user bob will have a database named u

Re: [DISCUSSION] GitHub PRs merging policy

I am also merging fast-forward and can't say that the information gets lost who merged the commit (see https://github.com/apache/couchdb-fauxton/commit/8a1aaff198ceb16a4754dfce8453fda80fd17783 ) Regarding the process/tooling: I just started to use git-apply-pr ( https://github.com/joyent/git-apply

Re: [DISCUSSION] GitHub PRs merging policy

Hi Garren, I cannot say that is your workflow is wrong neither I cannot say the mine is not. I'm more interested to define the one with which everyone (or at least majority) is happy (: The default merge behaviour is fast forward, but it fallbacks to no-ff if git cannot perform it or you're merge

[GitHub] couchdb-fauxton pull request: all-dbs, all-docs: more responsivene...

Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/253 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] couchdb-fauxton pull request: all-dbs, all-docs: more responsivene...

Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/253#issuecomment-84953822 merged as cfd9ec85913879069d0294779a1eb6b700026b2a --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb-fauxton pull request: React docs list

Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/324#issuecomment-84945241 tests are failing --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] couchdb-fauxton pull request: React docs list

Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/324#discussion_r26927288 --- Diff: app/addons/documents/views.js --- @@ -269,7 +269,7 @@ function (app, FauxtonAPI, Components, Documents, } });

[GitHub] couchdb-fauxton pull request: React docs list

Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/324#discussion_r26927298 --- Diff: app/addons/documents/header/header.actions.js --- @@ -37,13 +51,13 @@ function (app, FauxtonAPI, ActionTypes) { });

[GitHub] couchdb-fauxton pull request: React docs list

Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/324#discussion_r26927152 --- Diff: app/addons/documents/index-results/tests/index-results.storesSpec.js --- @@ -0,0 +1,306 @@ +// Licensed under the Apache License

[GitHub] couchdb-fauxton pull request: tooling: automatically test for code...

Github user Madhuka commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/326#issuecomment-84943835 @robertkowalski Thanks, It will be helpful for all the new comes. Since different styles are used in JS. --- If your project is set up for it, you can reply to

[GitHub] couchdb-fauxton pull request: React docs list

Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/324#discussion_r26927103 --- Diff: app/addons/documents/pagination/actions.js --- @@ -67,10 +62,14 @@ function (app, FauxtonAPI, ActionTypes, Stores) { typ

[GitHub] couchdb-fauxton pull request: React docs list

Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/324#discussion_r26927113 --- Diff: app/addons/documents/pagination/actions.js --- @@ -44,21 +41,19 @@ function (app, FauxtonAPI, ActionTypes, Stores) { });

[GitHub] couchdb-fauxton pull request: React docs list

Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/324#discussion_r26927067 --- Diff: app/addons/documents/tests/nightwatch/viewQueryOptions.js --- @@ -13,7 +13,7 @@ module.exports = { 'Edit view: Queryoptio

[GitHub] couchdb-fauxton pull request: tooling: automatically test for code...

Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/326#issuecomment-84942984 @Madhuka yes, this basically codifies https://github.com/apache/couchdb-fauxton/blob/master/styleguide.md --- If your project is set up for it, you can r

[GitHub] couchdb-fauxton pull request: tooling: automatically test for code...

Github user Madhuka commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/326#issuecomment-84942722 Hi, I am new to cocuhDB and I'm looking forward to GSOC. I too know that styling in JS is a pain. I too came across the same issue when we were releasin

Re: [COUCHDB-2214] Dashboard as main page

Hi Robert, Actually I am the one who made the mistake here. I didn't explain the functions properly. And you didn't discourage me :) every idea coming from you and others are really valuable to me. My development environment is Ubuntu and I design this mock up in Windows. So I couldn't find find

[GitHub] couchdb-fauxton pull request: tooling: automatically test for code...

Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/326#issuecomment-84931773 @robertkowalski cool! I miss that moment (: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] couchdb-fauxton pull request: tooling: automatically test for code...

Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/326#issuecomment-84914020 @garrensmith will do in a separate PR - it is on my list! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] couchdb-fauxton pull request: tooling: automatically test for code...

Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/326#issuecomment-84913934 @kxepal @garrensmith it is covered by travis: https://github.com/robertkowalski/couchdb-fauxton/commit/4e1d0d3d5f0386b51c1fb2a79b3e451b901b7c7b#diff-35b4a8

Re: [DISCUSSION] GitHub PRs merging policy

Here is how the Fauxton team merge our commits. We probably don’t follow the most scientific method but it seems to work well enough. 1) Add ability to remote fetch PR’s https://gist.github.com/piscisaureus/3342247 instead of having to add the con

[GitHub] couchdb-fauxton pull request: tooling: automatically test for code...

Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/326#issuecomment-84874437 +1 this is great. Could you also create a jshintrc file and we can move all our jshint settings out of the grunt file. I agree with @kxepal this shou