[GitHub] couchdb-fauxton pull request: Open up Databases table to be extend...

2015-05-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/425#issuecomment-103661109 Sure, np :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this f

[GitHub] couchdb-fauxton pull request: Open up Databases table to be extend...

2015-05-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/425#issuecomment-103660804 can you write a small and short unit test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-fauxton pull request: Open up Databases table to be extend...

2015-05-19 Thread benkeen
GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/425 Open up Databases table to be extended This adds a couple of hooks to the DatabaseTable component to allow extensions to add columns. You can merge this pull request into a Git reposito

[GitHub] couchdb-fauxton pull request: tests: run setup in parallel

2015-05-19 Thread sebastianrothbucher
Github user sebastianrothbucher commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/423#discussion_r30642593 --- Diff: test/nightwatch_tests/helpers/helpers.js --- @@ -25,23 +26,31 @@ module.exports = { console.log("nano setting up

[GitHub] couchdb-fauxton pull request: tests: run setup in parallel

2015-05-19 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/423#discussion_r30642107 --- Diff: test/nightwatch_tests/helpers/helpers.js --- @@ -25,23 +26,31 @@ module.exports = { console.log("nano setting up datab

[GitHub] couchdb-fauxton pull request: tests: run setup in parallel

2015-05-19 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/423#discussion_r30641948 --- Diff: test/nightwatch_tests/helpers/helpers.js --- @@ -25,23 +26,31 @@ module.exports = { console.log("nano setting up datab

[GitHub] couchdb-fauxton pull request: tests: run setup in parallel

2015-05-19 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/423#discussion_r30641729 --- Diff: test/nightwatch_tests/helpers/helpers.js --- @@ -25,23 +26,31 @@ module.exports = { console.log("nano setting up datab

[GitHub] couchdb-fauxton pull request: tests: run setup in parallel

2015-05-19 Thread sebastianrothbucher
Github user sebastianrothbucher commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/423#discussion_r30641490 --- Diff: test/nightwatch_tests/helpers/helpers.js --- @@ -25,23 +26,31 @@ module.exports = { console.log("nano setting up

[GitHub] couchdb-fauxton pull request: tests: fix flaky test

2015-05-19 Thread robertkowalski
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/424 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] couchdb-fauxton pull request: tests: fix flaky test

2015-05-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/424#issuecomment-103654273 moved to https://github.com/apache/couchdb-fauxton/pull/423 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-fauxton pull request: tests: run setup in parallel

2015-05-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/423#issuecomment-103623844 Cool. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] couchdb-fauxton pull request: tests: fix flaky test

2015-05-19 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/424 tests: fix flaky test You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton flaky-1234 Alternatively y

[GitHub] couchdb-fauxton pull request: tests: run setup in parallel

2015-05-19 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/423 tests: run setup in parallel faster tests! You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton test-sp

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-19 Thread nadeeshaan
Github user nadeeshaan commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30625763 --- Diff: app/addons/documents/routes-rev-tree.js --- @@ -0,0 +1,48 @@ +define([ + "app", + "api", + "addons/documents/resources

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-19 Thread nadeeshaan
Github user nadeeshaan commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30625794 --- Diff: app/addons/documents/revisionTree/component.react.jsx --- @@ -0,0 +1,332 @@ +define([ + "app", + "api", + "react",

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-19 Thread nadeeshaan
Github user nadeeshaan commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30625807 --- Diff: app/addons/documents/routes-rev-tree.js --- @@ -0,0 +1,48 @@ +define([ + "app", + "api", + "addons/documents/resources

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-19 Thread nadeeshaan
Github user nadeeshaan commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30625782 --- Diff: app/addons/documents/revisionTree/component.react.jsx --- @@ -0,0 +1,332 @@ +define([ + "app", + "api", + "react",

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-19 Thread nadeeshaan
Github user nadeeshaan commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30625714 --- Diff: app/addons/documents/views-rev-tree.js --- @@ -0,0 +1,23 @@ +define([ + "app", + "api", + "addons/documents/resources"

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-19 Thread nadeeshaan
Github user nadeeshaan commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30625636 --- Diff: app/addons/documents/revisionTree/component.react.jsx --- @@ -0,0 +1,332 @@ +define([ + "app", + "api", + "react",

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-19 Thread nadeeshaan
Github user nadeeshaan commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30625678 --- Diff: app/addons/documents/revisionTree/component.react.jsx --- @@ -0,0 +1,332 @@ +define([ + "app", + "api", + "react",

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-19 Thread nadeeshaan
Github user nadeeshaan commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30625584 --- Diff: app/addons/documents/revisionTree/component.react.jsx --- @@ -0,0 +1,332 @@ +define([ + "app", + "api", + "react",

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-19 Thread nadeeshaan
Github user nadeeshaan commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30625617 --- Diff: app/addons/documents/revisionTree/component.react.jsx --- @@ -0,0 +1,332 @@ +define([ + "app", + "api", + "react",

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-19 Thread nadeeshaan
Github user nadeeshaan commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30625559 --- Diff: app/addons/documents/revisionTree/component.react.jsx --- @@ -0,0 +1,332 @@ +define([ + "app", + "api", + "react",

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-19 Thread nadeeshaan
Github user nadeeshaan commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30625594 --- Diff: app/addons/documents/revisionTree/component.react.jsx --- @@ -0,0 +1,332 @@ +define([ + "app", + "api", + "react",

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-19 Thread nadeeshaan
Github user nadeeshaan commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30625538 --- Diff: app/addons/documents/revisionTree/component.react.jsx --- @@ -0,0 +1,332 @@ +define([ + "app", + "api", + "react",

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-19 Thread nadeeshaan
Github user nadeeshaan commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30625400 --- Diff: app/addons/documents/revisionTree/actions.js --- @@ -0,0 +1,26 @@ +define([ + 'app', + 'api', + 'addons/documents/revi

[REMINDER] IRC meeting - 2015-05-20 18:00 UTC

2015-05-19 Thread Alexander Shorin
Hi all, We'll be having the usual meeting in #couchdb-meeting on irc.freenode.org at 18:00 UTC, Wednesday as usual, but time is the new. The meeting room: irc://irc.freenode.net/couchdb-meeting Or you can access the meeting via the web: http://webchat.freenode.net/?channels=#couchdb-me

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/362#issuecomment-103597425 merged as 425fc9b --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-19 Thread robertkowalski
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/362 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] couchdb-fauxton pull request: tests: update ff

2015-05-19 Thread robertkowalski
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/422 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] couchdb-fauxton pull request: tests: update ff

2015-05-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/422#issuecomment-103595675 merged! 30f65771d827c67610b36ad73218138a31303d5f 2a38fbd8fc994766db03820473c819b2cda517f7 e516e24163cdb0862eedaf5f48c5b3f667ee7b --- If

[GitHub] couchdb-fauxton pull request: tests: update ff

2015-05-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/422#issuecomment-103579876 +1. This looks good. Let's see how Travis handles it... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-19 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/362#issuecomment-103579014 +1 on the code and being able to delete documents from the query!! :D :+1: although it's working, it's still a bit unclear how it's supposed to w

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103578598 Sorry to be a pain, one more minor thing: it allows you to add a blank entry. I think this is an old bug. The UI looks a little wonky due to the empty user name

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/362#issuecomment-103571441 Ah okay, thanks @robertkowalski - I wasn't clear on what that meant. Other than the missing radio (not clear on that either), looks good. +1 --- If your projec

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/362#issuecomment-103571018 > Repeating the same index name in "Available Indexes" is okay? yes, you created the second one, the first one is the special index "all_docs" wh

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/362#issuecomment-103570121 Repeating the same index name is okay? ![double-index](https://cloud.githubusercontent.com/assets/512116/7707868/0e9c7e36-fe07-11e4-9e1e-6daca982b2b9.pn

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/362#issuecomment-103566176 - there should be a space after the "Mango Query" label and the "?" icon - the default mango query uses 2-spaces, but Ace's default behaviour is tabs (e.g. c

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/362#issuecomment-103569239 One curious thing, when I add I create a new Mango index, the page show two items - the first of which doesn't have an option to select it. See screenshot:

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-19 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/362#issuecomment-103567538 +1 nice work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103561028 i think it's `any of the following` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103558132 if your going to change the UI, I'd reword the sub-line under "Roles" to: `All users with any of the following role(s) will have admins access.`, o

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/421#discussion_r30612649 --- Diff: app/addons/permissions/components.react.jsx --- @@ -0,0 +1,221 @@ +// Licensed under the Apache License, Version 2.0 (the "Licens

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103547574 Besides previous comment, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] couchdb-fauxton pull request: tests: update ff

2015-05-19 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/422 tests: update ff You can merge this pull request into a Git repository by running: $ git pull https://github.com/robertkowalski/couchdb-fauxton travis-test Alternatively you c

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103540621 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103539465 Code looks great, but I'll look it over a little longer. One minor UX niggle: after adding an item in any of the four sections on the Permissions page, it shoul

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/362#issuecomment-103476983 > Also if I edit the query but don't click run. Instead I press the '<' then I get a modal asking me am I sure I should leave the page. that is a

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-19 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/362#issuecomment-103445865 @robertkowalski this is looking good. Two issue's on the Run a Mango Query. If I edit the query before the list of indexes I have loads then the query is re

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread garrensmith
GitHub user garrensmith opened a pull request: https://github.com/apache/couchdb-fauxton/pull/421 Permissions react Permissions for a database done in React You can merge this pull request into a Git repository by running: $ git pull https://github.com/garrensmith/couchdb-fauxt