[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-21 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30864085 --- Diff: app/addons/activetasks/components.react.jsx --- @@ -453,17 +384,75 @@ define([ {startedOnMsg} {updatedOn

Re: On Plugins and Extensibility

2015-05-21 Thread Russell Branca
Hey Paul, Thanks for the great writeup! Couple of questions: How do priv/*.cfg files work with dynamic config updates? Seems like we'll lose the ability to write changes back to the config file, like we have with default.ini. Although I've been wondering for a while if allowing config:set/* to

[GitHub] couchdb-couch pull request: Pass Opts to put/post/delete of test_r...

2015-05-21 Thread hdiedrich
Github user hdiedrich commented on the pull request: https://github.com/apache/couchdb-couch/pull/50#issuecomment-104443224 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature ena

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-21 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-104441337 the logic for the unit tests are already written with the conversion of active task to react, (and they are still passing!) :D https://github.com

Re: fsync() vs EINTR

2015-05-21 Thread Paul Davis
Assuming that Erlang doesn't lie about the return status, then we'd throw an error on a broken fsync which would kill the couch_db_updater. In the case of delayed_commits we'd lose the last delayed commit interval of writes just as any other error. That's based on these two lines: https://github.

On Plugins and Extensibility

2015-05-21 Thread Paul Davis
Hey everyone, So I've been meaning to write this email for sometime but have been kept busy with lots of super fun things that are super fun. Anyway, I just wanted to get this out there to start getting feed back from everyone involved. Also, while this is called "Plugin Proposal" it shouldn't be

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30854540 --- Diff: app/addons/activetasks/components.react.jsx --- @@ -453,17 +384,71 @@ define([ {startedOnMsg} {updatedO

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30854525 --- Diff: app/addons/activetasks/components.react.jsx --- @@ -453,17 +384,71 @@ define([ {startedOnMsg} {updatedO

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30854469 --- Diff: app/addons/activetasks/components.react.jsx --- @@ -453,17 +384,71 @@ define([ {startedOnMsg} {updatedO

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30854437 --- Diff: app/addons/activetasks/components.react.jsx --- @@ -349,7 +280,7 @@ define([ onChange={this.onTableHeaderClick}>

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30854347 --- Diff: app/addons/activetasks/assets/less/activetasks.less --- @@ -208,4 +205,64 @@ input[type="text"].searchbox { padding: 0px;

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-104439489 this needs a lot unit tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your proje

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30854221 --- Diff: app/addons/activetasks/stores.js --- @@ -18,7 +18,7 @@ define([ var ActiveTasksStore = FauxtonAPI.Store.extend({

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-21 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-104438055 Ready for reviews!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does n

[GitHub] couchdb-fauxton pull request: add spy.restore to mocha test

2015-05-21 Thread michellephung
Github user michellephung closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/431 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/401#issuecomment-104416541 Hi Nadeeshan, I was in a meeting - sorry - you got some merge issues. I can help you tomorrow, just join IRC --- If your project is set up for

Re: fsync() vs EINTR

2015-05-21 Thread Jan Lehnardt
> On 21 May 2015, at 21:40, Alexander Shorin wrote: > > I think it worth to cross post to erlang-questions@ ML. Would you? if we don’t get any further here, sure :) — I just don’t want to make a fool of myself, should this be a simple answer and I feel more comfortable in this particular crowd,

[GitHub] couchdb-fauxton pull request: add spy.restore to mocha test

2015-05-21 Thread michellephung
GitHub user michellephung opened a pull request: https://github.com/apache/couchdb-fauxton/pull/431 add spy.restore to mocha test You can merge this pull request into a Git repository by running: $ git pull https://github.com/michellephung/couchdb-fauxton mocha-tests-fixes A

[GitHub] couchdb-fauxton pull request: Open up Databases table to be extend...

2015-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/425 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

Re: fsync() vs EINTR

2015-05-21 Thread Alexander Shorin
I think it worth to cross post to erlang-questions@ ML. Would you? -- ,,,^..^,,, On Thu, May 21, 2015 at 10:23 PM, Jan Lehnardt wrote: > Hi all, > > I stumbled across https://ldpreload.com/blog/signalfd-is-useless and wondered > how this squares against our use of fsync(). > > A quick glance at

[GitHub] couchdb-fauxton pull request: Open up Databases table to be extend...

2015-05-21 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/425#issuecomment-104394641 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

fsync() vs EINTR

2015-05-21 Thread Jan Lehnardt
Hi all, I stumbled across https://ldpreload.com/blog/signalfd-is-useless and wondered how this squares against our use of fsync(). A quick glance at https://github.com/erlang/otp/blob/master/erts/emulator/drivers/unix/unix_efile.c reveals that EINTR is handled in multiple places, but only in

Re: [COUCHDB-2214] Dashboard as main page

2015-05-21 Thread Dulanga Sashika
Hi all, I implemented the first widget in the dashboard. You can find it in https://github.com/wadsashika/couchdb-fauxton/tree/2214-Dashboard-as-main-page I didn't send a PR since I need to test the functionality more. I couldn't generate any active tasks to test this. Michelle told me about two w

[GitHub] couchdb-couch-mrview pull request: 2650 etag fixes

2015-05-21 Thread iilyak
Github user iilyak commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/18#discussion_r30819415 --- Diff: src/couch_mrview_util.erl --- @@ -1016,3 +1019,26 @@ get_view_queries({Props}) -> _ -> throw({bad_request,

[GitHub] couchdb-fauxton pull request: Index editor fixes

2015-05-21 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/430 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] couchdb-fauxton pull request: Index editor fixes

2015-05-21 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/430#issuecomment-104333138 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] couchdb-fauxton pull request: tests: run setup in parallel

2015-05-21 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/423#issuecomment-104332862 Looking promising. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not hav

[GitHub] couchdb-ets-lru pull request: Migrate the tests from etap to eunit

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-ets-lru/pull/1#issuecomment-104327486 merge it! ping me if you need help to push to the apache repos! --- If your project is set up for it, you can reply to this email and have your reply appea

[GitHub] couchdb-couch-mrview pull request: 2650 etag fixes

2015-05-21 Thread davisp
Github user davisp commented on a diff in the pull request: https://github.com/apache/couchdb-couch-mrview/pull/18#discussion_r30815269 --- Diff: src/couch_mrview_util.erl --- @@ -1016,3 +1019,26 @@ get_view_queries({Props}) -> _ -> throw({bad_request,

[GitHub] couchdb-couch pull request: Add test suite for Etag generation in ...

2015-05-21 Thread davisp
Github user davisp commented on the pull request: https://github.com/apache/couchdb-couch/pull/51#issuecomment-104322934 You should adding and removing documents in between requests so that you can verify that the etag changes appropriately. --- If your project is set up for it, you

[GitHub] couchdb-chttpd pull request: Handle Etag generation in one place

2015-05-21 Thread davisp
Github user davisp commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/34#issuecomment-104318793 Ah, found it. Reviewing the others as well. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-chttpd pull request: Handle Etag generation in one place

2015-05-21 Thread davisp
Github user davisp commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/34#issuecomment-104318654 This looks mostly good to me. I'm confused by the changes to add header manipulation functions in 9ab5b83 which don't appear to be used anywhere. Is there a corres

[GitHub] couchdb-fauxton pull request: Index editor fixes

2015-05-21 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/430#issuecomment-104318326 Cool thanks. I'll squash - Travis seems to have choked on that last one. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] couchdb-couch-mrview pull request: 2650 etag fixes

2015-05-21 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/18#issuecomment-104314536 Additional commits are pushed --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] couchdb-couch-mrview pull request: 2650 etag fixes

2015-05-21 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/18#issuecomment-104314559 Depends on https://github.com/apache/couchdb-couch/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] couchdb-couch pull request: Add test suite for Etag generation in ...

2015-05-21 Thread iilyak
GitHub user iilyak opened a pull request: https://github.com/apache/couchdb-couch/pull/51 Add test suite for Etag generation in mrview COUCHDB-2650 You can merge this pull request into a Git repository by running: $ git pull https://github.com/iilyak/couchdb-couch 2650-etag-fix

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/401#issuecomment-104232649 please join irc if you have questions --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/401#issuecomment-104231944 @nadeeshaan is don't see the changes, have you really pushed the branch? --- If your project is set up for it, you can reply to this email and have your

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/401#discussion_r30792351 --- Diff: app/addons/documents/views-rev-tree.js --- @@ -0,0 +1,23 @@ +define([ + "app", + "api", + "addons/documents/resour

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/401#issuecomment-104231722 cool! you also have to rebase against master and solve the conflict ping us on irc if you have questions regarding that --- If your project is s

[BLOG] The CouchDB Weekly News, May 21, is out!

2015-05-21 Thread Katharina Jockenhöfer
Hi everyone, this week's CouchDB Weekly News is out: http://blog.couchdb.org/2015/05/21/couchdb-weekly-news-may-21-2015/ Among the topics: - CouchDB website redesign - Transfer of Replication.io, and the adoption of the Nano

[GitHub] couchdb-fauxton pull request: Index editor fixes

2015-05-21 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/430#issuecomment-104191554 i added a fix for mango --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project d