[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-25 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/432#issuecomment-105182709 @benkeen a quick unit test for this would be great. Once you have a test +1 --- If your project is set up for it, you can reply to this email and have your

[GitHub] couchdb-fauxton pull request: Convert Design Doc Metadata page to ...

2015-05-25 Thread garrensmith
GitHub user garrensmith opened a pull request: https://github.com/apache/couchdb-fauxton/pull/435 Convert Design Doc Metadata page to React This converts the Design Doc Metadata page to use React.js instead of Backbone.js You can merge this pull request into a Git repository by

Fauxton React how far

2015-05-25 Thread Olafur Arason
Hi, I've looked at the Fauxton code before, then trying to fix a problem. I'm just wondering how far you are going to take the React conversion. I've been working on a couple of React project for my company for the last couple of months, so I can help. It seems like the code is heavily invested

Re: Fauxton React how far

2015-05-25 Thread Garren Smith
Hi Olaf, Thanks for bring this up. Ultimately we want to do a full conversion from Backbone.js to React + flux. This will take some time but we making good progress. Currently we are converting all Backbone Views into React.js. We are almost there. If you want to get involved this is a great

Re: On Plugins and Extensibility

2015-05-25 Thread Ilya Khlopotov
Paul, From what I can tell your proposing that couch_epi is a central nexus of some rather large swaths of code (ie, replacing the entire API to couch_stats). I am not proposing to replace couch_stats API. I just use couch_stats app as an example. we're left with a whole bunch of questions

Re: On Plugins and Extensibility

2015-05-25 Thread Alexander Shorin
Thanks, Paul. Your answers are good for me. -- ,,,^..^,,, On Fri, May 22, 2015 at 11:17 PM, Paul Davis paul.joseph.da...@gmail.com wrote: On Fri, May 22, 2015 at 2:37 PM, Alexander Shorin kxe...@gmail.com wrote: Hi Paul, Great proposal! Replied inline to preserve context. Bikeshed First

Re: On Plugins and Extensibility

2015-05-25 Thread Ilya Khlopotov
Hi Paul, Then any function exported by appname_funcs_mod (that wasn't a builtin function, though maybe even if so?) could be invoked by an API like such: couch_epi:invoke(my_function_name, Arg1, Arg2, Arg3). couch_epi:apply(my_function_name, Args). How you would implement

[GitHub] couchdb-couch-mrview pull request: 2650 etag fixes

2015-05-25 Thread iilyak
Github user iilyak closed the pull request at: https://github.com/apache/couchdb-couch-mrview/pull/18 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-couch-mrview pull request: 2650 etag fixes

2015-05-25 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/18#issuecomment-105229575 As Paul mentioned the approach will not work. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

Re: On Plugins and Extensibility

2015-05-25 Thread Alexander Shorin
On Mon, May 25, 2015 at 3:57 PM, Ilya Khlopotov iil...@ca.ibm.com wrote: Another example when this functionality is desired is before_doc_update. Imagine you want to stick extra field into user's profile. The only way to do it currently is modification of couch_users_db:before_doc_update. If

[GitHub] couchdb-couch pull request: Add test suite for Etag generation in ...

2015-05-25 Thread iilyak
Github user iilyak commented on the pull request: https://github.com/apache/couchdb-couch/pull/51#issuecomment-105229953 The work for fixes tested by this test suite need to be re-done --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] couchdb-couch pull request: Add test suite for Etag generation in ...

2015-05-25 Thread iilyak
Github user iilyak closed the pull request at: https://github.com/apache/couchdb-couch/pull/51 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb-fauxton pull request: Convert Design Doc Metadata page to ...

2015-05-25 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/435#issuecomment-105252630 Very nice! Code + functionality looks great. +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-25 Thread garrensmith
Github user garrensmith commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30985104 --- Diff: app/addons/activetasks/actions.js --- @@ -16,17 +16,18 @@ define([ ], function (FauxtonAPI, ActionTypes, Resources) {

Re: GSoC Begins!

2015-05-25 Thread Dulanga Sashika
Hi Robert, Of course we will trouble you :D I sent a PR yesterday. Feel free to load full of comment on that :D Thanks and Regards, Dulanga On Mon, May 25, 2015 at 10:28 PM, Alexander Shorin kxe...@gmail.com wrote: Hooray! -- ,,,^..^,,, On Mon, May 25, 2015 at 6:50 PM, Robert Kowalski

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-05-25 Thread arturmazurek
GitHub user arturmazurek opened a pull request: https://github.com/apache/couchdb-couch/pull/53 Fix duplicated Content-Type for show/update functions When a show/update function returned data it added a Content-Type: application/json header by itself. Then couch_httpd added

[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-25 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/432#issuecomment-105249664 No problem, added. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] couchdb-couch pull request: Fixing a build for Mac OS 10.10

2015-05-25 Thread janl
Github user janl commented on the pull request: https://github.com/apache/couchdb-couch/pull/52#issuecomment-105253339 I don’t see this breaking without this patch. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

GSoC Begins!

2015-05-25 Thread Robert Kowalski
Hi Dulanga, Hi Nadeeshaan, we are quite excited as this GSoC begins! Please join us in #couchdb-dev for ad-hoc questions, feel also free to use the mailing list for asking questions or ask questions in your GitHub PRs. Best, Robert

[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-25 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/432#issuecomment-105250009 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

2015-05-25 Thread janl
Github user janl commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-105253198 This seems to have to do with the *eventual* nature of a cluster :) Now this is failing, a little later than the previous one: ```

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

2015-05-25 Thread janl
Github user janl commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-105252240 The referenced PR that broke PouchDB tests against CouchDB master have been merged. Running the PouchDB tests with the linked repos as @nolanlawson

[GitHub] couchdb-fauxton pull request: Another testing PR to check the NW t...

2015-05-25 Thread benkeen
Github user benkeen closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/429 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/432 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-25 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-105252973 @michellephung nice work this is great. One small change. After that +1. --- If your project is set up for it, you can reply to this email and have your

[GitHub] couchdb-fauxton pull request: Convert Design Doc Metadata page to ...

2015-05-25 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/435 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

Re: fsync() vs EINTR

2015-05-25 Thread Jan Lehnardt
Thanks Paul! My only worry is that in delayed_commits the 1s guarantee goes to 2s, but I think in an error scenario, how much data you lose is less of an issue. Plus this is a feature on the way out. No action required, IMHO, except maybe document this. Best Jan -- On 22 May 2015, at 00:28,

Re: On Plugins and Extensibility

2015-05-25 Thread Jan Lehnardt
On 22 May 2015, at 00:29, Paul Davis paul.joseph.da...@gmail.com wrote: Hey everyone, So I've been meaning to write this email for sometime but have been kept busy with lots of super fun things that are super fun. Anyway, I just wanted to get this out there to start getting feed back

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-05-25 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/53#issuecomment-105247728 Thanks for the patch! Can you provide tests for your changes? Also, for CouchDB 2.0 you fixed problem only on local interface, while for

Re: GSoC Begins!

2015-05-25 Thread Alexander Shorin
Hooray! -- ,,,^..^,,, On Mon, May 25, 2015 at 6:50 PM, Robert Kowalski r...@kowalski.gd wrote: Hi Dulanga, Hi Nadeeshaan, we are quite excited as this GSoC begins! Please join us in #couchdb-dev for ad-hoc questions, feel also free to use the mailing list for asking questions or ask

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/434#issuecomment-105282691 please remove the space around the `=` when writing markup --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-fauxton pull request: Gsoc 2015 revision tree visualizatio...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/433#discussion_r30989957 --- Diff: app/addons/documents/revision-tree/component.react.jsx --- @@ -0,0 +1,338 @@ +define([ + app, + api, + react,

[GitHub] couchdb-fauxton pull request: Gsoc 2015 revision tree visualizatio...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/433#discussion_r30990280 --- Diff: app/addons/documents/index-results/index-results.components.react.jsx --- @@ -53,10 +53,22 @@ function (app, FauxtonAPI, React,

[GitHub] couchdb-fauxton pull request: Gsoc 2015 revision tree visualizatio...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/433#discussion_r30990140 --- Diff: app/addons/documents/resources.js --- @@ -619,5 +619,43 @@ function (app, FauxtonAPI, Documents, PagingCollection) { },

[GitHub] couchdb-fauxton pull request: Gsoc 2015 revision tree visualizatio...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/433#discussion_r30990152 --- Diff: app/addons/documents/revision-tree/component.react.jsx --- @@ -0,0 +1,338 @@ +define([ + app, + api, + react,

[GitHub] couchdb-couch pull request: Fixing a build for Mac OS 10.10

2015-05-25 Thread arturmazurek
Github user arturmazurek commented on the pull request: https://github.com/apache/couchdb-couch/pull/52#issuecomment-105274193 Odd, definitely happens for me. Yosemite 10.10.3 and CC Apple LLVM version 6.1.0 (clang-602.0.53) (based on LLVM 3.6.0svn) Calling `cc -Xlinker -v`

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-05-25 Thread arturmazurek
Github user arturmazurek closed the pull request at: https://github.com/apache/couchdb-couch/pull/53 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r30989764 --- Diff: app/addons/dashboard/components.react.jsx --- @@ -0,0 +1,184 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r30989741 --- Diff: app/addons/dashboard/resources.js --- @@ -0,0 +1,30 @@ +// Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-fauxton pull request: Gsoc 2015 revision tree visualizatio...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/433#issuecomment-105284795 Hi Nadeeshaan, super cool, the code makes a lot of progress. I just left some comments, today is a public holiday but I will be back

[GitHub] couchdb-fauxton pull request: sauce labs

2015-05-25 Thread michellephung
GitHub user michellephung opened a pull request: https://github.com/apache/couchdb-fauxton/pull/436 sauce labs You can merge this pull request into a Git repository by running: $ git pull https://github.com/michellephung/couchdb-fauxton test-sauce Alternatively you can

[GitHub] couchdb-fauxton pull request: Gsoc 2015 revision tree visualizatio...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/433#discussion_r30989987 --- Diff: app/addons/documents/revision-tree/component.react.jsx --- @@ -0,0 +1,338 @@ +define([ + app, + api, + react,

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-05-25 Thread arturmazurek
Github user arturmazurek commented on the pull request: https://github.com/apache/couchdb-couch/pull/53#issuecomment-105274678 Ok, I'll add the tests and also check the cluster interface. --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/434#issuecomment-105283090 looks really really good! added some notes... --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] couchdb-fauxton pull request: Gsoc 2015 revision tree visualizatio...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/433#discussion_r30990099 --- Diff: app/addons/documents/index-results/index-results.components.react.jsx --- @@ -53,10 +53,22 @@ function (app, FauxtonAPI, React,

[GitHub] couchdb-fauxton pull request: Gsoc 2015 revision tree visualizatio...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/433#discussion_r30990050 --- Diff: app/addons/documents/revision-tree/component.react.jsx --- @@ -0,0 +1,338 @@ +define([ + app, + api, + react,

[GitHub] couchdb-fauxton pull request: Gsoc 2015 revision tree visualizatio...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/433#discussion_r30990128 --- Diff: app/addons/documents/index-results/index-results.components.react.jsx --- @@ -53,10 +53,22 @@ function (app, FauxtonAPI, React,

[GitHub] couchdb-fauxton pull request: Gsoc 2015 revision tree visualizatio...

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/433#discussion_r30989868 --- Diff: app/addons/documents/revision-tree/component.react.jsx --- @@ -0,0 +1,338 @@ +define([ + app, + api, + react,

Re: [GitHub] couchdb-fauxton pull request: tests: run setup in parallel

2015-05-25 Thread Robert Kowalski
i will prepare an email to dev tomorrow when i am back at work On Tue, May 26, 2015 at 12:24 AM, benkeen g...@git.apache.org wrote: Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/423#issuecomment-105326264 Cool! I'm +1 for merging.

[GitHub] couchdb-fauxton pull request: tests: run setup in parallel

2015-05-25 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/423#issuecomment-105330712 lol i love the asfbot default picture --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] couchdb-couch pull request: Fixing a build for Mac OS 10.10

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-couch/pull/52#issuecomment-105363347 I also can not confirm that error - @arturmazurek did you install brew just for couchdb? do brew installs run fine for you in general? did you source your

[GitHub] couchdb-fauxton pull request: tests: run setup in parallel

2015-05-25 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/423#issuecomment-105326264 Cool! I'm +1 for merging. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-fauxton pull request: sauce labs

2015-05-25 Thread michellephung
Github user michellephung closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/436 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] couchdb-fauxton pull request: tests: run setup in parallel

2015-05-25 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/423#issuecomment-105326151 @benkeen 7 green runs in a row - i would call that pretty stable now --- If your project is set up for it, you can reply to this email and have your