[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork

Github user mikewallace1979 commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/20#discussion_r31825317 --- Diff: src/fabric_doc_open.erl --- @@ -30,7 +30,12 @@ go(DbName, Id, Options) - -Workers =

[GitHub] couchdb-fauxton pull request: Workaround for React oddity

GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/456 Workaround for React oddity React does some odd stuff with the DOM like inserting noscript tags to keep track of rendering info. In this instance it was optionally inserting the

[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork

Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/20#discussion_r31825108 --- Diff: src/fabric_doc_open.erl --- @@ -30,7 +30,12 @@ go(DbName, Id, Options) - -Workers =

[GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...

Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-replicator/pull/11 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork

Github user mikewallace1979 commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/20#discussion_r31825883 --- Diff: src/fabric_doc_open.erl --- @@ -30,7 +30,12 @@ go(DbName, Id, Options) - -Workers =

[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork

Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/20#discussion_r31825932 --- Diff: src/fabric_doc_open.erl --- @@ -30,7 +30,12 @@ go(DbName, Id, Options) - -Workers =

[GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...

Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/11#issuecomment-109324320 +1 Don't forget squash things (: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] couchdb-fauxton pull request: Workaround for React oddity

Github user benkeen closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/456 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-fauxton pull request: React sidebar

Github user benkeen commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/455#discussion_r31853246 --- Diff: app/addons/documents/sidebar/stores.js --- @@ -0,0 +1,146 @@ +// Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-fauxton pull request: Workaround for React oddity

Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/456#issuecomment-109416050 Nahh! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-fauxton pull request: React sidebar

Github user benkeen commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/455#discussion_r31852996 --- Diff: app/addons/components/react-components.react.jsx --- @@ -445,6 +445,62 @@ function (app, FauxtonAPI, React, Components, ace,

[GitHub] couchdb-fauxton pull request: React sidebar

Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/455#issuecomment-109445537 +1 Looks awesome. Code + functionality looks great - just a couple of very minor things I mentioned above. --- If your project is set up for it, you can

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r31855783 --- Diff: app/addons/dashboard/assets/less/dashboard.less --- @@ -0,0 +1,104 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

Github user benkeen commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r31858594 --- Diff: app/addons/dashboard/components.react.jsx --- @@ -0,0 +1,190 @@ +// Licensed under the Apache License, Version 2.0 (the License); you

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/434#issuecomment-109458344 nice I really like the link!!! - we should try with to default darker red for the link, then when you hover over it, the color is the

[GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...

Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31820430 --- Diff: src/couch_replicator_api_wrap.erl --- @@ -83,9 +83,16 @@ db_open(#httpdb{} = Db1, _Options, Create) - ok

[GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...

Github user mikewallace1979 commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31819938 --- Diff: src/couch_replicator_api_wrap.erl --- @@ -83,9 +83,16 @@ db_open(#httpdb{} = Db1, _Options, Create) -