[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread jaydoane
Github user jaydoane commented on the pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2#issuecomment-197741520 Commit message now wrapped --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2#issuecomment-197727400 One moment: commit message should be wrapped by 79/80 characters per line. And then +1 (: Thanks! --- If your project is set up for it, you can

Re: Multiple database backup strategy

2016-03-19 Thread Benjamin Bastian
When a shard is updated, it'll trigger a "database updated" event. CouchDB will hold those updates in memory for a configurable amount of time in order to dedupe updates. It'll then cast lists of updated databases to nodes which host the relevant _db_updates shards for further deduplication. It's

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread eiri
Github user eiri commented on a diff in the pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2#discussion_r56441052 --- Diff: src/couch_log_lager.erl --- @@ -64,10 +64,9 @@ emergency(Fmt, Args) -> -spec set_level(atom()) -> ok. set_level(Level)

Re: Multiple database backup strategy

2016-03-19 Thread Adam Kocoloski
Hi Bob, comments inline: > On Mar 19, 2016, at 2:36 PM, Robert Samuel Newson wrote: > > Hi, > > The problem is that _db_updates is not guaranteed to see every update, so I > think it falls at the first hurdle. Do you mean to say that a listener of _db_updates is not

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2#issuecomment-197785419 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

Re: Multiple database backup strategy

2016-03-19 Thread Robert Samuel Newson
Hi, The problem is that _db_updates is not guaranteed to see every update, so I think it falls at the first hurdle. What couch_replicator_manager does in couchdb 2.0 (though not in the version that Cloudant originally contributed) is to us ecouch_event, notice which are to _replicator shards,

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-couch-log-lager/pull/2 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread eiri
Github user eiri commented on the pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2#issuecomment-197638745 lgtm --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this