[GitHub] couchdb-fauxton pull request: Fixes to creating views

2014-10-01 Thread drsm79
Github user drsm79 commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/75#discussion_r18278924 --- Diff: app/addons/documents/views-index.js --- @@ -524,7 +526,7 @@ function(app, FauxtonAPI, Components, Documents, Databases, pouchdb

[GitHub] couchdb pull request: Fauxton View improvements

2014-07-01 Thread drsm79
Github user drsm79 commented on the pull request: https://github.com/apache/couchdb/pull/254#issuecomment-47659961 LGTM - maybe worth squashing the first two commits and doing the stale fix in another PR --- If your project is set up for it, you can reply to this email and have your

[GitHub] couchdb pull request: Fauxton View improvements

2014-07-01 Thread drsm79
Github user drsm79 commented on a diff in the pull request: https://github.com/apache/couchdb/pull/254#discussion_r14405549 --- Diff: src/fauxton/app/addons/documents/resources.js --- @@ -482,6 +482,14 @@ function(app, FauxtonAPI, PagingCollection

[GitHub] couchdb pull request: 2071 better create db ui

2014-05-15 Thread drsm79
Github user drsm79 commented on the pull request: https://github.com/apache/couchdb/pull/155#issuecomment-43082545 It didn't - I've not had a chance to address the issue @BigBlueHat raised. That seems like a general issue - I was thinking of adding a listener for the route event

[GitHub] couchdb pull request: 2071 better create db ui

2014-02-25 Thread drsm79
Github user drsm79 commented on the pull request: https://github.com/apache/couchdb/pull/155#issuecomment-36064001 I'd like to squash these before merge --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb pull request: 2071 better create db ui

2014-02-21 Thread drsm79
GitHub user drsm79 opened a pull request: https://github.com/apache/couchdb/pull/155 2071 better create db ui Also fixes COUCHDB-2086 - one word change. You can merge this pull request into a Git repository by running: $ git pull https://github.com/drsm79/couchdb 2071-better

couchdb pull request: 2038 improve db delete confirmation

2014-01-29 Thread drsm79
Github user drsm79 closed the pull request at: https://github.com/apache/couchdb/pull/140

couchdb pull request: 2038 improve db delete confirmation

2014-01-26 Thread drsm79
GitHub user drsm79 opened a pull request: https://github.com/apache/couchdb/pull/140 2038 improve db delete confirmation This adds a github like modal for confirming database deletion. There's scope to dry the code further - making a ModalView to have the various modals inherit