[GitHub] couchdb pull request #460: Change snap packaging to build from source

2017-03-20 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb/pull/460#discussion_r106922187 --- Diff: snapcraft.yaml --- @@ -0,0 +1,81 @@ +name: couchdb +version: 2.0 +summary: Document based database +description: CouchDB is a

[GitHub] couchdb pull request #460: Change snap packaging to build from source

2017-03-20 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb/pull/460#discussion_r106920400 --- Diff: snapcraft.yaml --- @@ -0,0 +1,81 @@ +name: couchdb +version: 2.0 +summary: Document based database +description: CouchDB is a

[GitHub] couchdb issue #328: Validate host header

2017-03-19 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/328 Let it flow here for a liitle while. Will close it very soon. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] couchdb issue #328: Validate host header

2017-03-19 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/328 @wohali Yes I do and yes this feature is already in 2.0. See referenced commits in commit message (; --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] couchdb issue #284: Backport Accept check from chttpd

2017-03-19 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/284 @wohali Sure. Bookmarked. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] couchdb issue #453: update Fauxton and Docs git repo urls

2017-03-09 Thread kxepal
Github user kxepal commented on the issue: https://github.com/apache/couchdb/pull/453 I'm with @wohali. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes s

[GitHub] couchdb-fauxton pull request #656: Add pull request template

2017-03-09 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/656#discussion_r105119372 --- Diff: .github/PULL_REQUEST_TEMPLATE.md --- @@ -0,0 +1,37 @@ + + +## Overview + + + +## Testing recommendations

[GitHub] couchdb-fauxton pull request #656: Add pull request template

2017-03-09 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/656#discussion_r105106053 --- Diff: .github/PULL_REQUEST_TEMPLATE.md --- @@ -0,0 +1,37 @@ + + +## Overview + + + +## Testing recommendations

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2#issuecomment-197727400 One moment: commit message should be wrapped by 79/80 characters per line. And then +1 (: Thanks! --- If your project is set up for it, you can

[GitHub] couchdb-couch-log-lager pull request: Get lager event handlers fro...

2016-03-19 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-log-lager/pull/2#issuecomment-197785419 Thank you! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-ci pull request:

2016-02-27 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-ci/commit/045028834477dce9c4e26d6909896f0c64ef4d44#commitcomment-16371266 In utils/analyze-jenkins-logs/ci-errors.markdown: In utils/analyze-jenkins-logs/ci-errors.markdown on line 1: Ok then

[GitHub] couchdb-ci pull request:

2016-02-27 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-ci/commit/045028834477dce9c4e26d6909896f0c64ef4d44#commitcomment-16371260 In utils/analyze-jenkins-logs/index.js: In utils/analyze-jenkins-logs/index.js on line 1: License header required

[GitHub] couchdb-ci pull request:

2016-02-27 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-ci/commit/045028834477dce9c4e26d6909896f0c64ef4d44#commitcomment-16371258 In utils/auto-download-jenkins-logs/index.js: In utils/auto-download-jenkins-logs/index.js on line 1: License header

[GitHub] couchdb-ci pull request:

2016-02-27 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-ci/commit/045028834477dce9c4e26d6909896f0c64ef4d44#commitcomment-16371246 In utils/analyze-jenkins-logs/ci-errors.markdown: In utils/analyze-jenkins-logs/ci-errors.markdown on line 1: Does this

[GitHub] couchdb-ci pull request:

2016-02-27 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-ci/commit/045028834477dce9c4e26d6909896f0c64ef4d44#commitcomment-16371247 In utils/analyze-jenkins-logs/bin/run.sh: In utils/analyze-jenkins-logs/bin/run.sh on line 1: Does this file committed

[GitHub] couchdb-ci pull request: [wip] Docker container Ubuntu 14.04/Erlan...

2015-12-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-ci/pull/1#discussion_r48253451 --- Diff: ansible/roles/ubuntu-worker/tasks/dependencies.yml --- @@ -0,0 +1,59 @@ +- name: import the Erlang Solutions key into apt + apt_key

[GitHub] couchdb-ci pull request: Docker container Ubuntu 14.04/Erlang 18.2...

2015-12-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-ci/pull/1#discussion_r48252688 --- Diff: ansible/roles/ubuntu-worker/tasks/rebar.yml --- @@ -0,0 +1,37 @@ +- name: create rebar group + group: +name: rebar +state

[GitHub] couchdb-ci pull request: Docker container Ubuntu 14.04/Erlang 18.2...

2015-12-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-ci/pull/1#discussion_r48252154 --- Diff: ansible/roles/ubuntu-worker/tasks/dependencies.yml --- @@ -0,0 +1,59 @@ +- name: import the Erlang Solutions key into apt + apt_key

[GitHub] couchdb-ci pull request: Docker container Ubuntu 14.04/Erlang 18.2...

2015-12-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-ci/pull/1#discussion_r48251847 --- Diff: readme.markdown --- @@ -3,44 +3,80 @@ CouchDB CI Setup Mission statement: Create a new continuous integration infrastructure for the

[GitHub] couchdb-ci pull request: Docker container Ubuntu 14.04/Erlang 18.2...

2015-12-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-ci/pull/1#discussion_r48251780 --- Diff: readme.markdown --- @@ -3,44 +3,80 @@ CouchDB CI Setup Mission statement: Create a new continuous integration infrastructure for the

[GitHub] couchdb-ci pull request: Docker container Ubuntu 14.04/Erlang 18.2...

2015-12-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-ci/pull/1#discussion_r48251720 --- Diff: ansible/roles/ubuntu-worker/tasks/rebar.yml --- @@ -0,0 +1,37 @@ +- name: create rebar group + group: +name: rebar +state

[GitHub] couchdb-ci pull request: Docker container Ubuntu 14.04/Erlang 18.2...

2015-12-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-ci/pull/1#discussion_r48251635 --- Diff: ansible/roles/ubuntu-worker/tasks/dependencies.yml --- @@ -0,0 +1,59 @@ +- name: import the Erlang Solutions key into apt + apt_key

[GitHub] couchdb-ci pull request: Docker container Ubuntu 14.04/Erlang 18.2...

2015-12-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-ci/pull/1#discussion_r48251592 --- Diff: ansible/roles/ubuntu-worker/tasks/dependencies.yml --- @@ -0,0 +1,59 @@ +- name: import the Erlang Solutions key into apt + apt_key

[GitHub] couchdb-ci pull request: Docker container Ubuntu 14.04/Erlang 18.2...

2015-12-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-ci/pull/1#discussion_r48251579 --- Diff: ansible/roles/ubuntu-worker/tasks/dependencies.yml --- @@ -0,0 +1,59 @@ +- name: import the Erlang Solutions key into apt + apt_key

[GitHub] couchdb-ci pull request: Docker container Ubuntu 14.04/Erlang 18.2...

2015-12-22 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-ci/pull/1#discussion_r48251560 --- Diff: ansible/roles/ubuntu-worker/tasks/dependencies.yml --- @@ -0,0 +1,59 @@ +- name: import the Erlang Solutions key into apt + apt_key

[GitHub] couchdb-couch-log-lager pull request: Reset error_logger_tty handl...

2015-10-08 Thread kxepal
GitHub user kxepal opened a pull request: https://github.com/apache/couchdb-couch-log-lager/pull/1 Reset error_logger_tty handler only if it was already specified You can merge this pull request into a Git repository by running: $ git pull https://github.com/kxepal/couchdb

[GitHub] couchdb-couch-epi pull request: Add couch_epi:is_configured

2015-07-29 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-epi/pull/2#issuecomment-125988283 agree (: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-couch-epi pull request: Restore R14 compatibility

2015-07-22 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-epi/pull/5#issuecomment-123643874 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-couch-epi pull request: Fix function_clause in childspec

2015-07-13 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-epi/pull/3#issuecomment-120914152 Btw, may be also update start_link signature? ``` start_link(ProviderApp, {epi_key, ServiceId}, {modules, Modules}, Options) ``` to

[GitHub] couchdb-couch-epi pull request: Fix function_clause in childspec

2015-07-13 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-epi/pull/3#issuecomment-120911056 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] couchdb-couch-epi pull request: Add couch_epi:is_configured

2015-07-12 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-epi/pull/2#discussion_r34421707 --- Diff: src/couch_epi_functions_gen.erl --- @@ -309,6 +309,11 @@ remove_from_definitions(Defs, Source) -> {[], Defs}

[GitHub] couchdb-couch-epi pull request: First version

2015-06-24 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-epi/pull/1#issuecomment-115025272 Great work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-couch-epi pull request: First version

2015-06-24 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-epi/pull/1#discussion_r33202291 --- Diff: test/couch_epi_tests.erl --- @@ -0,0 +1,491 @@ +-module(couch_epi_tests). + +-include_lib("couch/include/couch_euni

[GitHub] couchdb-couch-epi pull request: First version

2015-06-24 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-epi/pull/1#discussion_r33202139 --- Diff: test/couch_epi_tests.erl --- @@ -0,0 +1,491 @@ +-module(couch_epi_tests). --- End diff -- License header is missed

[GitHub] couchdb-couch-epi pull request: First version

2015-06-24 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-epi/pull/1#discussion_r33202104 --- Diff: test/couch_epi_data_source_tests.erl --- @@ -0,0 +1,78 @@ +-module(couch_epi_data_source_tests). --- End diff -- License

[GitHub] couchdb-couch-epi pull request: First version

2015-06-24 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-epi/pull/1#discussion_r33202118 --- Diff: test/couch_epi_functions_tests.erl --- @@ -0,0 +1,114 @@ +-module(couch_epi_functions_tests). --- End diff -- License

[GitHub] couchdb-config pull request: 2708 stronger testing for config set

2015-06-10 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-config/pull/3#issuecomment-110699091 @rnewson I'm +1 for abandon since 1.x worked fine with for all the cases, but don't see any reasons for introducing BC as it never was a case.

[GitHub] couchdb-config pull request: 2708 stronger testing for config set

2015-06-09 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-config/pull/3#discussion_r32050277 --- Diff: src/config.erl --- @@ -177,9 +182,19 @@ delete(Section, Key, Reason) -> delete(Sec, Key, Persist, Reason) when is_binary(Sec)

[GitHub] couchdb-fauxton pull request: [WIP] Zen mode

2015-06-08 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/458#issuecomment-110120827 Why code highlight is different in dark/light modes? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork

2015-06-05 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/20#discussion_r31825932 --- Diff: src/fabric_doc_open.erl --- @@ -30,7 +30,12 @@ go(DbName, Id, Options) -> -Workers = fabric_util:submit_jobs(m

[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork

2015-06-05 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/20#discussion_r31825108 --- Diff: src/fabric_doc_open.erl --- @@ -30,7 +30,12 @@ go(DbName, Id, Options) -> -Workers = fabric_util:submit_jobs(m

[GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...

2015-06-05 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch-replicator/pull/11#issuecomment-109324320 +1 Don't forget squash things (: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as wel

[GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...

2015-06-05 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31820430 --- Diff: src/couch_replicator_api_wrap.erl --- @@ -83,9 +83,16 @@ db_open(#httpdb{} = Db1, _Options, Create) ->

[GitHub] couchdb-config pull request: 2708 stronger testing for config set

2015-06-04 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-config/pull/3#discussion_r31735649 --- Diff: src/config.erl --- @@ -177,9 +182,19 @@ delete(Section, Key, Reason) -> delete(Sec, Key, Persist, Reason) when is_binary(Sec)

[GitHub] couchdb-config pull request: 2708 stronger testing for config set

2015-06-04 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-config/pull/3#discussion_r31735209 --- Diff: src/config.erl --- @@ -177,9 +182,19 @@ delete(Section, Key, Reason) -> delete(Sec, Key, Persist, Reason) when is_binary(Sec)

[GitHub] couchdb-config pull request: 2708 stronger testing for config set

2015-06-04 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-config/pull/3#discussion_r31729178 --- Diff: src/config.erl --- @@ -177,9 +182,19 @@ delete(Section, Key, Reason) -> delete(Sec, Key, Persist, Reason) when is_binary(Sec)

[GitHub] couchdb-fabric pull request: Merge diff from cloudant fork

2015-06-03 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/20#discussion_r31626817 --- Diff: src/fabric.erl --- @@ -161,7 +162,12 @@ get_all_security(DbName, Options) -> {error, any()} | {error, any() |

[GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...

2015-06-03 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31619297 --- Diff: src/couch_replicator_api_wrap.erl --- @@ -83,9 +83,16 @@ db_open(#httpdb{} = Db1, _Options, Create) ->

[GitHub] couchdb-config pull request: 2708 stronger testing for config set

2015-06-03 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-config/pull/3#discussion_r31618881 --- Diff: src/config.erl --- @@ -177,9 +182,19 @@ delete(Section, Key, Reason) -> delete(Sec, Key, Persist, Reason) when is_binary(Sec)

[GitHub] couchdb-couch pull request: perf: increase performance of http han...

2015-06-02 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/57#issuecomment-108122239 4% speedup isn't significant gain as CouchDB 2.0 now is about 7 times slower than 1.6.1 due to cluster routines, even with a single node. --- If your proje

[GitHub] couchdb-couch pull request: perf: increase performance of http han...

2015-06-02 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/57#issuecomment-108121847 -1 This change blocks the way to solve the following issues: - https://issues.apache.org/jira/browse/COUCHDB-1278 - https://issues.apache.org/jira/browse

[GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...

2015-06-02 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31571434 --- Diff: src/couch_replicator_api_wrap.erl --- @@ -83,9 +83,16 @@ db_open(#httpdb{} = Db1, _Options, Create) ->

[GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...

2015-06-02 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31550867 --- Diff: src/couch_replicator_api_wrap.erl --- @@ -83,9 +83,16 @@ db_open(#httpdb{} = Db1, _Options, Create) ->

[GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...

2015-06-02 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31549841 --- Diff: src/couch_replicator_manager.erl --- @@ -451,7 +487,14 @@ maybe_start_replication(State, DbName, DocId, RepDoc

[GitHub] couchdb-couch-replicator pull request: 2707 merge couch replicator...

2015-06-02 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch-replicator/pull/11#discussion_r31549741 --- Diff: src/couch_replicator_api_wrap.erl --- @@ -83,9 +83,16 @@ db_open(#httpdb{} = Db1, _Options, Create) ->

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-06-01 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/55#issuecomment-107696253 @arturmazurek Please fix the following issues in amend commit: ``` 55.patch:54: trailing whitespace. 55.patch:85: trailing whitespace

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-06-01 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/55#issuecomment-107670149 @arturmazurek thanks! Let me check it, but LGFM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] couchdb-couch pull request: perf: http layer - cache couchdb versi...

2015-05-29 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/56#issuecomment-106906983 @robertkowalski if you update commit message to make it actual and shorter (no need to explain there about flamegraphs and benchmark, but about what it does and

[GitHub] couchdb-couch pull request: perf: http layer - cache couchdb versi...

2015-05-29 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/56#issuecomment-106885439 Alternative solution: ``` diff --git a/src/couch_server.erl b/src/couch_server.erl index 228edc3..48046c6 100644 --- a/src/couch_server.erl

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-05-27 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/55#discussion_r31206220 --- Diff: src/couch_httpd.erl --- @@ -30,6 +30,7 @@ -export([send_json/2,send_json/3,send_json/4,last_chunk/1,parse_multipart_request/3

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

2015-05-27 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-106053906 @nolanlawson thanks, that works, but now I recall that node-gyp tried to build broken v8 for my host. *sigh* it doesn't simply to build pouchdb /: Downlo

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

2015-05-27 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-106041063 @janl @nolanlawson need your help with: ``` $ npm link ../express-pouchdb npm ERR! Error: EACCES: permission denied, symlink '/home/k

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

2015-05-27 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-106021935 @janl what the test you ran? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-05-26 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/55#issuecomment-105569926 Thanks! Basically, looks good, but left a few commentaries about the implementation. --- If your project is set up for it, you can reply to this email and have

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-05-26 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/55#discussion_r31046925 --- Diff: test/couch_httpd_headers_tests.erl --- @@ -0,0 +1,55 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); yo

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-05-26 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/55#discussion_r31046984 --- Diff: test/couch_httpd_headers_tests.erl --- @@ -0,0 +1,55 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); yo

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-05-26 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/55#discussion_r31046557 --- Diff: test/couch_httpd_headers_tests.erl --- @@ -0,0 +1,55 @@ +% Licensed under the Apache License, Version 2.0 (the "License"); yo

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-05-26 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/55#discussion_r31046410 --- Diff: src/couch_httpd.erl --- @@ -30,6 +30,7 @@ -export([send_json/2,send_json/3,send_json/4,last_chunk/1,parse_multipart_request/3

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-05-26 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/55#discussion_r31046121 --- Diff: src/couch_httpd.erl --- @@ -745,6 +739,19 @@ start_json_response(Req, Code, Headers) -> end_json_response(Resp) -> send

[GitHub] couchdb-couch pull request: Fix `active_size` format conversion in...

2015-05-26 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/54#issuecomment-105524431 @eiri by migrate you mean simple copy-paste db file from 1.x to 2.0 database directory? And what's the different between DBCore and CouchDB 1.x? --- If

[GitHub] couchdb-couch pull request: Fix `active_size` format conversion in...

2015-05-26 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/54#issuecomment-105521023 How it's possible to reproduce such case? Never saw any problem with sizes for db info. --- If your project is set up for it, you can reply to this email and

[GitHub] couchdb-couch pull request: Fix duplicated Content-Type for show/u...

2015-05-25 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/53#issuecomment-105247728 Thanks for the patch! Can you provide tests for your changes? Also, for CouchDB 2.0 you fixed problem only on local interface, while for [cluster|https

[GitHub] couchdb-couch pull request: Fixing a build for Mac OS 10.10

2015-05-23 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/52#issuecomment-104901697 Thanks for the patch! LGFM. @janl @robertkowalski could you confirm? --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-fabric pull request: 2526 pending updates info

2015-05-12 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fabric/pull/9#issuecomment-101401278 All merged. Thanks! (: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] couchdb-chttpd pull request: Dynamic endpoints handlers

2015-05-12 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/10#issuecomment-101317048 @hdiedrich Hey! Config support suddenly is needed by the following reasons: - It saved us many times when security issue was found in some HTTP handler

[GitHub] couchdb-fabric pull request: 2526 pending updates info

2015-05-11 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fabric/pull/9#issuecomment-101017730 Oh, I wonder why it still now. Will check it now and merge if everything is ok. --- If your project is set up for it, you can reply to this email and have your

[GitHub] couchdb-fauxton pull request: Fauxton Server for use with NPM

2015-05-11 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/395#issuecomment-100890680 @garrensmith Few more to come: - COUCHDB-2244; - COUCHDB-2243; - COUCHDB-2476; - When user tries to change own password, Fauxton forbids that

[GitHub] couchdb-fauxton pull request: Fauxton Server for use with NPM

2015-05-11 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/395#issuecomment-100825582 @garrensmith sure! will also check it again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] couchdb-chttpd pull request: Escape database name on posts to _rep...

2015-05-08 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/35#issuecomment-100331205 It would be also good to have some test on this. Again, this issue was found by third party project. --- If your project is set up for it, you can reply to this

[GitHub] couchdb-chttpd pull request: Escape database name on posts to _rep...

2015-05-08 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-chttpd/pull/35#discussion_r29967748 --- Diff: src/chttpd.erl --- @@ -315,9 +315,13 @@ replication_uri(Type, PostProps) -> {Props} -> couch_util:get_value(

[GitHub] couchdb-fauxton pull request: Detect if we run on a backdoor port

2015-05-07 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/400#discussion_r29853372 --- Diff: app/app.js --- @@ -126,7 +126,30 @@ function (app, $, _, Backbone, Bootstrap, Helpers, Utils, FauxtonAPI, Couchdb) { type

[GitHub] couchdb-fauxton pull request: Detect if we run on a backdoor port

2015-05-07 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/400#discussion_r29847412 --- Diff: app/app.js --- @@ -126,7 +126,30 @@ function (app, $, _, Backbone, Bootstrap, Helpers, Utils, FauxtonAPI, Couchdb) { type

[GitHub] couchdb-couch pull request: Add test suite for global_changes

2015-05-06 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-couch/pull/47#issuecomment-99484616 Could you rebase your PR for no-ff merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-couch pull request: Refactor/multipart stream

2015-05-06 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/19#discussion_r29760699 --- Diff: src/couch_db_updater.erl --- @@ -605,10 +605,41 @@ init_db(DbName, Filepath, Fd, Header0, Options) -> Db

[GitHub] couchdb-couch pull request: Refactor/multipart stream

2015-05-05 Thread kxepal
Github user kxepal commented on a diff in the pull request: https://github.com/apache/couchdb-couch/pull/19#discussion_r29682825 --- Diff: src/couch_db_updater.erl --- @@ -605,10 +605,41 @@ init_db(DbName, Filepath, Fd, Header0, Options) -> Db

[GitHub] couchdb-fauxton pull request: Fauxton Server for use with NPM

2015-05-05 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/395#issuecomment-99076084 Ok, I take back my "works perfectly" words, sorry (: --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] couchdb-fauxton pull request: Fauxton Server for use with NPM

2015-05-05 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/395#issuecomment-99075961 Also, this page has some weird behaviour: 1. Create some view function here 2. Go to ddoc 3. Edit view function in JSON doc 4. Go back to view

[GitHub] couchdb-fauxton pull request: Fauxton Server for use with NPM

2015-05-05 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/395#issuecomment-99075552 On view index edit page: ``` Could not locate /home/kxepal/tmp/node_modules/fauxton/dist/release/_utils/js/ace/mode-javascript.js ``` --- If your

[GitHub] couchdb-fauxton pull request: Fauxton Server for use with NPM

2015-05-05 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/395#issuecomment-99074590 Default map function contains very awkward code: ``` function (keys, values, rereduce) { if (rereduce) { return sum(values); } else

[GitHub] couchdb-fauxton pull request: Fauxton Server for use with NPM

2015-05-05 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/395#issuecomment-99074167 Failed to clone document: ``` Could not duplicate document, reason: {"error":"ENOENT: no such file or directory, stat '/home/kxe

[GitHub] couchdb-fauxton pull request: Fauxton Server for use with NPM

2015-05-05 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/395#issuecomment-99073962 Failed to upload attachment: ``` Could not upload document: undefined ``` In console: ``` Could not locate /home/kxepal/tmp

[GitHub] couchdb-fauxton pull request: Fauxton Server for use with NPM

2015-05-05 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/395#issuecomment-99073341 Polling interval for active tasks is set as 5 seconds, but actually my Firefox 37 doing one request every 5 milliseconds. --- If your project is set up for it

[GitHub] couchdb-fauxton pull request: Fauxton Server for use with NPM

2015-05-05 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/395#issuecomment-99073097 Seems like changes feed page is broken as well: ``` Could not locate /home/kxepal/tmp/node_modules/fauxton/dist/release/a/_changes?limit=100

[GitHub] couchdb-fauxton pull request: Fauxton Server for use with NPM

2015-05-05 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/395#issuecomment-99073012 When you open database compaction page: ``` {"error":"ENOENT: no such file or directory, stat '/home/kxepal/tmp/node_modules/fauxton/d

[GitHub] couchdb-fauxton pull request: Fauxton Server for use with NPM

2015-05-05 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/395#issuecomment-99072803 Oh, no... GET http://localhost:8000/_utils/js/ace/theme-idle_fingers.js - HTTP 404 GET http://localhost:8000/_utils/js/ace/mode-json.js - HTTP 404 --- If

[GitHub] couchdb-fauxton pull request: Fauxton Server for use with NPM

2015-05-05 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/395#issuecomment-99072704 A few warnings on install: ``` npm WARN engine follow@0.11.4: wanted: {"node":"0.10.x || 0.8.x"} (current: {"node":"

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

2015-05-02 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-98408064 @nolanlawson hm..fine then (: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

2015-05-02 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-98407945 @nolanlawson > Shouldn't application/json be the expected default? I think it should. Good point! > curl -X POST "127.

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

2015-05-02 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-98395137 @nolanlawson As for PouchDB test suite issue, @chewbranca work is not merge yet. Thought, you might be interested to try 2657-fix-cassim-fabric-calls branch of

[GitHub] couchdb-chttpd pull request: Implement /db/_bulk_get endpoint

2015-05-02 Thread kxepal
Github user kxepal commented on the pull request: https://github.com/apache/couchdb-chttpd/pull/33#issuecomment-98394660 > | http 'http://localhost:15984/test/_bulk_get?revs=true' (; --- If your project is set up for it, you can reply to this email and ha

  1   2   3   4   5   6   7   8   9   >