[GitHub] couchdb issue #456: Count JS test pass/fails; return proper exit code

2017-03-18 Thread michellephung
Github user michellephung commented on the issue: https://github.com/apache/couchdb/pull/456 +1 \o/ passing tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-06-10 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r32189719 --- Diff: app/addons/dashboard/stores.js --- @@ -0,0 +1,139 @@ +// Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-06-10 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r32189748 --- Diff: app/addons/dashboard/stores.js --- @@ -0,0 +1,139 @@ +// Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-06-10 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r32189726 --- Diff: app/addons/dashboard/stores.js --- @@ -0,0 +1,139 @@ +// Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-06-10 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r32189699 --- Diff: app/addons/dashboard/stores.js --- @@ -0,0 +1,139 @@ +// Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-06-10 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/434#issuecomment-110999398 hi @wadsashika try looking here: https://github.com/apache/couchdb-fauxton/blob/master/app/addons/databases/resources.js#L128 this is where

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-06-10 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r32189617 --- Diff: app/addons/dashboard/actions.js --- @@ -0,0 +1,59 @@ +// Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-06-10 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r32189635 --- Diff: app/addons/dashboard/actiontypes.js --- @@ -0,0 +1,20 @@ +// Licensed under the Apache License, Version 2.0 (the License); you

[GitHub] couchdb-fauxton pull request: [WIP] Zen mode

2015-06-08 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/458#issuecomment-110120032 i think this is really neat! :grinning: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-fauxton pull request: Zen Mode option for small Ace Editor...

2015-06-08 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/458#issuecomment-110164888 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Zen Mode option for small Ace Editor...

2015-06-08 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/458#issuecomment-110221545 hey ben, was just thinking, I think people kind of like being able to code on one side, and see the results on the other. Is there a way to make

[GitHub] couchdb-fauxton pull request: Updates the main README doc

2015-06-08 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/457#issuecomment-110039335 +1 :D --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-06-05 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r31855783 --- Diff: app/addons/dashboard/assets/less/dashboard.less --- @@ -0,0 +1,104 @@ +// Licensed under the Apache License, Version 2.0

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-06-05 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/434#issuecomment-109458344 nice I really like the link!!! - we should try with to default darker red for the link, then when you hover over it, the color

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-06-04 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/434#issuecomment-109052067 hi wadsashika, Can you add the jira ticket url to the top comment on this git hub convo? I was hoping that for the active tasks cards

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-06-04 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/434#issuecomment-109052580 also the red font in the mock, are links, btw --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb-fauxton pull request: testing

2015-06-02 Thread michellephung
GitHub user michellephung opened a pull request: https://github.com/apache/couchdb-fauxton/pull/454 testing testing my active tasks branch is not working :( You can merge this pull request into a Git repository by running: $ git pull https://github.com/michellephung/couchdb

[GitHub] couchdb-fauxton pull request: testing

2015-06-02 Thread michellephung
Github user michellephung closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/454 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request: remove hard reset of couchdb's maste...

2015-06-01 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/447#issuecomment-107547598 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Mango: reset Header Controller

2015-06-01 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/451#issuecomment-107546746 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: IndexResults: don't throw on deletin...

2015-06-01 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/452#issuecomment-107551660 +! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-05-29 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/434#issuecomment-106874225 @wadsashika Regarding the `parse` function, One part of the greatness of Couchdb that that all of it's responses come back in JSON

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-05-29 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/434#issuecomment-106886472 Thanks @benkeen! Hi! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-fauxton pull request: Loading lines now animate on FF

2015-05-29 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/450#issuecomment-106925215 +1 nice! thanks ben! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-05-28 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/434#issuecomment-106362009 @wadsashika you can include the 'Active Tasks Store' in your 'Active Tasks Widgets Store', to get access to the functions. Then you can put any

[GitHub] couchdb-fauxton pull request: Clears the databases store after a t...

2015-05-27 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/444#issuecomment-106001409 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Mango, Indexes: link to _all_dbs usi...

2015-05-27 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/445#issuecomment-106071805 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-05-27 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r31191099 --- Diff: app/addons/dashboard/resources.js --- @@ -0,0 +1,50 @@ +// Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-05-27 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r31191165 --- Diff: app/addons/dashboard/resources.js --- @@ -0,0 +1,50 @@ +// Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-fauxton pull request: GSoC 2015 - 2214 Dashboard as main p...

2015-05-27 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/434#discussion_r31190906 --- Diff: app/addons/dashboard/stores.js --- @@ -0,0 +1,169 @@ +// Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-fauxton pull request: sauce labs

2015-05-25 Thread michellephung
GitHub user michellephung opened a pull request: https://github.com/apache/couchdb-fauxton/pull/436 sauce labs You can merge this pull request into a Git repository by running: $ git pull https://github.com/michellephung/couchdb-fauxton test-sauce Alternatively you can

[GitHub] couchdb-fauxton pull request: tests: run setup in parallel

2015-05-25 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/423#issuecomment-105330712 lol i love the asfbot default picture --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-fauxton pull request: sauce labs

2015-05-25 Thread michellephung
Github user michellephung closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/436 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request: Option to show only editor in CodeEd...

2015-05-22 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/432#issuecomment-104786104 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-22 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/401#issuecomment-104748483 no worries @nadeeshaan :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-fauxton pull request: add spy.restore to mocha test

2015-05-21 Thread michellephung
GitHub user michellephung opened a pull request: https://github.com/apache/couchdb-fauxton/pull/431 add spy.restore to mocha test You can merge this pull request into a Git repository by running: $ git pull https://github.com/michellephung/couchdb-fauxton mocha-tests-fixes

[GitHub] couchdb-fauxton pull request: add spy.restore to mocha test

2015-05-21 Thread michellephung
Github user michellephung closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/431 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-21 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-104441337 the logic for the unit tests are already written with the conversion of active task to react, (and they are still passing!) :D https

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-21 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-104438055 Ready for reviews!! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-fauxton pull request: Add loading lines to active tasks

2015-05-21 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30864085 --- Diff: app/addons/activetasks/components.react.jsx --- @@ -453,17 +384,75 @@ define([ td{startedOnMsg}/td td

[GitHub] couchdb-fauxton pull request: Open up Databases table to be extend...

2015-05-21 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/425#issuecomment-104394641 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Index editor fixes

2015-05-21 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/430#issuecomment-104333138 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Small fix for Permissions page and t...

2015-05-20 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/428#issuecomment-103991757 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Gsoc2015 moving to sub

2015-05-20 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/401#issuecomment-104068748 @robertkowalski nice! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103540621 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103558132 if your going to change the UI, I'd reword the sub-line under Roles to: `All users with any of the following role(s) will have admins access

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103561028 i think it's `any of the following` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-19 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/362#issuecomment-103579014 +1 on the code and being able to delete documents from the query!! :D :+1: although it's working, it's still a bit unclear how it's supposed

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-18 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/362#discussion_r30533751 --- Diff: app/addons/documents/index-results/stores.js --- @@ -96,17 +137,68 @@ function (FauxtonAPI, ActionTypes, HeaderActionTypes

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-18 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/362#discussion_r30534473 --- Diff: app/addons/documents/index-results/stores.js --- @@ -96,17 +137,68 @@ function (FauxtonAPI, ActionTypes, HeaderActionTypes

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-05-18 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/362#discussion_r30534904 --- Diff: app/addons/documents/index-results/stores.js --- @@ -96,17 +137,68 @@ function (FauxtonAPI, ActionTypes, HeaderActionTypes

[GitHub] couchdb-fauxton pull request: add loading lines to active tasks

2015-05-18 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-103231981 ![screen shot 2015-05-18 at 6 13 35 pm](https://cloud.githubusercontent.com/assets/836039/7691661/422f9954-fd8a-11e4-94e0-1c76ba3208a9.png) I did

[GitHub] couchdb-fauxton pull request: add loading lines to active tasks

2015-05-18 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-103234498 I just noticed I changed the background color too dark. Will fix soon. --- If your project is set up for it, you can reply to this email and have your

[GitHub] couchdb-fauxton pull request: Convert Compaction to use React.js

2015-05-15 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/403#issuecomment-102450625 this is cool garren! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-fauxton pull request: add loading lines to active tasks

2015-05-15 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-102504099 still working on this --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-fauxton pull request: add loading lines to active tasks

2015-05-15 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/386#discussion_r30429783 --- Diff: app/addons/activetasks/stores.js --- @@ -28,6 +28,35 @@ define([ this._pollingIntervalSeconds = 5

[GitHub] couchdb-fauxton pull request: General NW robustness test PR

2015-05-15 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/419#issuecomment-102465751 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: JumpToDB component now updates DB li...

2015-05-14 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/415#issuecomment-102137326 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Fix for switchDatabase.js test

2015-05-14 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/417#issuecomment-102182788 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Improving robustness of bulkDelete.j...

2015-05-14 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/418#issuecomment-102193746 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: fix nightwatch tests

2015-05-14 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/409#issuecomment-102196591 :D yay! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: fix nightwatch tests

2015-05-14 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/409#discussion_r30375421 --- Diff: app/addons/fauxton/base.js --- @@ -104,7 +104,7 @@ function (app, FauxtonAPI, Components, NavbarReactComponents, NavigationActions

[GitHub] couchdb-fauxton pull request: fix nightwatch tests

2015-05-14 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/409#discussion_r30375747 --- Diff: app/addons/fauxton/base.js --- @@ -104,7 +104,7 @@ function (app, FauxtonAPI, Components, NavbarReactComponents, NavigationActions

[GitHub] couchdb-fauxton pull request: Don't hardcode Mango in tests

2015-05-13 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/411#issuecomment-101672270 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Testing Travis

2015-05-13 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/414#issuecomment-101852203 i am fixing viewSaveManyTimes --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-fauxton pull request: DatabasePagination allows custom URL...

2015-05-13 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/412#issuecomment-101746518 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: documents: remove remaining backbone...

2015-05-12 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/406#issuecomment-101368151 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: tests: move tests to subcomponents

2015-05-12 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/405#issuecomment-101369068 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: fix viewSaveManyTimes

2015-05-12 Thread michellephung
GitHub user michellephung opened a pull request: https://github.com/apache/couchdb-fauxton/pull/407 fix viewSaveManyTimes Still in progress: fixes for: - viewSaveManyTimes - switchDatabase You can merge this pull request into a Git repository by running

[GitHub] couchdb-fauxton pull request: Improvement to NW tests

2015-05-12 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/408#issuecomment-101366273 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: NW fixes [WIP]

2015-05-12 Thread michellephung
Github user michellephung closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/407 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request: fix deleteDatabaseModal test

2015-05-12 Thread michellephung
GitHub user michellephung opened a pull request: https://github.com/apache/couchdb-fauxton/pull/409 fix deleteDatabaseModal test You can merge this pull request into a Git repository by running: $ git pull https://github.com/michellephung/couchdb-fauxton tests---fix-some

[GitHub] couchdb-fauxton pull request: Detect if we run on a backdoor port

2015-05-11 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/400#issuecomment-101015247 how to test? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-fauxton pull request: DatabasePagination now supports pass...

2015-05-11 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/404#issuecomment-101015008 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: add loading lines to active tasks

2015-05-09 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/386#discussion_r29995481 --- Diff: app/addons/activetasks/actions.js --- @@ -14,13 +14,14 @@ define([ 'addons/activetasks/actiontypes', 'addons

[GitHub] couchdb-fauxton pull request: add loading lines to active tasks

2015-05-09 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-100534913 @sebastianrothbucher :) i can work on the the logic/naming a little more. I'm still a little unhappy with the way the timing works, since

[GitHub] couchdb-fauxton pull request: Fixing view bugs

2015-05-07 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/399#issuecomment-100035160 +1 it works for me --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-fauxton pull request: [WIP] Fix view bugs

2015-05-06 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/391#issuecomment-99523820 i've noticed two things. 1. Uncaught TypeError: this._collection.hasPrevious is not a function -- happens when i save a view, then try to use

[GitHub] couchdb-fauxton pull request: Remove plugins that are no longer us...

2015-05-05 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/397#issuecomment-99117091 link: https://issues.apache.org/jira/browse/COUCHDB-2680 --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] couchdb-fauxton pull request: add loading lines to active tasks

2015-05-05 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-99193360 ok i need a little time to implement --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-fauxton pull request: Verify install page converted to Rea...

2015-05-04 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/393#discussion_r29608267 --- Diff: app/addons/verifyinstall/stores.js --- @@ -0,0 +1,99 @@ +// Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-fauxton pull request: Verify install page converted to Rea...

2015-05-04 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/393#issuecomment-98803019 +1 note: i like how this was organized --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] couchdb-fauxton pull request: [WIP] Fix view bugs

2015-04-22 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/391#discussion_r28882270 --- Diff: app/addons/components/react-components.react.jsx --- @@ -63,15 +64,123 @@ function (app, FauxtonAPI, React, Components

[GitHub] couchdb-fauxton pull request: add loading lines to active tasks

2015-04-21 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-94881151 Hey I got some feedback from the #couchdb-dev channel that I'm gonna incorporate into this branch. 1. Instead of 1 row per active task, 2 rows

[GitHub] couchdb-fauxton pull request: Databases view in react

2015-04-21 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/370#discussion_r28821282 --- Diff: app/addons/databases/actions.js --- @@ -0,0 +1,105 @@ +// Licensed under the Apache License, Version 2.0 (the License); you may

[GitHub] couchdb-fauxton pull request: Test for error handling in Active Ta...

2015-04-21 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/388#issuecomment-94946079 merged 431e164b497ba5b21536b85c2654d6279d77ed02 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb-fauxton pull request: Test for error handling in Active Ta...

2015-04-21 Thread michellephung
Github user michellephung closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/388 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] couchdb-fauxton pull request: Databases view in react

2015-04-20 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/370#discussion_r28735599 --- Diff: app/addons/databases/components.react.jsx --- @@ -0,0 +1,303 @@ +// Licensed under the Apache License, Version 2.0 (the License

[GitHub] couchdb-fauxton pull request: Databases view in react

2015-04-20 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/370#discussion_r28735910 --- Diff: app/addons/fauxton/components.react.jsx --- @@ -83,10 +83,132 @@ function (app, FauxtonAPI, React, ZeroClipboard

[GitHub] couchdb-fauxton pull request: Databases view in react

2015-04-20 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/370#discussion_r28737382 --- Diff: app/addons/fauxton/components.react.jsx --- @@ -83,10 +83,132 @@ function (app, FauxtonAPI, React, ZeroClipboard

[GitHub] couchdb-fauxton pull request: Databases view in react

2015-04-20 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/370#issuecomment-94591639 if you're feeling up to it, some whitespace nits: in the render functions, 1.) there are some html code that have nested tags and create long

[GitHub] couchdb-fauxton pull request: Databases view in react

2015-04-20 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/370#discussion_r28735951 --- Diff: app/addons/fauxton/components.react.jsx --- @@ -83,10 +83,132 @@ function (app, FauxtonAPI, React, ZeroClipboard

[GitHub] couchdb-fauxton pull request: Part 2/2 for Mango:

2015-04-20 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/362#issuecomment-94512554 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: add loading lines to active tasks

2015-04-20 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-94549604 i am toying with the idea of adding a condition which checks the delay, and only shows a delay if the fetch is very short. That way on longer

[GitHub] couchdb-fauxton pull request: add loading lines to active tasks

2015-04-17 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/386#issuecomment-93997534 Do you like the idea? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-fauxton pull request: Add test for hasDataSize function

2015-04-17 Thread michellephung
GitHub user michellephung opened a pull request: https://github.com/apache/couchdb-fauxton/pull/389 Add test for hasDataSize function You can merge this pull request into a Git repository by running: $ git pull https://github.com/michellephung/couchdb-fauxton add-test

[GitHub] couchdb-fauxton pull request: Test for error handling in Active Ta...

2015-04-17 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/388#discussion_r28626267 --- Diff: app/addons/activetasks/tests/activetasks.componentsSpec.react.jsx --- @@ -70,6 +70,14 @@ define

[GitHub] couchdb-fauxton pull request: Test for error handling in Active Ta...

2015-04-17 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/388#discussion_r28626153 --- Diff: app/addons/activetasks/tests/activetasks.componentsSpec.react.jsx --- @@ -70,6 +70,14 @@ define

[GitHub] couchdb-fauxton pull request: Test for error handling in Active Ta...

2015-04-17 Thread michellephung
Github user michellephung commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/388#discussion_r28626362 --- Diff: app/addons/activetasks/tests/activetasks.componentsSpec.react.jsx --- @@ -70,6 +70,14 @@ define

[GitHub] couchdb-fauxton pull request: Test for error handling in Active Ta...

2015-04-17 Thread michellephung
GitHub user michellephung opened a pull request: https://github.com/apache/couchdb-fauxton/pull/388 Test for error handling in Active Tasks You can merge this pull request into a Git repository by running: $ git pull https://github.com/michellephung/couchdb-fauxton Active

  1   2   3   >