[GitHub] couchdb-fauxton pull request #883: Navbar refactor

2017-03-30 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/883#discussion_r109031856 --- Diff: app/addons/fauxton/navigation/stores.js --- @@ -94,8 +107,7 @@ Stores.NavBarStore = FauxtonAPI.Store.extend

[GitHub] couchdb-fauxton issue #893: consistent error message for views and doc

2017-03-30 Thread millayr
Github user millayr commented on the issue: https://github.com/apache/couchdb-fauxton/pull/893 +1 pending travis and addressing my comment --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request #893: consistent error message for views and do...

2017-03-30 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/893#discussion_r108957741 --- Diff: app/addons/documents/index-results/actions.js --- @@ -63,8 +63,9 @@ export default { if (responseText.reason

[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying

2017-03-29 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108677355 --- Diff: assets/less/formstyles.less --- @@ -78,25 +78,52 @@ button:focus { } } } -.btn-primary { - background

[GitHub] couchdb-fauxton issue #892: Continued styles and text tidying

2017-03-29 Thread millayr
Github user millayr commented on the issue: https://github.com/apache/couchdb-fauxton/pull/892 I noticed that hovering over database names on the `_all_dbs` page doesn't change the link text color. Is that your intent? --- If your project is set up for it, you can reply to

[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying

2017-03-29 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108674467 --- Diff: assets/less/templates.less --- @@ -177,13 +177,12 @@ font-weight: normal; font-family: helvetica

[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying

2017-03-29 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108672812 --- Diff: assets/less/formstyles.less --- @@ -78,25 +78,52 @@ button:focus { } } } -.btn-primary { - background

[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying

2017-03-29 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108672779 --- Diff: assets/less/formstyles.less --- @@ -78,25 +78,52 @@ button:focus { } } } -.btn-primary { - background

[GitHub] couchdb-fauxton pull request #892: Continued styles and text tidying

2017-03-29 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/892#discussion_r108672638 --- Diff: assets/less/formstyles.less --- @@ -78,25 +78,52 @@ button:focus { } } } -.btn-primary { - background

[GitHub] couchdb-fauxton issue #892: Continued styles and text tidying

2017-03-28 Thread millayr
Github user millayr commented on the issue: https://github.com/apache/couchdb-fauxton/pull/892 Looks like you're reintroducing the bug fixed in https://github.com/apache/couchdb-fauxton/pull/891. You might want to consider rebasing this branch onto master. --- If your proje

[GitHub] couchdb-fauxton pull request #883: Navbar refactor

2017-03-28 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/883#discussion_r108500571 --- Diff: app/addons/fauxton/navigation/stores.js --- @@ -94,8 +107,7 @@ Stores.NavBarStore = FauxtonAPI.Store.extend

[GitHub] couchdb-fauxton pull request #883: Navbar refactor

2017-03-28 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/883#discussion_r108499614 --- Diff: app/addons/fauxton/navigation/container/NavBar.js --- @@ -0,0 +1,77 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request #883: Navbar refactor

2017-03-28 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/883#discussion_r108499644 --- Diff: app/addons/fauxton/navigation/stores.js --- @@ -10,24 +10,37 @@ // License for the specific language governing permissions and

[GitHub] couchdb-fauxton pull request #883: Navbar refactor

2017-03-28 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/883#discussion_r108499514 --- Diff: app/addons/fauxton/navigation/actiontypes.js --- @@ -19,5 +19,9 @@ export default { NAVBAR_SET_VERSION_INFO

[GitHub] couchdb-fauxton pull request #883: Navbar refactor

2017-03-28 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/883#discussion_r108499571 --- Diff: app/addons/fauxton/navigation/components/NavBar.js --- @@ -0,0 +1,107 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request #883: Navbar refactor

2017-03-28 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/883#discussion_r108499467 --- Diff: app/addons/fauxton/appwrapper.js --- @@ -49,27 +53,52 @@ class ContentWrapper extends React.Component { } } -const

[GitHub] couchdb-fauxton pull request #883: Navbar refactor

2017-03-28 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/883#discussion_r108499424 --- Diff: app/addons/auth/base.js --- @@ -19,58 +19,46 @@ Auth.session = new Auth.Session(); FauxtonAPI.setSession(Auth.session

[GitHub] couchdb-fauxton pull request #808: Handle trailing params when building URLs...

2017-03-28 Thread millayr
Github user millayr closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/808 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-fauxton pull request #891: Remove extra spacing on dashboard content...

2017-03-28 Thread millayr
GitHub user millayr reopened a pull request: https://github.com/apache/couchdb-fauxton/pull/891 Remove extra spacing on dashboard content when navbar minimized Before: ![image](https://cloud.githubusercontent.com/assets/6378840/24413192/b7850d34-13a8-11e7-8a9e-ac818ff52d24.png

[GitHub] couchdb-fauxton pull request #891: Remove extra spacing on dashboard content...

2017-03-28 Thread millayr
Github user millayr closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/891 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-fauxton pull request #891: Remove extra spacing on dashboard content...

2017-03-28 Thread millayr
GitHub user millayr opened a pull request: https://github.com/apache/couchdb-fauxton/pull/891 Remove extra spacing on dashboard content when navbar minimized Before: ![image](https://cloud.githubusercontent.com/assets/6378840/24413192/b7850d34-13a8-11e7-8a9e-ac818ff52d24.png

[GitHub] couchdb-fauxton issue #889: Shown database doesn't exist notification

2017-03-28 Thread millayr
Github user millayr commented on the issue: https://github.com/apache/couchdb-fauxton/pull/889 Cool +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] couchdb-fauxton pull request #889: Shown database doesn't exist notification

2017-03-28 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/889#discussion_r108425211 --- Diff: app/addons/documents/sidebar/__tests__/sidebar.actions.test.js --- @@ -0,0 +1,60 @@ +// Licensed under the Apache License, Version 2.0

[GitHub] couchdb-fauxton pull request #889: Shown database doesn't exist notification

2017-03-28 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/889#discussion_r108420139 --- Diff: app/addons/documents/index-results/actions.js --- @@ -50,20 +50,23 @@ export default { if (!options.collection.fetch

[GitHub] couchdb-fauxton pull request #889: Shown database doesn't exist notification

2017-03-28 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/889#discussion_r108424752 --- Diff: app/addons/documents/mango/__tests__/mango.actions.test.js --- @@ -0,0 +1,60 @@ +// Licensed under the Apache License, Version 2.0

[GitHub] couchdb-fauxton pull request #889: Shown database doesn't exist notification

2017-03-28 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/889#discussion_r108423500 --- Diff: app/addons/documents/index-results/actions.js --- @@ -50,20 +50,23 @@ export default { if (!options.collection.fetch

[GitHub] couchdb-fauxton issue #887: Confirmation modal not closable when deleting a ...

2017-03-27 Thread millayr
GitHub user millayr opened an issue: https://github.com/apache/couchdb-fauxton/issues/887 Confirmation modal not closable when deleting a configuration option When deleting a configuration setting from the Configuration section of the dashboard, users are unable to dismiss the

[GitHub] couchdb-fauxton pull request #882: Fixing failing nightwatch tests due to st...

2017-03-23 Thread millayr
GitHub user millayr reopened a pull request: https://github.com/apache/couchdb-fauxton/pull/882 Fixing failing nightwatch tests due to styling edits fixing nightwatch suite to work with recent styling edits You can merge this pull request into a Git repository by running

[GitHub] couchdb-fauxton pull request #882: Fixing failing nightwatch tests due to st...

2017-03-23 Thread millayr
Github user millayr closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/882 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] couchdb-fauxton pull request #883: Navbar refactor

2017-03-23 Thread millayr
GitHub user millayr opened a pull request: https://github.com/apache/couchdb-fauxton/pull/883 Navbar refactor Trying to take over https://github.com/apache/couchdb-fauxton/pull/826 You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] couchdb-fauxton pull request #882: Fixing failing nightwatch tests due to st...

2017-03-23 Thread millayr
GitHub user millayr opened a pull request: https://github.com/apache/couchdb-fauxton/pull/882 Fixing failing nightwatch tests due to styling edits fixing nightwatch suite to work with recent styling edits You can merge this pull request into a Git repository by running: $ git

[GitHub] couchdb-fauxton issue #880: filter out all design docs for replication activ...

2017-03-22 Thread millayr
Github user millayr commented on the issue: https://github.com/apache/couchdb-fauxton/pull/880 LGTM +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] couchdb-fauxton issue #879: Replication UI does not render when _replicator ...

2017-03-21 Thread millayr
Github user millayr commented on the issue: https://github.com/apache/couchdb-fauxton/issues/879 We filter out `_design/_replicator` here: https://github.com/apache/couchdb-fauxton/blob/master/app/addons/replication/api.js#L308 We may just want to filter out anything that

[GitHub] couchdb-fauxton issue #879: Replication UI does not render when _replicator ...

2017-03-21 Thread millayr
GitHub user millayr opened an issue: https://github.com/apache/couchdb-fauxton/issues/879 Replication UI does not render when _replicator contains ddoc with filter function If a user has created a ddoc in the `_replicator` db that defines a filter function for use with filtered

[GitHub] couchdb-fauxton issue #868: Update to webpack 2

2017-03-20 Thread millayr
Github user millayr commented on the issue: https://github.com/apache/couchdb-fauxton/pull/868 +1 pending the minor comments/tweaks --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[GitHub] couchdb-fauxton issue #868: Update to webpack 2

2017-03-17 Thread millayr
Github user millayr commented on the issue: https://github.com/apache/couchdb-fauxton/pull/868 This is great! Left a few comments @garrensmith --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[GitHub] couchdb-fauxton pull request #868: Update to webpack 2

2017-03-17 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/868#discussion_r106692449 --- Diff: test/test.config.underscore --- @@ -12,7 +12,7 @@ // License for the specific language governing permissions and limitations under

[GitHub] couchdb-fauxton pull request #868: Update to webpack 2

2017-03-17 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/868#discussion_r106686509 --- Diff: devserver.js --- @@ -4,6 +4,7 @@ var webpack = require('webpack'); var WebpackDev = require('webpack-dev-server

[GitHub] couchdb-fauxton pull request #868: Update to webpack 2

2017-03-17 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/868#discussion_r106692659 --- Diff: test/test.config.underscore --- @@ -12,7 +12,7 @@ // License for the specific language governing permissions and limitations under

[GitHub] couchdb-fauxton pull request #868: Update to webpack 2

2017-03-17 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/868#discussion_r106698032 --- Diff: webpack.config.release.js --- @@ -49,51 +73,71 @@ module.exports = { }, module: { -preLoaders

[GitHub] couchdb-fauxton pull request #868: Update to webpack 2

2017-03-17 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/868#discussion_r106686584 --- Diff: devserver.js --- @@ -98,9 +81,33 @@ var runWebpackServer = function () { // don't explode on cancelled req

[GitHub] couchdb-fauxton issue #866: Permanent notification layout bug on pages with ...

2017-03-16 Thread millayr
Github user millayr commented on the issue: https://github.com/apache/couchdb-fauxton/issues/866 merged --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] couchdb-fauxton issue #866: Permanent notification layout bug on pages with ...

2017-03-16 Thread millayr
Github user millayr closed the issue at: https://github.com/apache/couchdb-fauxton/issues/866 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] couchdb-fauxton issue #866: Permanent notification layout bug on pages with ...

2017-03-15 Thread millayr
Github user millayr commented on the issue: https://github.com/apache/couchdb-fauxton/issues/866 PR: https://github.com/apache/couchdb-fauxton/pull/867 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb-fauxton pull request #867: Update layout for pages with secondary na...

2017-03-15 Thread millayr
GitHub user millayr opened a pull request: https://github.com/apache/couchdb-fauxton/pull/867 Update layout for pages with secondary nav When rendering the permanent notification at the top of the screen (see https://github.com/apache/couchdb-fauxton/pull/865), we noticed a bug in

[GitHub] couchdb-fauxton issue #866: Permanent notification layout bug on pages with ...

2017-03-15 Thread millayr
GitHub user millayr opened an issue: https://github.com/apache/couchdb-fauxton/issues/866 Permanent notification layout bug on pages with secondary nav When rendering the permanent notification banner on pages that have the secondary nav, we cover a portion of the content window

[GitHub] couchdb-fauxton issue #864: Update replication to work with scheduler api

2017-03-14 Thread millayr
Github user millayr commented on the issue: https://github.com/apache/couchdb-fauxton/pull/864 +1 after tests --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105734625 --- Diff: app/addons/replication/components/common-table.js --- @@ -0,0 +1,406 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105738831 --- Diff: app/addons/replication/components/common-table.js --- @@ -0,0 +1,406 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105743148 --- Diff: app/addons/replication/components/replicate-activity.js --- @@ -0,0 +1,116 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105743029 --- Diff: app/addons/replication/components/replicate-activity.js --- @@ -0,0 +1,116 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105734764 --- Diff: app/addons/replication/components/common-table.js --- @@ -0,0 +1,406 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105718172 --- Diff: app/addons/replication/components/common-activity.js --- @@ -0,0 +1,107 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105717253 --- Diff: app/addons/replication/components/common-activity.js --- @@ -0,0 +1,107 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105717406 --- Diff: app/addons/replication/components/common-activity.js --- @@ -0,0 +1,107 @@ +// Licensed under the Apache License, Version 2.0 (the

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105749148 --- Diff: app/addons/replication/route.js --- @@ -39,25 +41,31 @@ const ReplicationRouteObject = FauxtonAPI.RouteObject.extend

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105711712 --- Diff: app/addons/replication/api.js --- @@ -228,38 +255,176 @@ export const parseReplicationDocs = (rows) => { status:

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105748635 --- Diff: app/addons/replication/controller.js --- @@ -186,25 +208,79 @@ export default class ReplicationController extends React.Component

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105750432 --- Diff: app/addons/replication/stores.js --- @@ -77,6 +110,23 @@ const ReplicationStore = FauxtonAPI.Store.extend({ this._activitySort

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105690327 --- Diff: app/addons/replication/api.js --- @@ -16,6 +16,30 @@ import app from '../../app'; import FauxtonAPI from '

[GitHub] couchdb-fauxton pull request #864: Update replication to work with scheduler...

2017-03-13 Thread millayr
Github user millayr commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/864#discussion_r105683957 --- Diff: app/addons/replication/actions.js --- @@ -171,13 +298,20 @@ const deleteDocs = (docs) => { }); }; -co