[GitHub] couchdb-fauxton pull request: grunt works :) with $ grunt nightwat...

Github user wohali commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/136#discussion_r19924055 --- Diff: Gruntfile.js --- @@ -394,8 +403,27 @@ module.exports = function(grunt) { mocha_phantomjs: { all: ['test

[GitHub] couchdb-couch-mrview pull request: Add view changes functionality

Github user wohali commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/2#issuecomment-61512720 :dancers: :dancer: :fr: :maple_leaf: :ca: :gb: :us: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb-couch-mrview pull request: Add view changes functionality

Github user wohali commented on the pull request: https://github.com/apache/couchdb-couch-mrview/pull/2#issuecomment-60799298 Suggestion: Merge as is, call the feature experimental in 2.0. We can then sort out the clustered interface, the things built on top of this, and the problems

[GitHub] couchdb pull request: fixes COUCHDB-2362 admin auth in dev cluster

Github user wohali commented on a diff in the pull request: https://github.com/apache/couchdb/pull/269#discussion_r19378073 --- Diff: dev/pbkdf2.py --- @@ -0,0 +1,130 @@ +# -*- coding: utf-8 -*- + +pbkdf2 +~~ + +This module implements pbkdf2

[GitHub] couchdb pull request: fixes COUCHDB-2362 admin auth in dev cluster

Github user wohali commented on a diff in the pull request: https://github.com/apache/couchdb/pull/269#discussion_r19378084 --- Diff: dev/pbkdf2.py --- @@ -0,0 +1,130 @@ +# -*- coding: utf-8 -*- + +pbkdf2 +~~ + +This module implements pbkdf2

[GitHub] couchdb pull request: fixes COUCHDB-2362 admin auth in dev cluster

Github user wohali commented on the pull request: https://github.com/apache/couchdb/pull/269#issuecomment-60500707 +1 once you resolve the 2 issues above :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb pull request: Add myself to COMMITTERS

Github user wohali commented on the pull request: https://github.com/apache/couchdb/pull/273#issuecomment-59866439 +1 :+1: Welcome! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Added js style guide

Github user wohali commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/91#discussion_r19056394 --- Diff: styleguide.md --- @@ -0,0 +1,192 @@ +# JavaScript Style Guide + +This document attempts to codify the JavaScript code style rules

[GitHub] couchdb-fauxton pull request: Added js style guide

Github user wohali commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/91#discussion_r18743839 --- Diff: styleguide.md --- @@ -0,0 +1,192 @@ +# JavaScript Style Guide + +This document attempts to codify the JavaScript code style rules

[GitHub] couchdb pull request: New document sidebar

Github user wohali commented on the pull request: https://github.com/apache/couchdb/pull/248#issuecomment-48938431 Is this ready for review again? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] couchdb pull request: Fauxton: remove the Log Component

Github user wohali commented on the pull request: https://github.com/apache/couchdb/pull/239#issuecomment-44452139 Other than @kxepal's comment, +1, per our mailing list discussion. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb pull request: Fauxton: fix burger - COUCHDB-2234

Github user wohali commented on the pull request: https://github.com/apache/couchdb/pull/225#issuecomment-43576163 Can we please stop derailing a discussion about fix burger with logo arguments? Thank you. --- If your project is set up for it, you can reply to this email and have

[GitHub] couchdb-fabric pull request: 1993 bigcouch couch mrview

Github user wohali commented on a diff in the pull request: https://github.com/apache/couchdb-fabric/pull/1#discussion_r11654330 --- Diff: src/fabric.erl --- @@ -278,15 +278,31 @@ query_view(DbName, DesignName, ViewName, QueryArgs) - -spec query_view(dbname(), #doc{} | binary

[GitHub] couchdb pull request: Remove log level name from the log list so...

Github user wohali commented on the pull request: https://github.com/apache/couchdb/pull/205#issuecomment-40404667 Sorry for the drive-by earlier. I agree with @deathbearbrown and @garrensmith here. Filtering on log level is useful, and CTRL+F to search row by row

[GitHub] couchdb pull request: Remove log level name from the log list so...

Github user wohali commented on the pull request: https://github.com/apache/couchdb/pull/205#issuecomment-40250369 Lots of people are red-blue and red-green colour blind. -1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] couchdb pull request: advance the documentation in DELETE db with ...

Github user wohali commented on the pull request: https://github.com/apache/couchdb/pull/192#issuecomment-38329421 +1, LGTM. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

<    1   2   3