Github user garrensmith closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/216
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the f
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-71431491
This is not needed anymore.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project d
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70531412
Looks great. The only thing I spotted was on IE11, editing a View and
clicking Save reloads the page but the Edit Index tab section has disappeared.
But this is
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70481697
I've broken this into two smaller pull requests for easier merging. They
are #233 and #235
---
If your project is set up for it, you can reply to this emai
Github user sebastianrothbucher commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70416338
I do like the idea of factoring out the Actions to make the whole thing
more testable - so +1
---
If your project is set up for it, you can reply to
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70361832
thanks @robertkowalski, I've removed the footer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as we
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70181637
Hey Garren,
This is cool. I didn't run into any problems clicking around.
I looked into the failing test. I pushed a solution here:
h
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70104524
the testsuite is red, at least one test is failing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70104552
hi garren, this is going to be great. i found three small issues
---
If your project is set up for it, you can reply to this email and have your
reply app
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70104289
editing the map and then adding a custom reduce will "freeze" both editor
windows after saving and also unformat the code: https://cloudup.com/cWQLkqlm2Mx
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-70103272
The editor partially overlaps the footer:
:
>
> Github user robertkowalski commented on a diff in the pull request:
>
>https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22928942
>
>--- Diff: app/addons/documents/actiontypes.js ---
>@@ -0,0 +
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22934313
--- Diff: app/addons/documents/actions.js ---
@@ -0,0 +1,164 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69911892
there are still error-containers:
https://github.com/apache/couchdb-fauxton/pull/216#discussion-diff-22875951
---
If your project is set up for it, you c
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69911614
double click on a design-doc: sidebar/navbar is not visible and size of the
editor is too small
![bildschirmfoto 2015-01-14 um 13 50
45](https://
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22928942
--- Diff: app/addons/documents/actiontypes.js ---
@@ -0,0 +1,24 @@
+// use this file except in compliance with the License. You may obtain
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22928906
--- Diff: app/addons/documents/components.react.jsx ---
@@ -0,0 +1,473 @@
+define([
+ "app",
--- End diff --
missing lice
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69846759
Couple of small aesthetic things.
1. When editing the View and clicking the `Edit Index` tab to shrink it,
it's smooth up until the last moment when ther
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69846358
Small thing. An extra space is getting prepended to the map function each
time it's saved. To reproduce:
1. Select any database.
2. All Design Docs -> Ne
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22905830
--- Diff: app/addons/documents/actions.js ---
@@ -0,0 +1,164 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
not
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22876420
--- Diff: app/addons/documents/actions.js ---
@@ -0,0 +1,164 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22876340
--- Diff: app/addons/documents/actions.js ---
@@ -0,0 +1,164 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22875951
--- Diff: app/addons/documents/actions.js ---
@@ -0,0 +1,164 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69776649
@robertkowalski I've pushed a new commit with all your feedback. The only
thing I haven't done is convert all the expect's to asserts.
---
If your project i
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22875319
--- Diff: app/addons/documents/actions.js ---
@@ -0,0 +1,164 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
n
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22865560
--- Diff: app/addons/documents/tests/componentsSpec.react.jsx ---
@@ -0,0 +1,199 @@
+// Licensed under the Apache License, Version 2.0 (the
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22865875
--- Diff: app/addons/documents/tests/componentsSpec.react.jsx ---
@@ -0,0 +1,199 @@
+// Licensed under the Apache License, Version 2.0 (the
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22864950
--- Diff: app/addons/documents/actions.js ---
@@ -0,0 +1,164 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69751254
the added sourcefiles need license headers
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69749636
The react tests are not unmounting elements,
`React.unmountComponentAtNode(mytestedCompontent);`
---
If your project is set up for it, you can reply to t
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69745704
the a
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69745443
Starting now functional testing:
; yo
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69328401
I found two general points:
- I am no Flux-expert but reading examples and tutorials I always see the
dispatcher separated from the store (in a s
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69244262
This all looks really great - very clean! No criticisms are coming to mind.
One thing to note: the main branch has the nav bar state saved in local
stor
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22677599
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -0,0 +1,170 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you ma
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22676309
--- Diff: app/addons/fauxton/components.react.jsx ---
@@ -0,0 +1,170 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you ma
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22675973
--- Diff: app/addons/fauxton/actions.js ---
@@ -0,0 +1,56 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
not
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69229185
I wonder if we could include the jsx dependency as a grunt module? Without
jsx installed it fails to build & it would nice to have npm handle all that for
us. Th
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69183352
Awesome @garrensmith !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not ha
Github user garrensmith commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22652275
--- Diff: app/core/store.js ---
@@ -0,0 +1,34 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+// use
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#issuecomment-69176468
great work, very promising! I left some comments from things that i
stumbled upon at a first glance.
The diff is hard to review (+183,439 â1,0
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22650187
--- Diff: app/addons/documents/routes-documents.js ---
@@ -453,14 +461,14 @@ function(app, FauxtonAPI, Documents, Changes, Index,
DocEditor, D
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22650165
--- Diff: app/addons/documents/routes-documents.js ---
@@ -317,9 +318,9 @@ function(app, FauxtonAPI, Documents, Changes, Index,
DocEditor, Dat
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22650102
--- Diff: app/addons/documents/components.react.js ---
@@ -0,0 +1,465 @@
+define([
+ "api",
+ "react",
+ "addons/documents/s
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22649942
--- Diff: app/addons/fauxton/components.react.js ---
@@ -0,0 +1,170 @@
+// Licensed under the Apache License, Version 2.0 (the "License");
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22649867
--- Diff: app/core/store.js ---
@@ -0,0 +1,34 @@
+// Licensed under the Apache License, Version 2.0 (the "License"); you may
not
+// u
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22649821
--- Diff: package.json ---
@@ -25,28 +49,6 @@
"author": "",
"license": "Apache V2",
"devDependencies": {
-"async":
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/216#discussion_r22649783
--- Diff: tasks/couchserver.js ---
@@ -45,11 +45,11 @@ module.exports = function (grunt) {
accept = req.headers.accept.split(','
GitHub user garrensmith opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/216
Adding React into Fauxton
This is the building blocks for using React in Fauxton. The index editor
and the main side header link are now done in React with a flux pattern.
You can m
52 matches
Mail list logo
