[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-20 Thread robertkowalski
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/234 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-20 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70624999 merged as b872ebfa4adfc2c8a9d0643150d3404f9713ab0e and 17cfa631c1dde186f06cd1eff61552746e9ae931 --- If your project is set up for it, you can reply to th

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70573471 +1 this looks good Robert. Ran 10 times locally, all turning up green. --- If your project is set up for it, you can reply to this email and have your reply appe

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70571730 Sure, no problem! I'll look at it shortly. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If yo

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70568352 green test, @benkeen mind taking a look on my attempt to fix the flaky test? f25b52d i run it approx. 10 times and it stayed green. if the code l

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70496317 +1 working nicely --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70485504 ugh, monday morning... should be fixed now, @garrensmith --- If your project is set up for it, you can reply to this email and have your reply appear on G

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/234#issuecomment-70481974 I've getting a 'Uncaught TypeError: Cannot read property 'preventDefault' of undefined' in the console. This happens if I click on the 'x' then wait 1 second

[GitHub] couchdb-fauxton pull request: Don't redirect on dismissing the not...

2015-01-19 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/234 Don't redirect on dismissing the notification If you edited a document and then clicked on cancel, you were redirected to the database list closes COUCHDB-2550 You can m