[GitHub] couchdb-fauxton pull request: Fix missing confirmation when leavin...

2015-02-17 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/267#issuecomment-74662626 merged as b030b218a5e9e1fd891bc9750c593f356dd5cb7f and c6e6a438f9bd29434215c93f0552db8192fecf75 --- If your project is set up for it, you can reply to th

[GitHub] couchdb-fauxton pull request: Fix missing confirmation when leavin...

2015-02-17 Thread robertkowalski
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/267 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] couchdb-fauxton pull request: Fix missing confirmation when leavin...

2015-02-17 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/267#issuecomment-74662259 @benkeen I like the idea of #263 as it follows the principles of the least surprise. What do you think of something like this for changing the rou

[GitHub] couchdb-fauxton pull request: Fix missing confirmation when leavin...

2015-02-12 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/267#issuecomment-74127677 Awesome. +1 I still think https://github.com/apache/couchdb-fauxton/pull/263 should be added, because the currently logic is incorrect: it just checks f

[GitHub] couchdb-fauxton pull request: Fix missing confirmation when leavin...

2015-02-12 Thread robertkowalski
GitHub user robertkowalski opened a pull request: https://github.com/apache/couchdb-fauxton/pull/267 Fix missing confirmation when leaving editor To not render a property in React we need to pass `null` to it. If we are passing `false` or `"false"` it gets rendered into the DOM.