Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/271#issuecomment-74696471
Merged as 4a9334c76ce8926a3e230c6726f6041d454b79c7
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user benkeen closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/271
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user benkeen commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/271#discussion_r24757978
--- Diff: app/addons/databases/tests/nightwatch/checkDatabaseTooltip.js ---
@@ -0,0 +1,49 @@
+// Licensed under the Apache License, Version 2.0
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/271#issuecomment-74530075
Thanks, @robertkowalski! All fixed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user benkeen commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/271#issuecomment-74581011
Thanks Michelle :) I'll merge once it goes green.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
Github user michellephung commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/271#issuecomment-74572886
+1 nice job @benkeen!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/271#discussion_r24743116
--- Diff: app/addons/databases/tests/nightwatch/checkDatabaseTooltip.js ---
@@ -0,0 +1,49 @@
+// Licensed under the Apache License,
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/271#discussion_r24743159
--- Diff: app/addons/databases/tests/nightwatch/checkDatabaseTooltip.js ---
@@ -0,0 +1,49 @@
+// Licensed under the Apache License,
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/271#discussion_r24743193
--- Diff: app/addons/databases/tests/nightwatch/checkDatabaseTooltip.js ---
@@ -0,0 +1,49 @@
+// Licensed under the Apache License,
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/271#issuecomment-74489973
Hey @benkeen - great work.
I found a small issue (also partly the reason the test fails)
---
If your project is set up for it, you can reply to
Github user robertkowalski commented on a diff in the pull request:
https://github.com/apache/couchdb-fauxton/pull/271#discussion_r24743263
--- Diff: app/addons/databases/tests/nightwatch/checkDatabaseTooltip.js ---
@@ -0,0 +1,49 @@
+// Licensed under the Apache License,
GitHub user benkeen opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/271
Improved tooltip for ! icon on db page
This adds a jQuery tooltip for the (!) icons on the Databases
page and includes a nightwatch test to confirm the mouseover
behaviour.
12 matches
Mail list logo
