[GitHub] couchdb-fauxton pull request: Keep track of sidebar status

2015-01-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featur

[GitHub] couchdb-fauxton pull request: Keep track of sidebar status

2015-01-07 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/210#issuecomment-69143218 +1 That is a nice solution. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-fauxton pull request: Keep track of sidebar status

2015-01-07 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/210#issuecomment-69113675 Hey @garrensmith, I think it's better now. I didn't end up using a separate object for the state, but instead just made all the changes within the NavBar View, w

[GitHub] couchdb-fauxton pull request: Keep track of sidebar status

2015-01-06 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/210#issuecomment-68889145 Good idea @garrensmith, will do! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] couchdb-fauxton pull request: Keep track of sidebar status

2015-01-05 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/210#issuecomment-68832058 @benkeen this is a nice idea. The code needs some neatening up. Rather create an object that hides away the fact that you using localStorage to keep state. T

[GitHub] couchdb-fauxton pull request: Keep track of sidebar status

2015-01-05 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/210#issuecomment-68761254 @garrensmith, this look okay to you? Checking local storage in main.js is a little new, so I wanted to run it by you before merging. --- If your project is set

[GitHub] couchdb-fauxton pull request: Keep track of sidebar status

2015-01-05 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/210#issuecomment-68727980 this works +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] couchdb-fauxton pull request: Keep track of sidebar status

2014-12-30 Thread benkeen
GitHub user benkeen opened a pull request: https://github.com/apache/couchdb-fauxton/pull/210 Keep track of sidebar status This is a simple usability fix: it keeps track of whether the user has expanded or shrunk the sidebar so on future refreshes it doesn't revert to the wro