[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-20 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103895949 Issued fixed and merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-20 Thread garrensmith
Github user garrensmith closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/421 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103578598 Sorry to be a pain, one more minor thing: it allows you to add a blank entry. I think this is an old bug. The UI looks a little wonky due to the empty user name

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103561028 i think it's `any of the following` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If you

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103558132 if your going to change the UI, I'd reword the sub-line under "Roles" to: `All users with any of the following role(s) will have admins access.`, o

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread robertkowalski
Github user robertkowalski commented on a diff in the pull request: https://github.com/apache/couchdb-fauxton/pull/421#discussion_r30612649 --- Diff: app/addons/permissions/components.react.jsx --- @@ -0,0 +1,221 @@ +// Licensed under the Apache License, Version 2.0 (the "Licens

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103547574 Besides previous comment, +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project doe

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103540621 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feat

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/421#issuecomment-103539465 Code looks great, but I'll look it over a little longer. One minor UX niggle: after adding an item in any of the four sections on the Permissions page, it shoul

[GitHub] couchdb-fauxton pull request: Permissions react

2015-05-19 Thread garrensmith
GitHub user garrensmith opened a pull request: https://github.com/apache/couchdb-fauxton/pull/421 Permissions react Permissions for a database done in React You can merge this pull request into a Git repository by running: $ git pull https://github.com/garrensmith/couchdb-fauxt