[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-20 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70617627 Thanks for reviewing. This is merged. Woo first React work in :+1: --- If your project is set up for it, you can reply to this email and have your reply app

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-20 Thread garrensmith
Github user garrensmith closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70601632 Looks great. The only thing I spotted was on IE11, editing a View and clicking Save reloads the page but the Edit Index tab section has disappeared. But this is

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70594028 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70523920 +1 maybe @benkeen can take a final look? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub a

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread garrensmith
GitHub user garrensmith reopened a pull request: https://github.com/apache/couchdb-fauxton/pull/233 React building blocks and navbar I've decided to break up #216 into two. This is the first one. It is the main react dependancies along with the main navigation bar done in React.js

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread garrensmith
Github user garrensmith closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the f

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70490948 @garrensmith, the travis run fails. can you fix the failing test? --- If your project is set up for it, you can reply to this email and have your reply ap

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/233#issuecomment-70482380 @robertkowalski I've fixed the './base' path and replaced " with '. I haven't added a separate commit for the whitespace this time as I want to reduce the nu

[GitHub] couchdb-fauxton pull request: React building blocks and navbar

2015-01-19 Thread garrensmith
GitHub user garrensmith opened a pull request: https://github.com/apache/couchdb-fauxton/pull/233 React building blocks and navbar I've decided to break up #216 into two. This is the first one. It is the main react dependancies along with the main navigation bar done in React.js Yo