[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-16 Thread robertkowalski
Github user robertkowalski closed the pull request at: https://github.com/apache/couchdb-fauxton/pull/189 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if th

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-16 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-67219218 thanks everyone invlovled! :tada: c328feb256f50e1fb021c994d9aaf073a1f0d87a --- If your project is set up for it, you can reply to this email and have your

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-16 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-67202848 just a tiny thing, ![screen shot 2014-12-16 at 11 57 34 am](https://cloud.githubusercontent.com/assets/836039/5458701/84b0f0e2-8522-11e4-88ad-28e29cfe2

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-16 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-67194596 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featu

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-14 Thread seanbarclay
Github user seanbarclay commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66956208 hey @robertkowalski i'm still seeing issues w/drop-shadows. Let's schedule some time on the calendar for either tomorrow or tues AM my time, go through some

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-12 Thread ocelotpotpie
Github user ocelotpotpie commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66810990 +1 here! This is a heck of a PR! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-12 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66810445 +1 :) nice job @robertkowalski --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-12 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66805822 Looks really good Robert. Just that one super minor thing, other than that zero problems. +1 --- If your project is set up for it, you can reply to this email a

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-12 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66805393 One super small thing: the Add Option header link is 2px too high. Could the CSS be changed to `#add-section-button { padding: 12px 14px; }` (formerly `10px 14px

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-12 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66803880 thank you all for your testing and reviews! i fixed the issues and would be happy if you could take a second look. --- If your project is set up for it,

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-12 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66785119 yay i finally fixed the typeahead! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-12 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66766269 The typeahead is a real problem... our container has to be overflow:hidden but it cuts of the typeahead which is a child of the input which is placed in t

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-11 Thread seanbarclay
Github user seanbarclay commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66708538 Thanks @robertkowalski. This is def making progress. Issues I found: 1) API URl pop-over- the arrow now seems to be on the right side? 2) D

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-11 Thread michellephung
Github user michellephung commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66672047 this pr is huge! nice job :D one tiny thing i saw: ![screen shot 2014-12-11 at 2 04 55 pm](https://cloud.githubusercontent.com/assets/8360

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-11 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-9431 Awesome work @robertkowalski! Other than that one issue, works smoothly. +1 --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-11 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-8495 Small thing, there used to be a line in between the doc search ID header field and the Query Options link, like the one between Query Options and API URL. !

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-11 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-1805 @benkeen thank you - really appreciated - I'm depending on feedback here! I fixed the issues and while I checked the pages again I noticed a small

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-10 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66542828 Nice! Don't shoot me, but two small things: - the cog is placed a little bit too far to the left. Could it be centered in the little box it's in? - the Q

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-10 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66487782 i had to change some things in 73662744d2723168a078654b923c715a1bad95ae to have all the borders for the cog and other parts working again. --- If your pr

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-09 Thread robertkowalski
Github user robertkowalski commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66383647 ping @seanbarclay --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does no

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-09 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66345095 Possibly these issues are related too? COUCHDB-2502, COUCHDB-2503 --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-08 Thread garrensmith
Github user garrensmith commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-66043458 This is fantastic. I see the same issues as @benkeen. This is really exciting. Great work @robertkowalski --- If your project is set up for it, you can rep

[GitHub] couchdb-fauxton pull request: Rewrite CSS for Header and Pane-Layo...

2014-12-05 Thread benkeen
Github user benkeen commented on the pull request: https://github.com/apache/couchdb-fauxton/pull/189#issuecomment-65850065 This is going to be great - big improvement, the CSS was a mess. One thing: the header seems to be styled a bit oddly, see: ![image](https://cloud.g