Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-snappy/pull/2
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature i
Github user janl commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-81632205
merged!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enab
Github user bryanpkc commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-79343104
@janl @kxepal Just a gentle reminder about this pull request. It has
already been merged upstream (snappy-erlang-nif). Thanks.
---
If your project is set up for i
Github user janl commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-75084052
@bryanpkc I donât think Travis is gonna help with running anything but
their stock environment, but we have a Jenkins setup that we can use.
---
If your project is
Github user bryanpkc commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-75082325
@janl I have briefly looked at Travis CI; it seems to support only Ubuntu
as a build environment. Will it work with Debian? There isn't a Ubuntu build
for s390x ye
Github user bryanpkc commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74990294
All commits squashed, trailing space removed. Thanks for the review.
---
If your project is set up for it, you can reply to this email and have your
reply appear o
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74927424
All good. At least it doesn't breaks anything (:
+1 from me with the hope that we'll have big-endian host to build the couch
there. Also might worth to check the
Github user bryanpkc commented on a diff in the pull request:
https://github.com/apache/couchdb-snappy/pull/2#discussion_r24929628
--- Diff: rebar.config.script ---
@@ -0,0 +1,13 @@
+case <<1:16/native>> of
+<<1,0>> ->
+CONFIG;
+<<0,1>> ->
+
Github user janl commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74919967
just a note that I think the CI test discussion here is **not** blocking
merging this in
---
If your project is set up for it, you can reply to this email and have yo
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-snappy/pull/2#discussion_r24924456
--- Diff: rebar.config.script ---
@@ -0,0 +1,13 @@
+case <<1:16/native>> of
+<<1,0>> ->
+CONFIG;
+<<0,1>> ->
+
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-snappy/pull/2#discussion_r24924320
--- Diff: rebar.config.script ---
@@ -0,0 +1,13 @@
+case <<1:16/native>> of
+<<1,0>> ->
+CONFIG;
+<<0,1>> ->
+
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-snappy/pull/2#discussion_r24924159
--- Diff: rebar.config.script ---
@@ -0,0 +1,14 @@
+HandleBigEndianPort = fun
+F([H|T]) when element(1, H) == port_env ->
--- End diff --
Github user bryanpkc commented on a diff in the pull request:
https://github.com/apache/couchdb-snappy/pull/2#discussion_r24923370
--- Diff: rebar.config.script ---
@@ -0,0 +1,14 @@
+HandleBigEndianPort = fun
+F([H|T]) when element(1, H) == port_env ->
--- End diff -
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74894929
theoretically...yes, need to try.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project doe
Github user janl commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74892552
we have some CI hardware, would qemu running there would help?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub a
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74889419
@bryanpkc quick googling showed me this one:
https://people.debian.org/~aurel32/qemu/ ||
http://www.aurel32.net/info/debian_mips_qemu.php
Much likely there
Github user bryanpkc commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74888615
@janl OK, that doesn't sound too bad. I could certainly help with testing
that way for now. I am checking if we could help with CI on our hardware, but I
cannot pr
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74887216
@janl with qemu it's possible to emulate different endian. Raspberry PI
IIRC is a bi-endian, but little one is preferred.
---
If your project is set up for it, you
Github user janl commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74886312
@bryanpkc ongoing: whenever we make a release, run `make test` and report
here or on the dev@couchdb.apache.org mailing list :)
Ideally weâd have a big endia
Github user bryanpkc commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74885302
@janl @kxepal I can build and run "make check" on s390x (and potentially
ppc64 if I can borrow the machines). I could learn how to package too. What is
the amount
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74884731
@janl me too, especially such that we cannot test even manually during
regular build process. I believe @bryanpkc made these changes because he is
able to test it IR
Github user janl commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74883487
@kxepal yeah I imagine, and we probably donât want to re-shuffle the code
so you can inject endianness from the tests. Maybe we can have a test that only
runs on BE
Github user kxepal commented on a diff in the pull request:
https://github.com/apache/couchdb-snappy/pull/2#discussion_r24903186
--- Diff: rebar.config.script ---
@@ -0,0 +1,14 @@
+HandleBigEndianPort = fun
+F([H|T]) when element(1, H) == port_env ->
--- End diff --
Github user kxepal commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74870033
Hi @bryanpkc and welcome! (:
@janl I think the only way to test this is to actually try to built it on
big-endian hosts.
---
If your project is set up for
Github user janl commented on the pull request:
https://github.com/apache/couchdb-snappy/pull/2#issuecomment-74868043
@bryanpkc nice one! Is there a way to add a test case for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
> bryanpkc wrote on 2015-02-17 01:22:02 PM:
>
>> From: bryanpkc
>> To: dev@couchdb.apache.org
>> Date: 2015-02-17 01:22 PM
>> Subject: [GitHub] couchdb-snappy pull request: Support big-endian builds
>>
>> GitHub user bryanpkc opened a pull request:
>&
01:22 PM
> Subject: [GitHub] couchdb-snappy pull request: Support big-endian builds
>
> GitHub user bryanpkc opened a pull request:
>
> https://github.com/apache/couchdb-snappy/pull/2
>
> Support big-endian builds
>
> Google snappy's configure script defines WO
GitHub user bryanpkc opened a pull request:
https://github.com/apache/couchdb-snappy/pull/2
Support big-endian builds
Google snappy's configure script defines WORDS_BIGENDIAN in config.h if it
detects that the build machine is big-endian. rebar should do the same when
building the
28 matches
Mail list logo
