[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user deathbearbrown commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35521109 +1 to $.indexOf --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. To do so, please top-post your res

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user garrensmith commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35520319 Ok I'm happy with the $.indexOf fix. It is the easiest fix. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user BigBlueHat commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35519514 @rnewson good call on the date and my too-quick copy paste from MDN's copyright page. They have liberal licenses on their code regardless...but we would need to attri

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user kxepal commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35518506 > @rnewson @garrensmith @kxepal please consider merging this sooner than later to keep this community awesome. :smile: I'm fine with any solution, just wanted to

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user garrensmith commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35518341 @BigBlueHat I understand your frustration. But we need to find a balance between merging quickly and making sure they the right patch for Couchdb. As @ziggythehamste

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user ziggythehamster commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35516537 It's really not a huge deal to change the patch to do ES5-Shim. How would I handle the licensing bit? From: BigBlueHat

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user rnewson commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35516543 Also, I'm told Fauxton *has* feature parity today. Is that untrue? If so, what's missing? Supporting Futon *and* Fauxton is a burden, and preserving Futon reduce

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user rnewson commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35516375 How did you date the code sample in question to after August 20, 2010? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user BigBlueHat commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35515126 Let's merge this and not wait for a heavier change for this on-it's-way-out project. The licensing for array.indexof.js is public domain: > Code samples a

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user garrensmith commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35508275 Great. Looking forward to it. On 19 Feb 2014, at 5:07 PM, Keith Gable wrote: > @garrensmith - I like the ES5 Shim much better. I'll update this PR w

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user ziggythehamster commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35507769 @garrensmith - I like the ES5 Shim much better. I'll update this PR with the ES5 Shim and the license.skip change to make Travis happy. @everyone else -

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user MikaelSoderstrom commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35506289 Ahh, forgot that Windows 7 was shipped with IE 8. Well, then I guess there must be support for it. I still suggest that ES5 shim and similar should be u

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user MikaelSoderstrom commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35491040 > really, I don't think that performance is matters in place of locating user role in the list that almost always has 1-2-3 elements, max 10 elements. A

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user kxepal commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35490347 > One of the benefits with jQuery is that it just works in all older and modern browsers (if you are using 1.9.x that is). The drawback is that you will not the same perf

Re: [GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

I also initially took the view that CouchDb should not have to support IE8, as Microsoft won't. But searching around shows that Windows 7 initially came with IE8, which puts it under the same support cycle as Windows 7, meaning there are years of pain yet to suffer. Nick On 19 February 2014 10:3

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user MikaelSoderstrom commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35485395 One of the benefits with jQuery is that it just works in all older and modern browsers (if you are using 1.9.x that is). The drawback is that you will not the s

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user rnewson commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35483590 We are deleting Futon entirely, maybe we should just bring that forward to the next release and put Fauxton in its rightful place? --- If your project is set up for it,

Re: [GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Also a good approach. It would just require finding all the instances of `indexOf` and replacing with `$.inArray` On 19 Feb 2014, at 11:52 AM, kxepal wrote: > Github user kxepal commented on the pull request: > >https://github.com/apache/couchdb/pull/153#issuecomment-35482011 > >Erhm.

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user kxepal commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35482011 Erhm...this may sounds awkward and everyone will recall one good joke from StackOverflow site, but why not to use jQuery instead? (: [$.inArray](http://api.jquery

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user garrensmith commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35481965 Thats actually a better idea and should hopefully prevent any other issues. @ziggythehamster could you change this PR to rather include the es5-shim. You will also h

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user MikaelSoderstrom commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35481578 An alternative is to use ES5 shim instead, which should fix other errors where functions on the ES5 Array.prototype and other things like .bind() are used.

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user andywenk commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35479288 Garren - is this a question we should ask legal@ ? Would you do this? --- If your project is set up for it, you can reply to this email and have your reply appear on Gi

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

Github user garrensmith commented on the pull request: https://github.com/apache/couchdb/pull/153#issuecomment-35476190 This looks fine to me. My only concern would be is that licensed correctly? What is the correct way of licensing content from the Mozilla Developer Network? --- If

[GitHub] couchdb pull request: Add polyfill for IE8 Array.indexOf

GitHub user ziggythehamster opened a pull request: https://github.com/apache/couchdb/pull/153 Add polyfill for IE8 Array.indexOf IE8 does not support Array.indexOf. This polyfill adds this missing method when needed (if not supported by the browser). NB: I have no way of te