Re: Introduction of open tracing (otter)

2019-09-17 Thread Ilya Khlopotov
> Previously you were talking about the trace filter configuration settings > being opaque blobs, but they don’t look opaque in the RFC. Did that change? I recently discovered that there are multiple flavors of otter. The most developed one is https://github.com/project-fifo/otters. This version

Re: Introduction of open tracing (otter)

2019-09-16 Thread Paul Davis
Aha! Nice! On Thu, Sep 12, 2019 at 12:19 PM Ilya Khlopotov wrote: > > > Ilya, you mentioned hopping from the coordinator to RPC workers which > > is definitely an open problem. I only skimmed the docs months ago but > > one of the things I came across was trying to figure out how to > > represent

Re: Introduction of open tracing (otter)

2019-09-16 Thread Adam Kocoloski
Looks good, I left a few comments. Previously you were talking about the trace filter configuration settings being opaque blobs, but they don’t look opaque in the RFC. Did that change? Adam > On Sep 16, 2019, at 3:38 PM, Ilya Khlopotov wrote: > > Hi, > > The RFC is ready for review > https

Re: Introduction of open tracing (otter)

2019-09-16 Thread Ilya Khlopotov
Hi, The RFC is ready for review https://github.com/apache/couchdb-documentation/pull/440 Best regards, ILYA (aka iilyak) On 2019/09/10 18:32:03, Ilya Khlopotov wrote: > Hi, > > I wanted to run this idea by the ML to see if there is any interest before > investing time into preparing formal

Re: Introduction of open tracing (otter)

2019-09-13 Thread Ilya Khlopotov
Hi, There is one technical problem which worth a discussion. Otter's configuration is a complex data structure stored in application environment (https://github.com/opentracing-contrib/opentracing-erlang#filter-configuration). This makes it problematic to use, because: - we cannot use existent

Re: Introduction of open tracing (otter)

2019-09-12 Thread Ilya Khlopotov
> Ilya, you mentioned hopping from the coordinator to RPC workers which > is definitely an open problem. I only skimmed the docs months ago but > one of the things I came across was trying to figure out how to > represent parallel traces. Given we have a coordinator that has N>1 > RPC workers runni

Re: Introduction of open tracing (otter)

2019-09-11 Thread Ilya Khlopotov
> For me the main question is how much overhead is associated with tracing. Bellow is a breakdown on cost of various operations > Can an admin safely configure it to run in production? I believe it can be used in production if we are careful with filters. We need to configure prefilter_rules t

Re: Introduction of open tracing (otter)

2019-09-11 Thread Jan Lehnardt
Hi Ilya, I like this quite a bit. It came by IRC or Slack the other day and it felt like a natural fit, modulo the perf questions, but I’d be surprised if that was a large problem, given what this is meant to do. That said, some folks disable logging for performance reasons *chuckle* Best Jan

Re: Introduction of open tracing (otter)

2019-09-11 Thread Garren Smith
This looks really good. Just checking are we planning to integrate this for the 3.x release or 4.x? On Wed, Sep 11, 2019 at 12:50 AM Paul Davis wrote: > +1 > > On Tue, Sep 10, 2019 at 4:51 PM Adam Kocoloski > wrote: > > > > Yeah, I meant the latter — joining CouchDB’s span information to spans

Re: Introduction of open tracing (otter)

2019-09-10 Thread Paul Davis
+1 On Tue, Sep 10, 2019 at 4:51 PM Adam Kocoloski wrote: > > Yeah, I meant the latter — joining CouchDB’s span information to spans in an > app built against CouchDB so a developer can see the end-to-end story. Wasn’t > proposing user-customized spans inside the DB :) > > Adam > > > On Sep 10,

Re: Introduction of open tracing (otter)

2019-09-10 Thread Adam Kocoloski
Yeah, I meant the latter — joining CouchDB’s span information to spans in an app built against CouchDB so a developer can see the end-to-end story. Wasn’t proposing user-customized spans inside the DB :) Adam > On Sep 10, 2019, at 5:43 PM, Paul Davis wrote: > > Looks pretty awesome. I've got

Re: Introduction of open tracing (otter)

2019-09-10 Thread Paul Davis
Looks pretty awesome. I've got basically the same questions as Koco on performance. There are also games like the lager transforms that conditionally enable/disable log levels at runtime. If memory serves, it ended up being a single function call overhead to check for disabled based on some dynamic

Re: Introduction of open tracing (otter)

2019-09-10 Thread Adam Kocoloski
I think this is a great idea overall, particularly given the number of significant changes that are happening in the codebase between 3.0 and 4.0. For me the main question is how much overhead is associated with tracing. Can an admin safely configure it to run in production? Is it possible to sa

Introduction of open tracing (otter)

2019-09-10 Thread Ilya Khlopotov
Hi, I wanted to run this idea by the ML to see if there is any interest before investing time into preparing formal RFC. # Problem statement Collecting profiling data is very tricky at the moment. Developers have to run generic profiling tools which are not aware of CouchDB specifics. This ma