Re: git commit: Disable checking for string query_params values

2013-04-05 Thread Benoit Chesneau
Thinking more about that issue, and I think that once the patch for the view changes will be integrated there is a need to accept any JSON value there for the view params. Then maybe just removing the comments since we won't have it anymore. On Fri, Apr 5, 2013 at 8:12 PM, Benoit Chesneau wrote:

Re: git commit: Disable checking for string query_params values

2013-04-05 Thread Benoit Chesneau
If the intention is to remove that filter, then why just comment it? Imo the patch should be reworked. Also not sure it should be re removed, the question is more why should we accept any JSON value there? What is the purpose? Shouldn't we on the contrary fix the replicator db to not accept that?

Re: git commit: Disable checking for string query_params values

2013-04-05 Thread Noah Slater
Okay. Thanks! On Fri, Apr 5, 2013 at 6:01 PM, Jason Smith wrote: > No and no. > On Wed, Apr 3, 2013 at 12:24 AM, Noah Slater wrote: >> Has it been backed out? (Should it be?) >> >> >> On 25 March 2013 11:12, Jason Smith wrote: >> >>> I checked, this commit is only in the COUCHDB-1534 branch in

Re: git commit: Disable checking for string query_params values

2013-04-05 Thread Jason Smith
No and no. On Wed, Apr 3, 2013 at 12:24 AM, Noah Slater wrote: > Has it been backed out? (Should it be?) > > > On 25 March 2013 11:12, Jason Smith wrote: > >> I checked, this commit is only in the COUCHDB-1534 branch in Git. It is not >> in any others (1.3.x, master). >> >> >> On Mon, Mar 25, 20

Re: git commit: Disable checking for string query_params values

2013-04-02 Thread Noah Slater
Has it been backed out? (Should it be?) On 25 March 2013 11:12, Jason Smith wrote: > I checked, this commit is only in the COUCHDB-1534 branch in Git. It is not > in any others (1.3.x, master). > > > On Mon, Mar 25, 2013 at 11:09 AM, Jason Smith wrote: > > > Oh wow, sorry, all, I missed this.

Re: git commit: Disable checking for string query_params values

2013-03-25 Thread Jason Smith
I checked, this commit is only in the COUCHDB-1534 branch in Git. It is not in any others (1.3.x, master). On Mon, Mar 25, 2013 at 11:09 AM, Jason Smith wrote: > Oh wow, sorry, all, I missed this. > > The commit addresses COUCHDB-1534. However that issue is not yet closed > due to missing unit

Re: git commit: Disable checking for string query_params values

2013-03-25 Thread Jason Smith
Oh wow, sorry, all, I missed this. The commit addresses COUCHDB-1534. However that issue is not yet closed due to missing unit tests. And Paul wants to remove the function entirely (which is fine by me). The comment about iris-monitor was for me, when I diff our branch against ASF, I would recall

Re: git commit: Disable checking for string query_params values

2013-03-23 Thread Noah Slater
Was this a mistaken commit? Was it resolved? On 10 October 2012 21:06, Jan Lehnardt wrote: > Jason, > > did you mean to commit this to Apache? > > Cheers > Jan > -- > > > On Sep 14, 2012, at 04:08 , j...@apache.org wrote: > > > Updated Branches: > > refs/heads/COUCHDB-1534 [created] 835b57b19

Re: git commit: Disable checking for string query_params values

2012-10-10 Thread Jan Lehnardt
Jason, did you mean to commit this to Apache? Cheers Jan -- On Sep 14, 2012, at 04:08 , j...@apache.org wrote: > Updated Branches: > refs/heads/COUCHDB-1534 [created] 835b57b19 > > > Disable checking for string query_params values > > > Project: http://git-wip-us.apache.org/repos/asf/couc