Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]

2024-05-01 Thread via GitHub
ottlinger commented on code in PR #240: URL: https://github.com/apache/creadur-rat/pull/240#discussion_r1586731939 ## apache-rat-core/src/main/java/org/apache/rat/Defaults.java: ## @@ -152,27 +163,35 @@ public SortedSet getLicenseFamilies(LicenseFilter filter) { * @param

Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]

2024-05-01 Thread via GitHub
ottlinger commented on PR #240: URL: https://github.com/apache/creadur-rat/pull/240#issuecomment-2088992912 @Claudenw the extraction into the Tika-class looks very nice - thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (RAT-369) Add SpotBugs to the pom files.

2024-05-01 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/RAT-369?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842759#comment-17842759 ] ASF subversion and git services commented on RAT-369: - Commit eaa207180e

Re: [PR] RAT-54: Tika based document analyzer [creadur-rat]

2024-05-01 Thread via GitHub
Claudenw commented on PR #240: URL: https://github.com/apache/creadur-rat/pull/240#issuecomment-2089624723 @ottlinger If you approve I can merge this. If you want more eyes on it, lets's invite a few reviewers. -- This is an automated message from the Apache Git Service. To respond to th